Skip to contentSkip to conversation

ia64: require -Wl,--hash-style=sysv

PATCH In review Nick Desaulniers 2 participants 4 messages Apr 23, 2019 – May 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ia64: require -Wl,--hash-style=sysv

Towards the goal of removing cc-ldoption, it seems that --hash-stylewas added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.

---
 arch/ia64/kernel/Makefile.gate | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/Makefile.gate +1 -1
index f53faf48b7ce..846867bff6d6 100644
@@ -11,7 +11,7 @@ quiet_cmd_gate = GATE    $@
       cmd_gate = $(CC) -nostdlib $(GATECFLAGS_$(@F)) -Wl,-T,$(filter-out FORCE,$^) -o $@
 
 GATECFLAGS_gate.so = -shared -s -Wl,-soname=linux-gate.so.1 \
-		     $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
+		     -Wl,--hash-style=sysv
 $(obj)/gate.so: $(obj)/gate.lds $(obj)/gate.o FORCE
 	$(call if_changed,gate)
 
Signature · 1 line
2.21.0.593.g511ec345e18-goog
#1 lore raw
Quoted 27 lines · Nick Desaulniers

Towards the goal of removing cc-ldoption, it seems that --hash-style> was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.

---
 arch/ia64/kernel/Makefile.gate | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/Makefile.gate +1 -2
index f53faf48b7ce..846867bff6d6 100644
@@ -11,7 +11,7 @@ quiet_cmd_gate = GATE    $@
       cmd_gate = $(CC) -nostdlib $(GATECFLAGS_$(@F)) -Wl,-T,$(filter-out FORCE,$^) -o $@
 
 GATECFLAGS_gate.so = -shared -s -Wl,-soname=linux-gate.so.1 \
-                    $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
+                    -Wl,--hash-style=sysv
 $(obj)/gate.so: $(obj)/gate.lds $(obj)/gate.o FORCE
        $(call if_changed,gate)
 
--
Quoted 2 lines

2.21.0.593.g511ec345e18-goog

bumping for review

Signature · 2 lines
Thanks,
~Nick Desaulniers
#2 lore raw

bumping for review, as the merge window is now open.

Quoted 38 lines · Nick Desaulniers
Quoted 27 lines · Nick Desaulniers

Towards the goal of removing cc-ldoption, it seems that --hash-style> > was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.

---
 arch/ia64/kernel/Makefile.gate | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/Makefile.gate +1 -2
index f53faf48b7ce..846867bff6d6 100644
@@ -11,7 +11,7 @@ quiet_cmd_gate = GATE    $@
       cmd_gate = $(CC) -nostdlib $(GATECFLAGS_$(@F)) -Wl,-T,$(filter-out FORCE,$^) -o $@
 
 GATECFLAGS_gate.so = -shared -s -Wl,-soname=linux-gate.so.1 \
-                    $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
+                    -Wl,--hash-style=sysv
 $(obj)/gate.so: $(obj)/gate.lds $(obj)/gate.o FORCE
        $(call if_changed,gate)
 
--
Quoted 2 lines

2.21.0.593.g511ec345e18-goog

bumping for review

--
Thanks,
~Nick Desaulniers

Signature · 2 lines
Thanks,
~Nick Desaulniers
#3 lore raw
Quoted 2 lines · Nick Desaulniers

bumping for review, as the merge window is now open.

ia64 is not very active these days.

I applied this to my kbuild tree.
I will send PR for this in the current MW.

Thanks.

Quoted 46 lines
Quoted 35 lines · Nick Desaulniers
Quoted 27 lines · Nick Desaulniers

Towards the goal of removing cc-ldoption, it seems that --hash-style> > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.

---
 arch/ia64/kernel/Makefile.gate | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/Makefile.gate +1 -2
index f53faf48b7ce..846867bff6d6 100644
@@ -11,7 +11,7 @@ quiet_cmd_gate = GATE    $@
       cmd_gate = $(CC) -nostdlib $(GATECFLAGS_$(@F)) -Wl,-T,$(filter-out FORCE,$^) -o $@
 
 GATECFLAGS_gate.so = -shared -s -Wl,-soname=linux-gate.so.1 \
-                    $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
+                    -Wl,--hash-style=sysv
 $(obj)/gate.so: $(obj)/gate.lds $(obj)/gate.o FORCE
        $(call if_changed,gate)
 
--
Quoted 2 lines

2.21.0.593.g511ec345e18-goog

bumping for review

Quoted 3 lines

--
Thanks,
~Nick Desaulniers

--
Thanks,
~Nick Desaulniers

Signature · 2 lines
Best Regards
Masahiro Yamada