Skip to contentSkip to conversation

drm/i915/gen11: enable support for headerless msgs

PATCH In review Dongwon Kim 5 participants 16 messages Apr 23, 2019 – May 24, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gen11: enable support for headerless msgs

set bit5 (Headerless Message for Pre-emptable Contexts) in SAMPLER_MODE register while initializing render ring to enable support for headerless messages for preemptable GPGPU contexts on Gen11.

---
 drivers/gpu/drm/i915/i915_reg.h  |  1 +
 drivers/gpu/drm/i915/intel_lrc.c | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index b74824f0b5b1..b45042f71c0a 100644
@@ -8862,6 +8862,7 @@ enum {
 #define   GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC	(1 << 7)
 
 #define GEN10_SAMPLER_MODE		_MMIO(0xE18C)
+#define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG	(1 << 5)
 
 /* IVYBRIDGE DPF */
 #define GEN7_L3CDERRST1(slice)		_MMIO(0xB008 + (slice) * 0x200) /* L3CD Error Status 1 */
drivers/gpu/drm/i915/intel_lrc.c +18 -0
index 4e0a351bfbca..07c8fe2a5549 100644
@@ -1807,6 +1807,21 @@ static int gen8_init_common_ring(struct intel_engine_cs *engine)
 	return 0;
 }
 
+static int gen11_init_render_ring(struct intel_engine_cs *engine)
+{
+	struct drm_i915_private *dev_priv = engine->i915;
+	int ret;
+
+	ret = gen8_init_common_ring(engine);
+	if (ret)
+		return ret;
+
+	/* allow headerless messages for pre-emptable GPGPU contexts */
+	I915_WRITE(GEN10_SAMPLER_MODE, _MASKED_BIT_ENABLE(GEN11_SAMPLER_ENABLE_HEADLESS_MSG));
+
+	return 0;
+}
+
 static void execlists_reset_prepare(struct intel_engine_cs *engine)
 {
 	struct intel_engine_execlists * const execlists = &engine->execlists;
@@ -2516,6 +2531,9 @@ int logical_render_ring_init(struct intel_engine_cs *engine)
 		return ret;
 
 	/* Override some for render ring. */
+	if (INTEL_GEN(engine->i915) == 11)
+		engine->init_hw = gen11_init_render_ring;
+
 	engine->init_context = gen8_init_rcs_context;
 	engine->emit_flush = gen8_emit_flush_render;
 	engine->emit_fini_breadcrumb = gen8_emit_fini_breadcrumb_rcs;
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen11: enable support for headerless msgs

== Series Details ==

== Series Details ==

Series: drm/i915/gen11: enable support for headerless msgs
URL : https://patchwork.freedesktop.org/series/59839/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2f58a29e79fd drm/i915/gen11: enable support for headerless msgs
-:8: WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'?
#8: 
messages for preemptable GPGPU contexts on Gen11.

total: 0 errors, 1 warnings, 0 checks, 37 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for drm/i915/gen11: enable support for headerless msgs

In reply to Dongwon Kim
== Series Details ==

== Series Details ==

Series: drm/i915/gen11: enable support for headerless msgs
URL : https://patchwork.freedesktop.org/series/59839/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5973 -> Patchwork_12856
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59839/revisions/1/mbox/

Known issues
------------

Here are the changes found in Patchwork_12856 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-icl-u3/igt@amdgpu/[email protected]

* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> [SKIP][2] ([fdo#109276]) +7 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-icl-u3/igt@[email protected]

* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> [SKIP][3] ([fdo#109289]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][4] -> [DMESG-FAIL][5] ([fdo#110235 ])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> [SKIP][6] ([fdo#109284]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-icl-u3/igt@[email protected]

* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u3: NOTRUN -> [SKIP][7] ([fdo#109285]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-icl-u3/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> [FAIL][8] ([fdo#103167])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-icl-u3/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- fi-skl-6260u: NOTRUN -> [SKIP][9] ([fdo#109271]) +37 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-skl-6260u/igt@kms_psr@cursor_plane_move.html

#### Possible fixes ####

* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: [DMESG-FAIL][10] ([fdo#110235 ]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (48 -> 43)
------------------------------

Additional (2): fi-skl-6260u fi-icl-u3
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5973 -> Patchwork_12856

CI_DRM_5973: ef44300e9fca20a6e9fd2d3c5909bec18dfd410e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12856: 2f58a29e79fdaa0c4aacb2f5cd1b8792a34c6027 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

2f58a29e79fd drm/i915/gen11: enable support for headerless msgs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Dongwon Kim

Quoting Dongwon Kim (2019-04-23 20:05:03)

Quoted 3 lines

set bit5 (Headerless Message for Pre-emptable Contexts) in SAMPLER_MODE register while initializing render ring to enable support for headerless messages for preemptable GPGPU contexts on Gen11.

See icl_ctx_workarounds_init() and explain why we must set the default value as userspace is already given access to SAMPLER_MODE. Does changing the default break other workloads?
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✓ Fi.CI.IGT: success for drm/i915/gen11: enable support for headerless msgs

In reply to Dongwon Kim
== Series Details ==

== Series Details ==

Series: drm/i915/gen11: enable support for headerless msgs
URL : https://patchwork.freedesktop.org/series/59839/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5973_full -> Patchwork_12856_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_12856_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_bad_reloc@negative-reloc-lut-bsd1:
- shard-iclb: NOTRUN -> [SKIP][1] ([fdo#109276]) +14 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb4/igt@[email protected]

* igt@gem_exec_parse@basic-rejected:
- shard-iclb: NOTRUN -> [SKIP][2] ([fdo#109289]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@[email protected]

* igt@gem_mmap_gtt@coherency:
- shard-iclb: NOTRUN -> [SKIP][3] ([fdo#109292]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb5/igt@[email protected]

* igt@gem_mocs_settings@mocs-reset-ctx-dirty-render:
- shard-iclb: NOTRUN -> [SKIP][4] ([fdo#110206])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@[email protected]

* igt@gem_stolen@stolen-no-mmap:
- shard-iclb: NOTRUN -> [SKIP][5] ([fdo#109277]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb5/igt@[email protected]

* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-iclb: NOTRUN -> [SKIP][6] ([fdo#110426])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb3/igt@[email protected]

* igt@i915_pm_rpm@gem-evict-pwrite:
- shard-skl: NOTRUN -> [INCOMPLETE][7] ([fdo#107807])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl5/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- shard-iclb: NOTRUN -> [SKIP][8] ([fdo#109293])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb4/igt@[email protected]

* igt@i915_query@query-topology-known-pci-ids:
- shard-iclb: NOTRUN -> [SKIP][9] ([fdo#109303])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb3/igt@[email protected]

* igt@i915_selftest@live_active:
- shard-skl: [PASS][10] -> [DMESG-WARN][11] ([fdo#110385])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-skl8/igt@i915_selftest@live_active.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl4/igt@i915_selftest@live_active.html

* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][12] -> [DMESG-WARN][13] ([fdo#108566]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-apl2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-apl6/igt@[email protected]

* igt@kms_chamelium@dp-frame-dump:
- shard-iclb: NOTRUN -> [SKIP][14] ([fdo#109284]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][15] -> [FAIL][16] ([fdo#104873])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-glk2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-glk2/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-iclb: NOTRUN -> [SKIP][17] ([fdo#109274]) +11 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@[email protected]

* igt@kms_flip@2x-wf_vblank-ts-check:
- shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271]) +69 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-snb4/igt@kms_flip@2x-wf_vblank-ts-check.html

* igt@kms_flip_tiling@flip-to-x-tiled:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#108134])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb6/igt@[email protected]

* igt@kms_flip_tiling@flip-x-tiled:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#108303])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: NOTRUN -> [FAIL][23] ([fdo#103167])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: [PASS][24] -> [FAIL][25] ([fdo#103167]) +6 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb8/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271]) +17 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-kbl3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-onoff:
- shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109280]) +20 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@[email protected]

* igt@kms_lease@setcrtc_implicit_plane:
- shard-skl: NOTRUN -> [FAIL][28] ([fdo#110281])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl3/igt@kms_lease@setcrtc_implicit_plane.html

* igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271]) +28 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-apl1/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-f:
- shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#109278])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-apl1/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-e:
- shard-kbl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#109278]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-kbl3/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-f:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#109278]) +15 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109278]) +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb3/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#109441])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb4/igt@kms_psr@psr2_basic.html

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_rotation_crc@sprite-rotation-180:
- shard-apl: [PASS][37] -> [INCOMPLETE][38] ([fdo#103927])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-apl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-apl6/igt@[email protected]

* igt@kms_setmode@basic:
- shard-apl: [PASS][39] -> [FAIL][40] ([fdo#99912])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-apl1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-apl3/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][41] ([fdo#99912])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl5/igt@[email protected]
- shard-iclb: NOTRUN -> [FAIL][42] ([fdo#99912])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb3/igt@[email protected]
- shard-kbl: [PASS][43] -> [FAIL][44] ([fdo#99912])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-kbl1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-kbl6/igt@[email protected]

* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][45] -> [FAIL][46] ([fdo#100047])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb5/igt@kms_sysfs_edid_timing.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@kms_sysfs_edid_timing.html

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [PASS][47] -> [DMESG-WARN][48] ([fdo#108566]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-kbl3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-kbl5/igt@[email protected]

* igt@kms_vblank@pipe-c-wait-busy:
- shard-snb: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#109278]) +6 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-snb4/igt@[email protected]

* igt@kms_vrr@flip-dpms:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109502])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb3/igt@[email protected]

* igt@perf_pmu@busy-accuracy-50-vcs1:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271]) +159 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl7/igt@[email protected]

* igt@prime_nv_api@i915_nv_import_vs_close:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109291]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb3/igt@prime_nv_api@i915_nv_import_vs_close.html

* igt@prime_vgem@fence-read-hang:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109295])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb5/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][54] ([fdo#108566]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-apl7/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-apl4/igt@[email protected]

* igt@i915_pm_rpm@universal-planes:
- shard-iclb: [INCOMPLETE][56] ([fdo#107713] / [fdo#108840]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb1/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb4/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][58] ([fdo#109349]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb7/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-kbl: [DMESG-WARN][60] ([fdo#108566]) -> [PASS][61] +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-kbl5/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-kbl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
- shard-skl: [FAIL][62] ([fdo#108040]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-skl8/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
- shard-iclb: [FAIL][64] ([fdo#103167]) -> [PASS][65] +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-skl: [FAIL][66] ([fdo#103167]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [INCOMPLETE][68] ([fdo#107713] / [fdo#110042]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb3/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][70] ([fdo#108145]) -> [PASS][71] +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-skl4/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][72] ([fdo#108145] / [fdo#110403]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-skl4/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl6/igt@[email protected]

* {igt@kms_plane_cursor@pipe-b-overlay-size-256}:
- shard-snb: [SKIP][74] ([fdo#109271]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-snb2/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-snb5/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][76] ([fdo#109441]) -> [PASS][77] +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: [FAIL][78] ([fdo#109016]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-kbl2/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-kbl7/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-skl: [SKIP][80] ([fdo#109271]) -> [INCOMPLETE][81] ([fdo#107807])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-skl3/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl1/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- shard-skl: [INCOMPLETE][82] ([fdo#107807]) -> [SKIP][83] ([fdo#109271])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5973/shard-skl8/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/shard-skl3/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109292]: https://bugs.freedesktop.org/show_bug.cgi?id=109292
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109502]: https://bugs.freedesktop.org/show_bug.cgi?id=109502
[fdo#110042]: https://bugs.freedesktop.org/show_bug.cgi?id=110042
[fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#110385]: https://bugs.freedesktop.org/show_bug.cgi?id=110385
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110426]: https://bugs.freedesktop.org/show_bug.cgi?id=110426
[fdo#110499]: https://bugs.freedesktop.org/show_bug.cgi?id=110499
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (10 -> 9)
------------------------------

Missing (1): shard-hsw

Build changes
-------------

* Linux: CI_DRM_5973 -> Patchwork_12856

CI_DRM_5973

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12856/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

PATCH 1/1 drm/i915/gen11: enable support for headerless msgs

In reply to Dongwon Kim

Setting bit5 (headerless msg for preemptable GPGPU context) of SAMPLER_MODE register to enable support for the headless msgs on gen11. None of existing use cases will be affected by this as this change makes both types of message
- headerless and w/ header supported at the same time. It also complies with the new recommendation for the default bit value for the next gen.

v2: rewrote commit message to include more information

---
 drivers/gpu/drm/i915/i915_reg.h  |  1 +
 drivers/gpu/drm/i915/intel_lrc.c | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index b74824f0b5b1..b45042f71c0a 100644
@@ -8862,6 +8862,7 @@ enum {
 #define   GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC	(1 << 7)
 
 #define GEN10_SAMPLER_MODE		_MMIO(0xE18C)
+#define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG	(1 << 5)
 
 /* IVYBRIDGE DPF */
 #define GEN7_L3CDERRST1(slice)		_MMIO(0xB008 + (slice) * 0x200) /* L3CD Error Status 1 */
drivers/gpu/drm/i915/intel_lrc.c +18 -0
index 4e0a351bfbca..07c8fe2a5549 100644
@@ -1807,6 +1807,21 @@ static int gen8_init_common_ring(struct intel_engine_cs *engine)
 	return 0;
 }
 
+static int gen11_init_render_ring(struct intel_engine_cs *engine)
+{
+	struct drm_i915_private *dev_priv = engine->i915;
+	int ret;
+
+	ret = gen8_init_common_ring(engine);
+	if (ret)
+		return ret;
+
+	/* allow headerless messages for pre-emptable GPGPU contexts */
+	I915_WRITE(GEN10_SAMPLER_MODE, _MASKED_BIT_ENABLE(GEN11_SAMPLER_ENABLE_HEADLESS_MSG));
+
+	return 0;
+}
+
 static void execlists_reset_prepare(struct intel_engine_cs *engine)
 {
 	struct intel_engine_execlists * const execlists = &engine->execlists;
@@ -2516,6 +2531,9 @@ int logical_render_ring_init(struct intel_engine_cs *engine)
 		return ret;
 
 	/* Override some for render ring. */
+	if (INTEL_GEN(engine->i915) == 11)
+		engine->init_hw = gen11_init_render_ring;
+
 	engine->init_context = gen8_init_rcs_context;
 	engine->emit_flush = gen8_emit_flush_render;
 	engine->emit_fini_breadcrumb = gen8_emit_fini_breadcrumb_rcs;
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

Quoting Dongwon Kim (2019-04-24 21:38:57)

Quoted 35 lines

Setting bit5 (headerless msg for preemptable GPGPU context) of SAMPLER_MODE register to enable support for the headless msgs on gen11. None of existing use cases will be affected by this as this change makes both types of message
- headerless and w/ header supported at the same time. It also complies with the new recommendation for the default bit value for the next gen.

v2: rewrote commit message to include more information

---
 drivers/gpu/drm/i915/i915_reg.h  |  1 +
 drivers/gpu/drm/i915/intel_lrc.c | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index b74824f0b5b1..b45042f71c0a 100644
@@ -8862,6 +8862,7 @@ enum {
 #define   GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC      (1 << 7)
 
 #define GEN10_SAMPLER_MODE             _MMIO(0xE18C)
+#define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG    (1 << 5)
 
 /* IVYBRIDGE DPF */
 #define GEN7_L3CDERRST1(slice)         _MMIO(0xB008 + (slice) * 0x200) /* L3CD Error Status 1 */
drivers/gpu/drm/i915/intel_lrc.c +1 -0
index 4e0a351bfbca..07c8fe2a5549 100644
@@ -1807,6 +1807,21 @@ static int gen8_init_common_ring(struct intel_engine_cs *engine)
        return 0;
 }
 
+static int gen11_init_render_ring(struct intel_engine_cs *engine)

drivers/gpu/drm/i915/intel_lrc.c static int gen8_init_common_ring(struct intel_engine_cs *engine) · line 1820

Quoted 10 lines
drivers/gpu/drm/i915/intel_lrc.c +10 -0
+{
+       struct drm_i915_private *dev_priv = engine->i915;
+       int ret;
+
+       ret = gen8_init_common_ring(engine);
+       if (ret)
+               return ret;
+
+       /* allow headerless messages for pre-emptable GPGPU contexts */
+       I915_WRITE(GEN10_SAMPLER_MODE, _MASKED_BIT_ENABLE(GEN11_SAMPLER_ENABLE_HEADLESS_MSG));

But you didn't move this to icl_ctx_workarounds_init() where it will be then checked by igt (making sure it remains set after resets and resume).
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

PATCH v3 1/1 drm/i915/gen11: enable support for headerless msgs

In reply to Dongwon Kim

Setting bit5 (headerless msg for preemptable GPGPU context) of SAMPLER_MODE register to enable support for the headless msgs on gen11. None of existing use cases will be affected by this as this change makes both types of message
- headerless and w/ header supported at the same time. It also complies with the new recommendation for the default bit value for the next gen.

v2: rewrote commit message to include more information
v3: setting the bit in icl_ctx_workarounds_init()

---
 drivers/gpu/drm/i915/i915_reg.h          | 1 +
 drivers/gpu/drm/i915/intel_workarounds.c | 4 ++++
 2 files changed, 5 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index b74824f0b5b1..b45042f71c0a 100644
@@ -8862,6 +8862,7 @@ enum {
 #define   GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC	(1 << 7)
 
 #define GEN10_SAMPLER_MODE		_MMIO(0xE18C)
+#define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG	(1 << 5)
 
 /* IVYBRIDGE DPF */
 #define GEN7_L3CDERRST1(slice)		_MMIO(0xB008 + (slice) * 0x200) /* L3CD Error Status 1 */
drivers/gpu/drm/i915/intel_workarounds.c +4 -0
index b3cbed1ee1c9..58ddb60772b3 100644
@@ -575,6 +575,10 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine)
 	WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1,
 			    GEN9_PREEMPT_GPGPU_LEVEL_MASK,
 			    GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
+
+	/* allow headerless messages for preemptable GPGPU context */
+	WA_SET_BIT_MASKED(GEN10_SAMPLER_MODE,
+			  GEN11_SAMPLER_ENABLE_HEADLESS_MSG);
 }
 
 void intel_engine_init_ctx_wa(struct intel_engine_cs *engine)
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

PATCH 1/1 drm/i915/gen11: enable support for headerless msgs

From: Dongwon Kim <[email protected]>

Setting bit5 (headerless msg for preemptable GPGPU context) of SAMPLER_MODE register to enable support for the headless msgs on gen11. None of existing use cases will be affected by this as this change makes both types of message
- headerless and w/ header supported at the same time. It also complies with the new recommendation for the default bit value for the next gen.

v2: rewrote commit message to include more information
v3: setting the bit in icl_ctx_workarounds_init()

---
Merely kicking CI.

---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++++
 drivers/gpu/drm/i915/i915_reg.h             | 1 +
 2 files changed, 5 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +4 -0
index 364696221fd7..e03181aeb451 100644
@@ -575,6 +575,10 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine)
 	WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1,
 			    GEN9_PREEMPT_GPGPU_LEVEL_MASK,
 			    GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
+
+	/* allow headerless messages for preemptable GPGPU context */
+	WA_SET_BIT_MASKED(GEN10_SAMPLER_MODE,
+			  GEN11_SAMPLER_ENABLE_HEADLESS_MSG);
 }
 
 void intel_engine_init_ctx_wa(struct intel_engine_cs *engine)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index b74824f0b5b1..b45042f71c0a 100644
@@ -8862,6 +8862,7 @@ enum {
 #define   GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC	(1 << 7)
 
 #define GEN10_SAMPLER_MODE		_MMIO(0xE18C)
+#define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG	(1 << 5)
 
 /* IVYBRIDGE DPF */
 #define GEN7_L3CDERRST1(slice)		_MMIO(0xB008 + (slice) * 0x200) /* L3CD Error Status 1 */
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#9 lore raw
Quoted 8 lines · Chris Wilson

From: Dongwon Kim <[email protected]>

Setting bit5 (headerless msg for preemptable GPGPU context) of SAMPLER_MODE register to enable support for the headless msgs on gen11. None of existing use cases will be affected by this as this change makes both types of message
- headerless and w/ header supported at the same time. It also complies with the new recommendation for the default bit value for the next gen.

Quoted 4 lines

v2: rewrote commit message to include more information
v3: setting the bit in icl_ctx_workarounds_init()

Quoted 41 lines

---
Merely kicking CI.

---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++++
 drivers/gpu/drm/i915/i915_reg.h             | 1 +
 2 files changed, 5 insertions(+)
drivers/gpu/drm/i915/gt/intel_workarounds.c +4 -0
index 364696221fd7..e03181aeb451 100644
@@ -575,6 +575,10 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine)
 	WA_SET_FIELD_MASKED(GEN8_CS_CHICKEN1,
 			    GEN9_PREEMPT_GPGPU_LEVEL_MASK,
 			    GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
+
+	/* allow headerless messages for preemptable GPGPU context */
+	WA_SET_BIT_MASKED(GEN10_SAMPLER_MODE,
+			  GEN11_SAMPLER_ENABLE_HEADLESS_MSG);
 }
 
 void intel_engine_init_ctx_wa(struct intel_engine_cs *engine)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index b74824f0b5b1..b45042f71c0a 100644
@@ -8862,6 +8862,7 @@ enum {
 #define   GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC	(1 << 7)
 
 #define GEN10_SAMPLER_MODE		_MMIO(0xE18C)
+#define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG	(1 << 5)
 
 /* IVYBRIDGE DPF */
 #define GEN7_L3CDERRST1(slice)		_MMIO(0xB008 + (slice) * 0x200) /* L3CD Error Status 1 */
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

Quoting Mika Kuoppala (2019-05-24 09:03:00)

Quoted 10 lines
Quoted 8 lines · Chris Wilson

From: Dongwon Kim <[email protected]>

Setting bit5 (headerless msg for preemptable GPGPU context) of SAMPLER_MODE register to enable support for the headless msgs on gen11. None of existing use cases will be affected by this as this change makes both types of message
- headerless and w/ header supported at the same time. It also complies with the new recommendation for the default bit value for the next gen.

Quoted 6 lines
Quoted 4 lines

v2: rewrote commit message to include more information
v3: setting the bit in icl_ctx_workarounds_init()

And pushed. Thanks for the patch and review,
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen11: enable support for headerless msgs (rev4)

In reply to Dongwon Kim
== Series Details ==

== Series Details ==

Series: drm/i915/gen11: enable support for headerless msgs (rev4)
URL : https://patchwork.freedesktop.org/series/59839/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
95faef437aa7 drm/i915/gen11: enable support for headerless msgs
-:6: WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'?
#6: 
Setting bit5 (headerless msg for preemptable GPGPU context) of SAMPLER_MODE

-:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #8:
use cases will be affected by this as this change makes both types of message

-:26: WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'? #26: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:579:
+ /* allow headerless messages for preemptable GPGPU context */

total: 0 errors, 3 warnings, 0 checks, 17 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

✗ Fi.CI.BAT: failure for drm/i915/gen11: enable support for headerless msgs (rev4)

In reply to Dongwon Kim
== Series Details ==

== Series Details ==

Series: drm/i915/gen11: enable support for headerless msgs (rev4)
URL : https://patchwork.freedesktop.org/series/59839/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5995 -> Patchwork_12869
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12869 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12869, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59839/revisions/4/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_12869:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_suspend@basic-s3:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-apl-guc/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_12869 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][2] -> [INCOMPLETE][3] ([fdo#107718])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5995/fi-blb-e6850/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][4] -> [DMESG-FAIL][5] ([fdo#110235 ])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5995/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (32 -> 42)
------------------------------

Additional (15): fi-bxt-dsi fi-skl-gvtdvm fi-bsw-n3050 fi-byt-j1900 fi-skl-6770hq fi-apl-guc fi-snb-2520m fi-byt-clapper fi-bxt-j4205 fi-icl-u3 fi-pnv-d510 fi-icl-y fi-byt-n2820 fi-bsw-kefka fi-skl-6700k2
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5995 -> Patchwork_12869

CI_DRM_5995: 290f6892805fb22466c77e373ffd4c8f9e028f7f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4963: 11e10bc575516c56978640fcc697c27f277c660a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12869: 95faef437aa7e6333a2bef8134a5b3eee82f68c1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

95faef437aa7 drm/i915/gen11: enable support for headerless msgs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#13 lore raw

✗ Fi.CI.BAT: failure for drm/i915/gen11: enable support for headerless msgs (rev4)

This doesn't seem to be a valid failure. I just reran the test using trybot and there were no failures.

https://lists.freedesktop.org/archives/intel-gfx-trybot/2019-May/071989.html

Quoted 107 lines · On Thu, Apr 25, 2019 at 07:54:51AM +0000…

Date: Thu, 25 Apr 2019 07:54:50 -0000
From: Patchwork <[email protected]>
To: "Chris Wilson" <[email protected]>
Cc: [email protected]
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen11: enable
support for headerless msgs (rev4)
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

== Series Details ==

Series: drm/i915/gen11: enable support for headerless msgs (rev4)
URL : https://patchwork.freedesktop.org/series/59839/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5995 -> Patchwork_12869
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12869 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12869, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59839/revisions/4/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_12869:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_suspend@basic-s3:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-apl-guc/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_12869 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][2] -> [INCOMPLETE][3] ([fdo#107718])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5995/fi-blb-e6850/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][4] -> [DMESG-FAIL][5] ([fdo#110235 ])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5995/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (32 -> 42)
------------------------------

Additional (15): fi-bxt-dsi fi-skl-gvtdvm fi-bsw-n3050 fi-byt-j1900 fi-skl-6770hq fi-apl-guc fi-snb-2520m fi-byt-clapper fi-bxt-j4205 fi-icl-u3 fi-pnv-d510 fi-icl-y fi-byt-n2820 fi-bsw-kefka fi-skl-6700k2
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5995 -> Patchwork_12869

CI_DRM_5995: 290f6892805fb22466c77e373ffd4c8f9e028f7f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4963: 11e10bc575516c56978640fcc697c27f277c660a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12869: 95faef437aa7e6333a2bef8134a5b3eee82f68c1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

95faef437aa7 drm/i915/gen11: enable support for headerless msgs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/

------------------------------

Subject: Digest Footer

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 4 lines

------------------------------

End of Intel-gfx Digest, Vol 135, Issue 507
*******************************************

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw

Re: ✗ Fi.CI.BAT: failure for drm/i915/gen11: enable support for headerless msgs (rev4)

Quoted 4 lines · Dongwon

This doesn't seem to be a valid failure. I just reran the test using trybot and there were no failures.

https://lists.freedesktop.org/archives/intel-gfx-trybot/2019-May/071989.html

I reported this bug two days ago and added it to cibuglog, this is why you don't see it anymore.

This is why asking me to re-report runs is better than forcing a re-run, since it does not take valuable time... but I also don't want to be blocking you :D

Cheers,
Martin

Quoted 109 lines · On Thu, Apr 25, 2019 at 07:54:51AM +0000…
Quoted 107 lines

Date: Thu, 25 Apr 2019 07:54:50 -0000
From: Patchwork <[email protected]>
To: "Chris Wilson" <[email protected]>
Cc: [email protected]
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen11: enable
support for headerless msgs (rev4)
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

== Series Details ==

Series: drm/i915/gen11: enable support for headerless msgs (rev4)
URL : https://patchwork.freedesktop.org/series/59839/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5995 -> Patchwork_12869
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12869 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12869, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59839/revisions/4/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_12869:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_suspend@basic-s3:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-apl-guc/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_12869 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][2] -> [INCOMPLETE][3] ([fdo#107718])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5995/fi-blb-e6850/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][4] -> [DMESG-FAIL][5] ([fdo#110235 ])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5995/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (32 -> 42)
------------------------------

Additional (15): fi-bxt-dsi fi-skl-gvtdvm fi-bsw-n3050 fi-byt-j1900 fi-skl-6770hq fi-apl-guc fi-snb-2520m fi-byt-clapper fi-bxt-j4205 fi-icl-u3 fi-pnv-d510 fi-icl-y fi-byt-n2820 fi-bsw-kefka fi-skl-6700k2
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5995 -> Patchwork_12869

CI_DRM_5995: 290f6892805fb22466c77e373ffd4c8f9e028f7f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4963: 11e10bc575516c56978640fcc697c27f277c660a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12869: 95faef437aa7e6333a2bef8134a5b3eee82f68c1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

95faef437aa7 drm/i915/gen11: enable support for headerless msgs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/

------------------------------

Subject: Digest Footer

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 5 lines
Quoted 4 lines

------------------------------

End of Intel-gfx Digest, Vol 135, Issue 507
*******************************************

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw

Re: ✗ Fi.CI.BAT: failure for drm/i915/gen11: enable support for headerless msgs (rev4)

Chris,

This patch apparently passed the regression test. Can you please help this move forward to the merging process?

Quoted 9 lines · Martin
Quoted 4 lines · Dongwon

This doesn't seem to be a valid failure. I just reran the test using trybot and there were no failures.

https://lists.freedesktop.org/archives/intel-gfx-trybot/2019-May/071989.html

I reported this bug two days ago and added it to cibuglog, this is why you don't see it anymore.

Quoted 122 lines

This is why asking me to re-report runs is better than forcing a re-run, since it does not take valuable time... but I also don't want to be blocking you :D

Cheers,
Martin

Quoted 114 lines · On Thu, Apr 25, 2019 at 07:54:51AM +0000…
Quoted 111 lines

Date: Thu, 25 Apr 2019 07:54:50 -0000
From: Patchwork <[email protected]>
To: "Chris Wilson" <[email protected]>
Cc: [email protected]
Subject: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen11: enable
support for headerless msgs (rev4)
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

== Series Details ==

Series: drm/i915/gen11: enable support for headerless msgs (rev4)
URL : https://patchwork.freedesktop.org/series/59839/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5995 -> Patchwork_12869
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12869 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12869, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59839/revisions/4/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_12869:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_suspend@basic-s3:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-apl-guc/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_12869 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][2] -> [INCOMPLETE][3] ([fdo#107718])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5995/fi-blb-e6850/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][4] -> [DMESG-FAIL][5] ([fdo#110235 ])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5995/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (32 -> 42)
------------------------------

Additional (15): fi-bxt-dsi fi-skl-gvtdvm fi-bsw-n3050 fi-byt-j1900 fi-skl-6770hq fi-apl-guc fi-snb-2520m fi-byt-clapper fi-bxt-j4205 fi-icl-u3 fi-pnv-d510 fi-icl-y fi-byt-n2820 fi-bsw-kefka fi-skl-6700k2
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5995 -> Patchwork_12869

CI_DRM_5995: 290f6892805fb22466c77e373ffd4c8f9e028f7f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4963: 11e10bc575516c56978640fcc697c27f277c660a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12869: 95faef437aa7e6333a2bef8134a5b3eee82f68c1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

95faef437aa7 drm/i915/gen11: enable support for headerless msgs

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12869/

------------------------------

Subject: Digest Footer

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

------------------------------

End of Intel-gfx Digest, Vol 135, Issue 507
*******************************************

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx