Skip to contentSkip to conversation

misc: fs_loader: Add support for initializing block device

PATCH New tien.fong.chee at intel.com 4 participants 4 messages Jan 31, 2019 – Apr 24, 2019 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 misc: fs_loader: Add support for initializing block device

From: Tien Fong Chee <[email protected]>

Firmware loader would encounter problem if the block device is accessed before initializing it. This patch would adding the support of probing block device and initializing block before the block device is accessed by firmware loader.

---

changes in v4
- Removed header mmc.h
- Dropped extra blank line

changes in v3:
- Initializing block device through probing the blk device

changes in v2:
- Initializing MMC through probing the blk device

---
 drivers/misc/fs_loader.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
drivers/misc/fs_loader.c +23 -0
index 57a14a3..a2e3763 100644
@@ -252,6 +252,29 @@ static int fs_loader_ofdata_to_platdata(struct udevice *dev)
 
 static int fs_loader_probe(struct udevice *dev)
 {
+#if CONFIG_IS_ENABLED(DM) && CONFIG_IS_ENABLED(BLK)
+	int ret;
+	struct device_platdata *plat = dev->platdata;
+
+	if (plat->phandlepart.phandle) {
+		ofnode node = ofnode_get_by_phandle(plat->phandlepart.phandle);
+		struct udevice *parent_dev = NULL;
+
+		ret = device_get_global_by_ofnode(node, &parent_dev);
+		if (!ret) {
+			struct udevice *dev;
+
+			ret = blk_get_from_parent(parent_dev, &dev);
+			if (ret) {
+				debug("fs_loader: No block device: %d\n",
+					ret);
+
+				return ret;
+			}
+		}
+	}
+#endif
+
 	return 0;
 };
 
Signature · 1 line
2.2.0
#1 lore raw

PATCH v4 1/1 misc: fs_loader: Add support for initializing block device

Quoted 16 lines · On Thu, 31 Jan 2019 at 04:34, <[email protected]> wrote:

From: Tien Fong Chee <[email protected]>

Firmware loader would encounter problem if the block device is accessed before initializing it. This patch would adding the support of probing block device and initializing block before the block device is accessed by firmware loader.

---

changes in v4
- Removed header mmc.h
- Dropped extra blank line

Quoted 8 lines

changes in v3:
- Initializing block device through probing the blk device

changes in v2:
- Initializing MMC through probing the blk device

---
 drivers/misc/fs_loader.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

(I'm not sure you need to check for DM being enabled, but OK)

#2 lore raw

PATCH v4 1/1 misc: fs_loader: Add support for initializing block device

On Fri, 2019-02-01 at 23:06 -0700, Simon Glass wrote:

Quoted 16 lines · On Thu, 31 Jan 2019 at 04:34, <tien.fong.chee at…

From: Tien Fong Chee <tien.fong.chee at intel.com<mailto:[email protected]>>

Firmware loader would encounter problem if the block device is accessed before initializing it. This patch would adding the support of probing block device and initializing block before the block device is accessed by firmware loader.

Signed-off-by Tien Fong Chee <tien.fong.chee at intel.com<mailto:[email protected]>>

---

changes in v4
- Removed header mmc.h
- Dropped extra blank line

Quoted 8 lines

changes in v3:
- Initializing block device through probing the blk device

changes in v2:
- Initializing MMC through probing the blk device

---
 drivers/misc/fs_loader.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
Reviewed-by Simon Glass <sjg at chromium.org<mailto:[email protected]>>

(I'm not sure you need to check for DM being enabled, but OK) Thanks. No strong opinion on this :) .

#3 lore raw

PATCH v4 1/1 misc: fs_loader: Add support for initializing block device

In reply to tien.fong.chee at intel.com
Quoted 10 lines · tien.fong.chee at intel.com

From: Tien Fong Chee <[email protected]>

Firmware loader would encounter problem if the block device is accessed before initializing it. This patch would adding the support of probing block device and initializing block before the block device is accessed by firmware loader.

Reviewed-by Simon Glass <sjg at chromium.org<mailto:[email protected]>>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/c07ffdf4/attachment.sig>