Add target to generate initial environment
PATCH 1/34 Add target to generate initial environment
The initial environment is linked to the u-boot binary. Modifying the environment from User Space with the env tools requires that the tools are always built together with the bootloader to be sure that they contain the initial environment in case no environment is stored into persistent storage or when a board boots with just the default environment. This makes difficult for distros to provide a general package to access the environment. A simpler way is if the tools are generic for all boards and a configuration file is given to provide the initial environment.
The patch just generates the initial environment by extracting it from the compiled object. This file can then be used for tools in user space to initialize the environment.
--- Makefile | 7 +++++++ 1 file changed, 7 insertions(+)
Makefile +7 -0
@@ -1932,6 +1932,13 @@ endif $(build)=$(build-dir) $(@:.ko=.o) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost +quiet_cmd_genenv = GENENV $@ +cmd_genenv = $(OBJCOPY) --dump-section .rodata.default_environment=$@ env/common.o; \ + sed --in-place -e 's/\x00/\x0A/g' $@ + +u-boot-initial-env: u-boot.bin + $(call if_changed,genenv) + # Consistency checks # ---------------------------------------------------------------------------
Signature · 1 line
2.17.1
PATCH 1/34 Add target to generate initial environment
Quoted 25 lines · Stefano Babic
The initial environment is linked to the u-boot binary. Modifying the environment from User Space with the env tools requires that the tools are always built together with the bootloader to be sure that they contain the initial environment in case no environment is stored into persistent storage or when a board boots with just the default environment. This makes difficult for distros to provide a general package to access the environment. A simpler way is if the tools are generic for all boards and a configuration file is given to provide the initial environment.
The patch just generates the initial environment by extracting it from the compiled object. This file can then be used for tools in user space to initialize the environment.
Signed-off-by Stefano Babic <[email protected]>--- Makefile | 7 +++++++ 1 file changed, 7 insertions(+)Makefile +0
-0
Makefile endif · line 1938
Quoted 7 lines
Makefile +4
-0@@ -1932,6 +1932,13 @@ endif $(build)=$(build-dir) $(@:.ko=.o) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost +quiet_cmd_genenv = GENENV $@ +cmd_genenv = $(OBJCOPY) --dump-section .rodata.default_environment=$@ env/common.o; \ + sed --in-place -e 's/\x00/\x0A/g' $@ +
Really an observation rather than an objection - there are boards which have newlines embedded in their compiled in environments - ge_bx50v3 and mx53ppd (the failbootcmd variable) are the two I know of.
Quoted 9 lines
Makefile +3
-1+u-boot-initial-env: u-boot.bin + $(call if_changed,genenv) + # Consistency checks # --------------------------------------------------------------------------- --2.17.1
Quoted 4 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
--
Alex Kiernan
PATCH 1/34 Add target to generate initial environment
Hi Alex,
Quoted 29 lines · Alex Kiernan
Quoted 28 lines · Stefano Babic
The initial environment is linked to the u-boot binary. Modifying the environment from User Space with the env tools requires that the tools are always built together with the bootloader to be sure that they contain the initial environment in case no environment is stored into persistent storage or when a board boots with just the default environment. This makes difficult for distros to provide a general package to access the environment. A simpler way is if the tools are generic for all boards and a configuration file is given to provide the initial environment.
The patch just generates the initial environment by extracting it from the compiled object. This file can then be used for tools in user space to initialize the environment.
Signed-off-by Stefano Babic <[email protected]>--- Makefile | 7 +++++++ 1 file changed, 7 insertions(+)Makefile +0
-0@@ -1932,6 +1932,13 @@ endif $(build)=$(build-dir) $(@:.ko=.o) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost
Quoted 9 lines
Makefile endif · line 1938
Quoted 4 lines
Makefile +4
-0+quiet_cmd_genenv = GENENV $@ +cmd_genenv = $(OBJCOPY) --dump-section .rodata.default_environment=$@ env/common.o; \ + sed --in-place -e 's/\x00/\x0A/g' $@ +Really an observation rather than an objection - there are boards which have newlines embedded in their compiled in environments -
ge_bx50v3and mx53ppd (the failbootcmd variable) are the two I know of.
Right - but I guess that this could be better handled by external scripts else here in U-Boot. The target simply dumps the compiled in environment to be available t oexternal tools. For your use cases, it is required a more sophisticated logic that checks for newlines if they are surrounded by ".
Regards,
Stefano
Quoted 21 lines
Quoted 11 lines
Makefile +3
-1+u-boot-initial-env: u-boot.bin + $(call if_changed,genenv) + # Consistency checks # --------------------------------------------------------------------------- --2.17.1
Quoted 4 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot--
Alex Kiernan
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/34 Add target to generate initial environment
In reply to Stefano BabicQuoted 10 lines · Stefano Babic
The initial environment is linked to the u-boot binary. Modifying the environment from User Space with the env tools requires that the tools are always built together with the bootloader to be sure that they contain the initial environment in case no environment is stored into persistent storage or when a board boots with just the default environment. This makes difficult for distros to provide a general package to access the environment. A simpler way is if the tools are generic for all boards and a configuration file is given to provide the initial environment.
Quoted 5 lines
The patch just generates the initial environment by extracting it from the compiled object. This file can then be used for tools in user space to initialize the environment.
Signed-off-by Stefano Babic <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/ef8b92c8/attachment.sig>