arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay
Subsystems (3)
Sasha Levin
maintainerPATCH 1/66 arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay
From: "Leonidas P. Papadakos" <[email protected]>
[ Upstream commit 924726888f660b2a86382a5dd051ec9ca1b18190 ]
The rk3328-roc-cc board exhibits tx stability issues with large packets, as does the rock64 board, which was fixed with this patch
https://patchwork.kernel.org/patch/10178969/
A similar patch was merged for the rk3328-roc-cc here
https://patchwork.kernel.org/patch/10804863/
but it doesn't include the tx/rx_delay tweaks, and I find that they help with an issue where large transfers would bring the ethernet link down, causing a link reset regularly.
--- arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +2 -2
@@ -107,8 +107,8 @@ snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; snps,reset-active-low; snps,reset-delays-us = <0 10000 50000>; - tx_delay = <0x25>; - rx_delay = <0x11>; + tx_delay = <0x24>; + rx_delay = <0x18>; status = "okay"; };
Signature · 1 line
2.19.1
Sasha Levin
maintainerPATCH 2/66 HID: Increase maximum report size allowed by hid_field_extract()
From: Kai-Heng Feng <[email protected]>
[ Upstream commit 94a9992f7dbdfb28976b565af220e0c4a117144a ]
Commit 71f6fa90a353 ("HID: increase maximum global item tag report size to 256") increases the max report size from 128 to 256.
We also need to update the report size in hid_field_extract() otherwise it complains and truncates now valid report size:
[ 406.165461] hid-sensor-hub 001F:8086:22D8.0002: hid_field_extract() called with n (192) > 32! (kworker/5:1)
--- drivers/hid/hid-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hid/hid-core.c +3 -3
@@ -1301,10 +1301,10 @@ static u32 __extract(u8 *report, unsigned offset, int n)u32 hid_field_extract (const struct hid_device *hid,u8 *report,unsigned offset,unsigned n) { -if (n >32 ) { -hid_warn (hid,"hid_field_extract() called with n (%d) > 32! (%s)\n" , +if (n >256 ) { +hid_warn (hid,"hid_field_extract() called with n (%d) > 256! (%s)\n" , n, current->comm); - n =32 ; + n =256 ; }return __extract (report, offset, n);
Signature · 1 line
2.19.1
Sasha Levin
maintainerPATCH 3/66 HID: logitech: check the return value of create_singlethread_workqueue
In reply to Sasha LevinFrom: Kangjie Lu <[email protected]>
[ Upstream commit 6c44b15e1c9076d925d5236ddadf1318b0a25ce2 ]
create_singlethread_workqueue may fail and return NULL. The fix checks if it is NULL to avoid NULL pointer dereference. Also, the fix moves the call of create_singlethread_workqueue earlier to avoid resource-release issues.
--- drivers/hid/hid-logitech-hidpp.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/hid/hid-logitech-hidpp.c +7 -1
@@ -2111,6 +2111,13 @@ static int hidpp_ff_init(struct hidpp_device *hidpp, u8 feature_index)kfree (data);return -ENOMEM ; } + data->wq =create_singlethread_workqueue ("hidpp-ff-sendqueue" ); +if (!data->wq) { +kfree (data->effect_ids); +kfree (data); +return -ENOMEM ; + } + data->hidpp = hidpp; data->feature_index = feature_index; data->version = version;
@@ -2155,7 +2162,6 @@ static int hidpp_ff_init(struct hidpp_device *hidpp, u8 feature_index)/* ignore boost value at response.fap.params[2] */ /* init the hardware command queue */ - data->wq =create_singlethread_workqueue ("hidpp-ff-sendqueue" );atomic_set (&data->workqueue_size,0 );/* initialize with zero autocenter to get wheel in usable state */
Signature · 1 line
2.19.1
Sasha Levin
maintainerSorry about the noise, git-send-email/msmtp barfed on a name with a comma it tried to add automatically to recipients. I'll fix it up and resend.