Skip to contentSkip to conversation

drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?

PATCH New Dan Carpenter 1 participant 1 message Apr 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 17/24 drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?

tree:   git://people.freedesktop.org/~airlied/linux.git drm-legacy-cleanup
head:   ee22f76306a68359c33809f8895eff603e71584b
commit: 058ca50ce3f1d40dac4d918a91684b0af4a0c468 [17/24] drm/legacy: move lock cleanup for master into lock file (v2)

If you fix the issue, kindly add following tag

smatch warnings:
drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?

git remote add drm git://people.freedesktop.org/~airlied/linux.git
git remote update drm
git checkout 058ca50ce3f1d40dac4d918a91684b0af4a0c468 vim +359 drivers/gpu/drm/drm_lock.c

058ca50c Dave Airlie 2019-04-23  350  
058ca50c Dave Airlie 2019-04-23  351  void drm_legacy_lock_master_cleanup(struct drm_device *dev, struct drm_master *master)
058ca50c Dave Airlie 2019-04-23  352  {
058ca50c Dave Airlie 2019-04-23  353  	if (!drm_core_check_feature(dev, DRIVER_LEGACY))
058ca50c Dave Airlie 2019-04-23  354  		return;
058ca50c Dave Airlie 2019-04-23  355  
058ca50c Dave Airlie 2019-04-23  356  	/*
058ca50c Dave Airlie 2019-04-23  357  	 * Since the master is disappearing, so is the
058ca50c Dave Airlie 2019-04-23  358  	 * possibility to lock.
058ca50c Dave Airlie 2019-04-23 @359  	 */	mutex_lock(&dev->struct_mutex);
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This should be moved to the next line. At first I thought it was part of the comment.