thermal/drivers/cpu_cooling: Remove pointless test in power2state()
PATCH 1/1 thermal/drivers/cpu_cooling: Remove pointless test in power2state()
When the static power computation was removed, the test with the power being negative was not removed. However, the substraction which was responsible of the negative value was removed and the variable is now an u32. A double reason to remove the test which does not make sense.
Fixes 84fe2cab48590 ("cpu_cooling: Drop static-power related stuff")
Cc Viresh Kumar <[email protected]>
Signed-off-by Daniel Lezcano <[email protected]>
--- drivers/thermal/cpu_cooling.c | 1 - 1 file changed, 1 deletion(-)
drivers/thermal/cpu_cooling.c +0 -1
@@ -541,7 +541,6 @@ static int cpufreq_power2state(struct thermal_cooling_device *cdev,struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata;struct cpufreq_policy *policy = cpufreq_cdev->policy; - power = power >0 ? power :0 ; last_load = cpufreq_cdev->last_load ?:1 ; normalised_power = (power *100 ) / last_load; target_freq =cpu_power_to_freq (cpufreq_cdev, normalised_power);
Signature · 1 line
2.17.1
Quoted 17 lines · Daniel Lezcano
When the static power computation was removed, the test with the power being negative was not removed. However, the substraction which was responsible of the negative value was removed and the variable is now an u32. A double reason to remove the test which does not make sense.
Fixes 84fe2cab48590 ("cpu_cooling: Drop static-power related stuff")Cc Viresh Kumar <[email protected]>Signed-off-by Daniel Lezcano <[email protected]>--- drivers/thermal/cpu_cooling.c | 1 - 1 file changed, 1 deletion(-)drivers/thermal/cpu_cooling.c +0
-0
drivers/thermal/cpu_cooling.c static int cpufreq_power2state(struct thermal_cooling_device *cdev, · line 546
Quoted 7 lines
drivers/thermal/cpu_cooling.c +0
-1@@ -541,7 +541,6 @@ static int cpufreq_power2state(struct thermal_cooling_device *cdev,struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata;struct cpufreq_policy *policy = cpufreq_cdev->policy; - power = power >0 ? power :0 ; last_load = cpufreq_cdev->last_load ?:1 ; normalised_power = (power *100 ) / last_load; target_freq =cpu_power_to_freq (cpufreq_cdev, normalised_power);
Acked-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh