tipc: remove rcu_read_unlock() left in tipc_udp_recv()
Subsystems (3)
PATCH 1/1 tipc: remove rcu_read_unlock() left in tipc_udp_recv()
I forgot to remove one rcu_read_unlock() before a return statement.
Joy of mixing goto and return styles in a function :)
Fixes 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs")
Signed-off-by Eric Dumazet <[email protected]>
Reported-by kbuild test robot <[email protected]>
--- net/tipc/udp_media.c | 1 - 1 file changed, 1 deletion(-)
net/tipc/udp_media.c +0 -1
@@ -360,7 +360,6 @@ static int tipc_udp_recv(struct sock *sk, struct sk_buff *skb)if (b &&test_bit (0 , &b->up)) {tipc_rcv (sock_net (sk), skb, b); -rcu_read_unlock ();return 0 ; }
Signature · 1 line
2.21.0.593.g511ec345e18-goog
From: Eric Dumazet <[email protected]>
Date: Wed, 24 Apr 2019 17:21:40 -0700
Quoted 7 lines
I forgot to remove one
rcu_read_unlock()before a return statement.Joy of mixing goto and return styles in a function :)
Fixes 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs")Signed-off-by Eric Dumazet <[email protected]>Reported-by kbuild test robot <[email protected]>
Applied, thanks Eric.