Skip to contentSkip to conversation

tipc: remove rcu_read_unlock() left in tipc_udp_recv()

PATCH Applied Eric Dumazet 2 participants 2 messages Apr 25, 2019 – Apr 26, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tipc: remove rcu_read_unlock() left in tipc_udp_recv()

I forgot to remove one rcu_read_unlock() before a return statement.

Joy of mixing goto and return styles in a function :)

Fixes 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs")
---
 net/tipc/udp_media.c | 1 -
 1 file changed, 1 deletion(-)
net/tipc/udp_media.c +0 -1
index 7413cbc9b638af492d6a592df957a3229fa6a3fa..0884a1b8ad12595cabca71229789c55a14f24659 100644
@@ -360,7 +360,6 @@ static int tipc_udp_recv(struct sock *sk, struct sk_buff *skb)
 
 	if (b && test_bit(0, &b->up)) {
 		tipc_rcv(sock_net(sk), skb, b);
-		rcu_read_unlock();
 		return 0;
 	}
 
Signature · 1 line
2.21.0.593.g511ec345e18-goog