misc: xfs_fsop_geom_t -> struct xfs_fsop_geom
PATCH 1/1 misc: xfs_fsop_geom_t -> struct xfs_fsop_geom
From: Darrick J. Wong <[email protected]>
Remove the typedef usage for the xfs geometry structure.
--- dmapi/src/suite1/cmd/make_rt_sparse.c | 2 +- ltp/fsstress.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
dmapi/src/suite1/cmd/make_rt_sparse.c +1 -1
@@ -36,7 +36,7 @@ main(int argc, char **argv) { - xfs_fsop_geom_t geom; + struct xfs_fsop_geom geom;struct fsxattr fsx;struct dioattr dio;char *pathname;
ltp/fsstress.c +1 -1
@@ -294,7 +294,7 @@ int errrange;int errtag;opty_t *freq_table;int freq_table_size; -xfs_fsop_geom_t geom; +struct xfs_fsop_geom geom;char *homedir;int *ilist;int ilistlen;
Quoted 5 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Remove the typedef usage for the xfs geometry structure.
Signed-off-by Darrick J. Wong <[email protected]>
I guess this is due to patch "xfs: bump XFS_IOC_FSGEOMETRY to v5 structures" which removes the xfs_fsop_geom_t typedef? And I'm wondering if xfs/122 needs update too? as xfs/122.out contains an xfs_fsop_geom_t entry as well.
Thanks,
Eryu
Quoted 31 lines
--- dmapi/src/suite1/cmd/make_rt_sparse.c | 2 +- ltp/fsstress.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)dmapi/src/suite1/cmd/make_rt_sparse.c +1
-1@@ -36,7 +36,7 @@ main(int argc, char **argv) { - xfs_fsop_geom_t geom; + struct xfs_fsop_geom geom;struct fsxattr fsx;struct dioattr dio;char *pathname;ltp/fsstress.c +1
-1@@ -294,7 +294,7 @@ int errrange;int errtag;opty_t *freq_table;int freq_table_size; -xfs_fsop_geom_t geom; +struct xfs_fsop_geom geom;char *homedir;int *ilist;int ilistlen;
Quoted 11 lines · Eryu Guan
Quoted 5 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Remove the typedef usage for the xfs geometry structure.
Signed-off-by Darrick J. Wong <[email protected]>I guess this is due to patch "xfs: bump
XFS_IOC_FSGEOMETRYto v5 structures" which removes thexfs_fsop_geom_ttypedef? And I'm wondering if xfs/122 needs update too? as xfs/122.out contains anxfs_fsop_geom_tentry as well.
xfs/122 does need an update for the new 5.2 ioctls, so yes, I'll send that one along once they've landed upstream.
In the meantime, the xfs_fsop_geom_t -> struct xfs_fsop_geom conversion ought to be applied since the struct FOO approach has always worked.
--D
Quoted 34 lines
Thanks,
EryuQuoted 31 lines
--- dmapi/src/suite1/cmd/make_rt_sparse.c | 2 +- ltp/fsstress.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)dmapi/src/suite1/cmd/make_rt_sparse.c +1
-1@@ -36,7 +36,7 @@ main(int argc, char **argv) { - xfs_fsop_geom_t geom; + struct xfs_fsop_geom geom;struct fsxattr fsx;struct dioattr dio;char *pathname;ltp/fsstress.c +1
-1@@ -294,7 +294,7 @@ int errrange;int errtag;opty_t *freq_table;int freq_table_size; -xfs_fsop_geom_t geom; +struct xfs_fsop_geom geom;char *homedir;int *ilist;int ilistlen;
Quoted 13 lines · Darrick J. Wong
Quoted 11 lines · Eryu Guan
Quoted 5 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Remove the typedef usage for the xfs geometry structure.
Signed-off-by Darrick J. Wong <[email protected]>I guess this is due to patch "xfs: bump
XFS_IOC_FSGEOMETRYto v5 structures" which removes thexfs_fsop_geom_ttypedef? And I'm wondering if xfs/122 needs update too? as xfs/122.out contains anxfs_fsop_geom_tentry as well.
Quoted 5 lines
xfs/122 does need an update for the new 5.2 ioctls, so yes, I'll send that one along once they've landed upstream.
In the meantime, the
xfs_fsop_geom_t-> structxfs_fsop_geomconversion ought to be applied since the struct FOO approach has always worked.
Ok, thanks!
Eryu