nvmet-file: clamp-down file namespace lba_shift
Subsystems (2)
Sagi Grimberg
maintainerPATCH v2 1/1 nvmet-file: clamp-down file namespace lba_shift
When the backing file is a tempfile for example, the inode i_blkbits can be 1M in size which causes problems for hosts to support as the disk block size. Instead, expose the minimum between i_blkbits and 12 (4K sector size).
---
Changes from v1:
- expose block size 4096 instead of PAGE_SIZE
drivers/nvme/target/io-cmd-file.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/nvme/target/io-cmd-file.c +6 -1
@@ -49,7 +49,12 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns) goto err; ns->size = stat.size; - ns->blksize_shift =file_inode (ns->file)->i_blkbits; +/* +* inode i_blkbits can be greater than the universally accepted upper +* bound so make sure we export we export a sane namespace lba_shift. +*/ + ns->blksize_shift =min_t (u8, +file_inode (ns->file)->i_blkbits,12 ); ns->bvec_cache = kmem_cache_create("nvmet-bvec", NVMET_MAX_MPOOL_BVEC * sizeof(struct bio_vec),
Signature · 1 line
2.17.1
PATCH v2 1/1 nvmet-file: clamp-down file namespace lba_shift
Quoted 18 lines · Sagi Grimberg
When the backing file is a tempfile for example, the inode
i_blkbitscan be 1M in size which causes problems for hosts to support as the disk block size. Instead, expose the minimum betweeni_blkbitsand 12 (4K sector size).Signed-off-by Sagi Grimberg <sagi at grimberg.me>---
Changes from v1:
- expose block size 4096 instead ofPAGE_SIZEdrivers/nvme/target/io-cmd-file.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/nvme/target/io-cmd-file.c +0
-0
drivers/nvme/target/io-cmd-file.c int nvmet_file_ns_enable(struct nvmet_ns *ns) · line 54
Quoted 7 lines
drivers/nvme/target/io-cmd-file.c +3
-1@@ -49,7 +49,12 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns) goto err; ns->size = stat.size; - ns->blksize_shift =file_inode (ns->file)->i_blkbits; +/* +* inode i_blkbits can be greater than the universally accepted upper +* bound so make sure we export we export a sane namespace lba_shift.
'we export' is duplicated here. :)
Thanks,
Quoted 7 lines
drivers/nvme/target/io-cmd-file.c +3
-0+*/ + ns->blksize_shift =min_t (u8, +file_inode (ns->file)->i_blkbits,12 ); ns->bvec_cache = kmem_cache_create("nvmet-bvec", NVMET_MAX_MPOOL_BVEC * sizeof(struct bio_vec),
PATCH v2 1/1 nvmet-file: clamp-down file namespace lba_shift
In reply to Sagi GrimbergLooks good from the duplicate "we export".
Quoted 32 lines · Sagi Grimberg
When the backing file is a tempfile for example, the inode
i_blkbitscan be 1M in size which causes problems for hosts to support as the disk block size. Instead, expose the minimum betweeni_blkbitsand 12 (4K sector size).Signed-off-by Sagi Grimberg <sagi at grimberg.me>---
Changes from v1:
- expose block size 4096 instead ofPAGE_SIZEdrivers/nvme/target/io-cmd-file.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/nvme/target/io-cmd-file.c +6
-1@@ -49,7 +49,12 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns) goto err; ns->size = stat.size; - ns->blksize_shift =file_inode (ns->file)->i_blkbits; +/* +* inode i_blkbits can be greater than the universally accepted upper +* bound so make sure we export we export a sane namespace lba_shift. +*/ + ns->blksize_shift =min_t (u8, +file_inode (ns->file)->i_blkbits,12 ); ns->bvec_cache = kmem_cache_create("nvmet-bvec", NVMET_MAX_MPOOL_BVEC * sizeof(struct bio_vec),
PATCH v2 1/1 nvmet-file: clamp-down file namespace lba_shift
In reply to Sagi GrimbergThanks,
applied to nvme-5.2.