Skip to contentSkip to conversation

nvmet-file: clamp-down file namespace lba_shift

PATCH New Sagi Grimberg 4 participants 4 messages Apr 24, 2019 – Apr 25, 2019

Subsystems (2)
lore
Share & tools
lore

Sagi Grimberg

author maintainer
#0 lore raw

PATCH v2 1/1 nvmet-file: clamp-down file namespace lba_shift

When the backing file is a tempfile for example, the inode i_blkbits can be 1M in size which causes problems for hosts to support as the disk block size. Instead, expose the minimum between i_blkbits and 12 (4K sector size).

Signed-off-by Sagi Grimberg <sagi at grimberg.me>

---
Changes from v1:
- expose block size 4096 instead of PAGE_SIZE

 drivers/nvme/target/io-cmd-file.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/nvme/target/io-cmd-file.c +6 -1
index bc6ebb51b0bf..66013d8ad94b 100644
@@ -49,7 +49,12 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns)
 		goto err;
 
 	ns->size = stat.size;
-	ns->blksize_shift = file_inode(ns->file)->i_blkbits;
+	/*
+	 * inode i_blkbits can be greater than the universally accepted upper
+	 * bound so make sure we export we export a sane namespace lba_shift.
+	 */
+	ns->blksize_shift = min_t(u8,
+			file_inode(ns->file)->i_blkbits, 12);
 
 	ns->bvec_cache = kmem_cache_create("nvmet-bvec",
 			NVMET_MAX_MPOOL_BVEC * sizeof(struct bio_vec),
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 nvmet-file: clamp-down file namespace lba_shift

Quoted 18 lines · Sagi Grimberg

When the backing file is a tempfile for example, the inode i_blkbits can be 1M in size which causes problems for hosts to support as the disk block size. Instead, expose the minimum between i_blkbits and 12 (4K sector size).

Signed-off-by Sagi Grimberg <sagi at grimberg.me>

---
Changes from v1:
- expose block size 4096 instead of PAGE_SIZE

  drivers/nvme/target/io-cmd-file.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
drivers/nvme/target/io-cmd-file.c +0 -0
index bc6ebb51b0bf..66013d8ad94b 100644

drivers/nvme/target/io-cmd-file.c int nvmet_file_ns_enable(struct nvmet_ns *ns) · line 54

Quoted 7 lines
drivers/nvme/target/io-cmd-file.c +3 -1
@@ -49,7 +49,12 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns)
  		goto err;
 
  	ns->size = stat.size;
-	ns->blksize_shift = file_inode(ns->file)->i_blkbits;
+	/*
+	 * inode i_blkbits can be greater than the universally accepted upper
+	 * bound so make sure we export we export a sane namespace lba_shift.

'we export' is duplicated here. :)
Thanks,

Quoted 7 lines
drivers/nvme/target/io-cmd-file.c +3 -0
+	 */
+	ns->blksize_shift = min_t(u8,
+			file_inode(ns->file)->i_blkbits, 12);
 
  	ns->bvec_cache = kmem_cache_create("nvmet-bvec",
  			NVMET_MAX_MPOOL_BVEC * sizeof(struct bio_vec),
#2 lore raw

PATCH v2 1/1 nvmet-file: clamp-down file namespace lba_shift

In reply to Sagi Grimberg

Looks good from the duplicate "we export".

Reviewed-by - Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
Quoted 32 lines · Sagi Grimberg

When the backing file is a tempfile for example, the inode i_blkbits can be 1M in size which causes problems for hosts to support as the disk block size. Instead, expose the minimum between i_blkbits and 12 (4K sector size).

Signed-off-by Sagi Grimberg <sagi at grimberg.me>

---
Changes from v1:
- expose block size 4096 instead of PAGE_SIZE

  drivers/nvme/target/io-cmd-file.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
drivers/nvme/target/io-cmd-file.c +6 -1
index bc6ebb51b0bf..66013d8ad94b 100644
@@ -49,7 +49,12 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns)
  		goto err;
 
  	ns->size = stat.size;
-	ns->blksize_shift = file_inode(ns->file)->i_blkbits;
+	/*
+	 * inode i_blkbits can be greater than the universally accepted upper
+	 * bound so make sure we export we export a sane namespace lba_shift.
+	 */
+	ns->blksize_shift = min_t(u8,
+			file_inode(ns->file)->i_blkbits, 12);
 
  	ns->bvec_cache = kmem_cache_create("nvmet-bvec",
  			NVMET_MAX_MPOOL_BVEC * sizeof(struct bio_vec),