Skip to contentSkip to conversation

mm: fix SHUFFLE_PAGE_ALLOCATOR help texts

PATCH In review Qian Cai 2 participants 2 messages Apr 25, 2019 Memory management

lore
Share & tools
lore

Qian Cai

author
#0 lore raw

PATCH 1/1 mm: fix SHUFFLE_PAGE_ALLOCATOR help texts

The help texts for SHUFFLE_PAGE_ALLOCATOR makes a wrong assumption that a page size is 4KB everywhere.

---

Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch.

 init/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
init/Kconfig +3 -2
index b050890f69dc..d96a910369c7 100644
@@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR
 	  the presence of a memory-side-cache. There are also incidental
 	  security benefits as it reduces the predictability of page
 	  allocations to compliment SLAB_FREELIST_RANDOM, but the
-	  default granularity of shuffling on 4MB (MAX_ORDER) pages is
-	  selected based on cache utilization benefits.
+	  default granularity of shuffling on the "MAX_ORDER - 1" i.e,
+	  10th order of pages is selected based on cache utilization
+	  benefits on x86.
 
 	  While the randomization improves cache utilization it may
 	  negatively impact workloads on platforms without a cache. For
Signature · 1 line
2.20.1 (Apple Git-117)
Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Qian Cai

The help texts for SHUFFLE_PAGE_ALLOCATOR makes a wrong assumption that a page size is 4KB everywhere.

---

Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch.

 init/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
init/Kconfig +0 -0
index b050890f69dc..d96a910369c7 100644
@@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR
          the presence of a memory-side-cache. There are also incidental

init/Kconfig config SHUFFLE_PAGE_ALLOCATOR · line 1772

Quoted 10 lines
init/Kconfig +3 -2
          security benefits as it reduces the predictability of page
          allocations to compliment SLAB_FREELIST_RANDOM, but the
-         default granularity of shuffling on 4MB (MAX_ORDER) pages is
-         selected based on cache utilization benefits.
+         default granularity of shuffling on the "MAX_ORDER - 1" i.e,
+         10th order of pages is selected based on cache utilization
+         benefits on x86.
 
          While the randomization improves cache utilization it may
          negatively impact workloads on platforms without a cache. For

Looks good,