mm: fix SHUFFLE_PAGE_ALLOCATOR help texts
PATCH 1/1 mm: fix SHUFFLE_PAGE_ALLOCATOR help texts
The help texts for SHUFFLE_PAGE_ALLOCATOR makes a wrong assumption that a page size is 4KB everywhere.
Signed-off-by Qian Cai <[email protected]>
---
Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch.
init/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
init/Kconfig +3 -2
@@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR the presence of a memory-side-cache. There are also incidental security benefits as it reduces the predictability of page allocations to compliment SLAB_FREELIST_RANDOM, but the - default granularity of shuffling on 4MB (MAX_ORDER) pages is - selected based on cache utilization benefits. + default granularity of shuffling on the "MAX_ORDER - 1" i.e, + 10th order of pages is selected based on cache utilization + benefits on x86. While the randomization improves cache utilization it may negatively impact workloads on platforms without a cache. For
Signature · 1 line
2.20.1 (Apple Git-117)
Quoted 18 lines · Qian Cai
The help texts for
SHUFFLE_PAGE_ALLOCATORmakes a wrong assumption that a page size is 4KB everywhere.Signed-off-by Qian Cai <[email protected]>---
Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch.
init/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)init/Kconfig +0
-0@@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR the presence of a memory-side-cache. There are also incidental
init/Kconfig config SHUFFLE_PAGE_ALLOCATOR · line 1772
Quoted 10 lines
init/Kconfig +3
-2security benefits as it reduces the predictability of page allocations to compliment SLAB_FREELIST_RANDOM, but the - default granularity of shuffling on 4MB (MAX_ORDER) pages is - selected based on cache utilization benefits. + default granularity of shuffling on the "MAX_ORDER - 1" i.e, + 10th order of pages is selected based on cache utilization + benefits on x86. While the randomization improves cache utilization it may negatively impact workloads on platforms without a cache. For
Looks good,
Reviewed-by Dan Williams <[email protected]>