Is the libiscsi engine patch applied correctly?
It seems like these two lines might be in the wrong order? (and the same thing later in the file too)
https://github.com/axboe/fio/blob/afc22c98609ee80a99fbed24231181bdab2bc659/optgroup.h#L65-L66
Rich.
Signature · 4 lines
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
Quoted 4 lines · Richard W.M. Jones
It seems like these two lines might be in the wrong order? (and the same thing later in the file too)
https://github.com/axboe/fio/blob/afc22c98609ee80a99fbed24231181bdab2bc659/optgroup.h#L65-L66
They are, that's a bug. Thanks for letting me know, I've fixed it up.
Signature · 1 line
Jens Axboe
Quoted 7 lines · Jens Axboe
Quoted 4 lines · Richard W.M. Jones
It seems like these two lines might be in the wrong order? (and the same thing later in the file too)
https://github.com/axboe/fio/blob/afc22c98609ee80a99fbed24231181bdab2bc659/optgroup.h#L65-L66
They are, that's a bug. Thanks for letting me know, I've fixed it up.
Thanks. I think also these lines later in the same file -- although not technically a bug -- should also be swapped around:
FIO_OPT_G_INVALID = (1ULL << __FIO_OPT_G_NR), FIO_OPT_G_ISCSI = (1ULL << __FIO_OPT_G_ISCSI),
Rich.
Signature · 5 lines
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/
Quoted 7 lines · Richard W.M. Jones
Quoted 6 lines · Jens Axboe
Quoted 4 lines · Richard W.M. Jones
It seems like these two lines might be in the wrong order? (and the same thing later in the file too)
https://github.com/axboe/fio/blob/afc22c98609ee80a99fbed24231181bdab2bc659/optgroup.h#L65-L66
Quoted 7 lines
Quoted 1 line
They are, that's a bug. Thanks for letting me know, I've fixed it up.
Thanks. I think also these lines later in the same file -- although not technically a bug -- should also be swapped around:
FIO_OPT_G_INVALID = (1ULL << __FIO_OPT_G_NR), FIO_OPT_G_ISCSI = (1ULL << __FIO_OPT_G_ISCSI),
Order of those don't really matter. But for pure aesthetics, yeah they should probably be swapped.
Signature · 1 line
Jens Axboe