fixup! drivers/misc: Add Aspeed P2A control driver
Subsystems (2)
PATCH 1/1 fixup! drivers/misc: Add Aspeed P2A control driver
Fixup compiler warnings:
- 108 warning: ISO C90 forbids mixed declarations and code
- 264 warning: unused variable 'value'
- 335 warning: unused variable 'res'
Signed-off-by Patrick Venture <[email protected]>
--- drivers/misc/aspeed-p2a-ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/misc/aspeed-p2a-ctrl.c +3 -3
@@ -99,13 +99,14 @@ static void aspeed_p2a_disable_bridge(struct aspeed_p2a_ctrl *p2a_ctrl)static int aspeed_p2a_mmap (struct file *file,struct vm_area_struct *vma) { +unsigned long vsize;struct aspeed_p2a_user *priv = file->private_data;struct aspeed_p2a_ctrl *ctrl = priv->parent;if (ctrl->mem_base ==0 && ctrl->mem_size ==0 )return -EINVAL ; -unsigned long vsize = vma->vm_end - vma->vm_start; + vsize = vma->vm_end - vma->vm_start;pgprot_t prot = vma->vm_page_prot;if (vma->vm_pgoff + vsize > ctrl->mem_base + ctrl->mem_size)
@@ -261,7 +262,6 @@ static int aspeed_p2a_open(struct inode *inode, struct file *file)static int aspeed_p2a_release (struct inode *inode,struct file *file) {int i; -u32 value;u32 bits =0 ;bool open_regions = false;struct aspeed_p2a_user *priv = file->private_data;
@@ -332,7 +332,7 @@ static int aspeed_p2a_ctrl_probe(struct platform_device *pdev) {struct aspeed_p2a_ctrl *misc_ctrl;struct device *dev; -struct resource *res, resm; +struct resource resm;struct device_node *node;int rc =0 ;
Signature · 1 line
2.21.0.593.g511ec345e18-goog
Greg KH
maintainerQuoted 6 lines · Patrick Venture
Fixup compiler warnings:
- 108 warning: ISO C90 forbids mixed declarations and code
- 264 warning: unused variable 'value'
- 335 warning: unused variable 'res'Signed-off-by Patrick Venture <[email protected]>
Reported-by kbuild...
I'll go add it, next time please do it yourself.
thanks,
greg k-h
Quoted 7 lines · Greg KH
Quoted 5 lines · Patrick Venture
Fixup compiler warnings:
- 108 warning: ISO C90 forbids mixed declarations and code
- 264 warning: unused variable 'value'
- 335 warning: unused variable 'res'
Quoted 5 lines
Quoted 1 line
Signed-off-by Patrick Venture <[email protected]>Reported-by kbuild...I'll go add it, next time please do it yourself.
Roger that!
Quoted 4 lines
thanks,
greg k-h