Skip to contentSkip to conversation

migration/colo.c: Remove redundant input parameter

PATCH In review Zhang Chen 1 participant 2 messages Apr 26, 2019

lore
Share & tools
lore

Zhang Chen

author
#0 lore raw

PATCH 1/1 migration/colo.c: Remove redundant input parameter

From: Zhang Chen <[email protected]>

The colo_do_failover no need the input parameter.

---
 include/migration/colo.h  | 2 +-
 migration/colo-failover.c | 2 +-
 migration/colo.c          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
include/migration/colo.h +1 -1
index 99ce17aca7..ddebe0ad27 100644
@@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void);
 COLOMode get_colo_mode(void);
 
 /* failover */
-void colo_do_failover(MigrationState *s);
+void colo_do_failover(void);
 
 void colo_checkpoint_notify(void *opaque);
 #endif
migration/colo-failover.c +1 -1
index 4854a96c92..e9ca0b4774 100644
@@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque)
         return;
     }
 
-    colo_do_failover(NULL);
+    colo_do_failover();
 }
 
 void failover_request_active(Error **errp)
migration/colo.c +1 -1
index 238a6d62c7..8c1644091f 100644
@@ -193,7 +193,7 @@ COLOMode get_colo_mode(void)
     }
 }
 
-void colo_do_failover(MigrationState *s)
+void colo_do_failover(void)
 {
     /* Make sure VM stopped while failover happened. */
     if (!colo_runstate_is_stopped()) {
Signature · 1 line
2.17.GIT
#1 lore raw

This patch have been integrated in this series:
http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg04520.html
Please review it at this link.

Thanks
Zhang Chen

Quoted 58 lines

-----Original Message-----
From: Zhang, Chen
Sent: Friday, April 26, 2019 11:40 AM
To: Laurent Vivier <[email protected]>; Dr. David Alan Gilbert <[email protected]>; Juan Quintela <[email protected]>; zhanghailiang <[email protected]>; qemu-dev <[email protected]>
Cc: Zhang Chen <[email protected]>; Zhang, Chen <[email protected]>
Subject: [PATCH] migration/colo.c: Remove redundant input parameter

From: Zhang Chen <[email protected]>

The colo_do_failover no need the input parameter.

---
 include/migration/colo.h  | 2 +-
 migration/colo-failover.c | 2 +-
 migration/colo.c          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
include/migration/colo.h index renamed from include/migration/colo.h +0 -0

99ce17aca7..ddebe0ad27 100644

include/migration/colo.h +1 -1
@@ -37,7 +37,7 @@ bool migration_incoming_in_colo_state(void);
 COLOMode get_colo_mode(void);
 
 /* failover */
-void colo_do_failover(MigrationState *s);
+void colo_do_failover(void);
 
 void colo_checkpoint_notify(void *opaque);  #endif diff --git a/migration/colo-

failover.c b/migration/colo-failover.c index 4854a96c92..e9ca0b4774 100644

migration/colo-failover.c +1 -1
@@ -39,7 +39,7 @@ static void colo_failover_bh(void *opaque)
         return;
     }
 
-    colo_do_failover(NULL);
+    colo_do_failover();
 }
 
 void failover_request_active(Error **errp) diff --git a/migration/colo.c

b/migration/colo.c index 238a6d62c7..8c1644091f 100644

migration/colo.c +1 -2
@@ -193,7 +193,7 @@ COLOMode get_colo_mode(void)
     }
 }
 
-void colo_do_failover(MigrationState *s)
+void colo_do_failover(void)
 {
     /* Make sure VM stopped while failover happened. */
     if (!colo_runstate_is_stopped()) {
--

2.17.GIT