Skip to contentSkip to conversation

examples/vm_power_manager: fix overflowed return value

PATCH In review David Hunt 2 participants 6 messages Apr 26, 2019

lore
Share & tools
lore

David Hunt

author
#0 lore raw

PATCH 1/1 examples/vm_power_manager: fix overflowed return value

Coverity complains about the return of a value that may possibly overflow because of a multiply. Limit the value so it cannot overflow.

Coverity issue: 337677

Fixes 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
---
 examples/vm_power_manager/oob_monitor_x86.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
examples/vm_power_manager/oob_monitor_x86.c +4 -1
index ebd96b205..2074eec1e 100644
@@ -99,7 +99,10 @@ apply_policy(int core)
 		return -1.0;
 	}
 
-	ratio = (float)miss_diff * (float)100 / (float)hits_diff;
+	ratio = (float)miss_diff / (float)hits_diff;
+	if (ratio > 1.0)
+		ratio = 1.0;
+	ratio *= 100.0f;
 
 	if (ratio < ci->branch_ratio_threshold)
 		power_manager_scale_core_min(core);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 17 lines · David Hunt

Coverity complains about the return of a value that may possibly overflow because of a multiply. Limit the value so it cannot overflow.

Coverity issue: 337677

Fixes 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
---
  examples/vm_power_manager/oob_monitor_x86.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
examples/vm_power_manager/oob_monitor_x86.c +0 -0
index ebd96b205..2074eec1e 100644

examples/vm_power_manager/oob_monitor_x86.c apply_policy(int core) · line 105

Quoted 8 lines
examples/vm_power_manager/oob_monitor_x86.c +4 -1
@@ -99,7 +99,10 @@ apply_policy(int core)
  		return -1.0;
  	}
 
-	ratio = (float)miss_diff * (float)100 / (float)hits_diff;
+	ratio = (float)miss_diff / (float)hits_diff;
+	if (ratio > 1.0)
+		ratio = 1.0;
+	ratio *= 100.0f;

It should probably be the other way around - multiply first, then clamp. Also, please use RTE_MIN.

Quoted 4 lines
examples/vm_power_manager/oob_monitor_x86.c +0 -0
  	if (ratio < ci->branch_ratio_threshold)
  		power_manager_scale_core_min(core);
 
Signature · 2 lines
Thanks,
Anatoly
#2 lore raw

Hi Anatoly,

Quoted 13 lines · Anatoly
Quoted 12 lines · David Hunt

Coverity complains about the return of a value that may possibly overflow because of a multiply. Limit the value so it cannot overflow.

Coverity issue: 337677

Fixes 4b1a631b8a ("examples/vm_power: add oob monitoring functions")

---
  examples/vm_power_manager/oob_monitor_x86.c | 5 ++++-

  1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 15 lines

examples/vm_power_manager/oob_monitor_x86.c apply_policy(int core) · line 105

Quoted 12 lines
examples/vm_power_manager/oob_monitor_x86.c +4 -0
index ebd96b205..2074eec1e 100644
@@ -99,7 +99,10 @@ apply_policy(int core)
           return -1.0;
       }
   -    ratio = (float)miss_diff * (float)100 / (float)hits_diff;
+    ratio = (float)miss_diff / (float)hits_diff;
+    if (ratio > 1.0)
+        ratio = 1.0;
+    ratio *= 100.0f;

It should probably be the other way around - multiply first, then clamp. Also, please use RTE_MIN.

I tried that, but coverity still sees an overflow condition. I need to clamp first, then multiply. Then coverity is happy.

Also, do you really want me to change to use RTE_MIN? I honestly prefer the code as it is.

Quoted 5 lines
Quoted 3 lines
examples/vm_power_manager/oob_monitor_x86.c +0 -0
         if (ratio < ci->branch_ratio_threshold)
           power_manager_scale_core_min(core);
 
#3 lore raw
Quoted 31 lines · David

Hi Anatoly,

Quoted 13 lines · Anatoly
Quoted 12 lines · David Hunt

Coverity complains about the return of a value that may possibly overflow because of a multiply. Limit the value so it cannot overflow.

Coverity issue: 337677

Fixes 4b1a631b8a ("examples/vm_power: add oob monitoring functions")

---
  examples/vm_power_manager/oob_monitor_x86.c | 5 ++++-

  1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 15 lines

examples/vm_power_manager/oob_monitor_x86.c apply_policy(int core) · line 105

Quoted 12 lines
examples/vm_power_manager/oob_monitor_x86.c +4 -0
index ebd96b205..2074eec1e 100644
@@ -99,7 +99,10 @@ apply_policy(int core)
           return -1.0;
       }
   -    ratio = (float)miss_diff * (float)100 / (float)hits_diff;
+    ratio = (float)miss_diff / (float)hits_diff;
+    if (ratio > 1.0)
+        ratio = 1.0;
+    ratio *= 100.0f;

It should probably be the other way around - multiply first, then clamp. Also, please use RTE_MIN.

Quoted 1 line

I tried that, but coverity still sees an overflow condition. I need to clamp first, then multiply. Then coverity is happy.

That's weird. This may be a bug in Coverity then. Please correct me if i'm wrong, but floating point formats aren't precise, so by doing multiplication on a value that doesn't exceed 1.0, you may very well end up with a value that does exceed 100 by a tiny bit on account of floating point approximations, rounding errors etc.

The question is, do we want correct code, or do we want to keep Coverity happy? :) I'll have a look at the coverity issue itself, maybe i'm missing something here...

Quoted 2 lines

Also, do you really want me to change to use RTE_MIN? I honestly prefer the code as it is.

No strong opinion here.

Quoted 9 lines
Quoted 8 lines
Quoted 6 lines
examples/vm_power_manager/oob_monitor_x86.c +0 -0
         if (ratio < ci->branch_ratio_threshold)
           power_manager_scale_core_min(core);
 
Signature · 2 lines
Thanks,
Anatoly
#4 lore raw
Quoted 32 lines · Anatoly
Quoted 31 lines · David

Hi Anatoly,

Quoted 28 lines · Anatoly
Quoted 17 lines · David Hunt

Coverity complains about the return of a value that may possibly overflow because of a multiply. Limit the value so it cannot overflow.

Coverity issue: 337677

Fixes 4b1a631b8a ("examples/vm_power: add oob monitoring functions")

---
  examples/vm_power_manager/oob_monitor_x86.c | 5 ++++-

  1 file changed, 4 insertions(+), 1 deletion(-)
examples/vm_power_manager/oob_monitor_x86.c +0 -0
index ebd96b205..2074eec1e 100644

examples/vm_power_manager/oob_monitor_x86.c apply_policy(int core) · line 105

Quoted 7 lines
examples/vm_power_manager/oob_monitor_x86.c +4 -0
@@ -99,7 +99,10 @@ apply_policy(int core)
           return -1.0;
       }
   -    ratio = (float)miss_diff * (float)100 / (float)hits_diff;
+    ratio = (float)miss_diff / (float)hits_diff;
+    if (ratio > 1.0)
+        ratio = 1.0;
+    ratio *= 100.0f;

It should probably be the other way around - multiply first, then clamp. Also, please use RTE_MIN.

Quoted 6 lines
Quoted 1 line

I tried that, but coverity still sees an overflow condition. I need to clamp first, then multiply. Then coverity is happy.

That's weird. This may be a bug in Coverity then. Please correct me if i'm wrong, but floating point formats aren't precise, so by doing multiplication on a value that doesn't exceed 1.0, you may very well end up with a value that does exceed 100 by a tiny bit on account of floating point approximations, rounding errors etc.

The question is, do we want correct code, or do we want to keep Coverity happy? :) I'll have a look at the coverity issue itself, maybe i'm missing something here...

I think the real source of the problem is not that, and i believe there's something wrong with Coverity's analysis here.

For some reason Coverity thinks that multiplying two floating point values (100f and miss_diff converted to float) will result in /integer/ overflow (lolwut?), *and* it assumes that miss_diff is negative at that point when it *can't* be, because if miss_diff was negative, we would've done an early exit on line 77.

My guess is, this is the culprit:

"overflow: Multiply operation overflows on operands (float)miss_diff and 100f. Example values for operands: *100f = 268435456*, (float)miss_diff = -2147483648."

The "100f = 268435456" part makes me suspect that Coverity somehow thinks that "100f" is a variable name?

Quoted 16 lines
Quoted 2 lines

Also, do you really want me to change to use RTE_MIN? I honestly prefer the code as it is.

No strong opinion here.

Quoted 9 lines
Quoted 8 lines
Quoted 6 lines
examples/vm_power_manager/oob_monitor_x86.c +0 -0
         if (ratio < ci->branch_ratio_threshold)
           power_manager_scale_core_min(core);
 
Signature · 2 lines
Thanks,
Anatoly
#5 lore raw
In reply to Burakov, Anatoly
Quoted 13 lines · Anatoly
Quoted 12 lines · David Hunt

Coverity complains about the return of a value that may possibly overflow because of a multiply. Limit the value so it cannot overflow.

Coverity issue: 337677

Fixes 4b1a631b8a ("examples/vm_power: add oob monitoring functions")

---
  examples/vm_power_manager/oob_monitor_x86.c | 5 ++++-

  1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 18 lines

examples/vm_power_manager/oob_monitor_x86.c apply_policy(int core) · line 105

Quoted 12 lines
examples/vm_power_manager/oob_monitor_x86.c +4 -0
index ebd96b205..2074eec1e 100644
@@ -99,7 +99,10 @@ apply_policy(int core)
           return -1.0;
       }
   -    ratio = (float)miss_diff * (float)100 / (float)hits_diff;
+    ratio = (float)miss_diff / (float)hits_diff;
+    if (ratio > 1.0)
+        ratio = 1.0;
+    ratio *= 100.0f;

It should probably be the other way around - multiply first, then clamp. Also, please use RTE_MIN.

Quoted 3 lines
examples/vm_power_manager/oob_monitor_x86.c +0 -0
         if (ratio < ci->branch_ratio_threshold)
           power_manager_scale_core_min(core);
 

Anatoly and myself have spendt some time analysing the coverity issue just now, and we have come to the conclusion that it's a false positive. We also think it may be an issue with coverity, so for the moment I'll mark the coverity issue as a false positive.