Skip to contentSkip to conversation

Enabling PC8+ residency for all GEN9+ platforms v6

PATCH Superseded Anshuman Gupta 5 participants 14 messages Apr 26, 2019 – May 3, 2019

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v6 cover Enabling PC8+ residency for all GEN9+ platforms v6

This patch series enable PC8+ residency test, earlier these tests were only enabled for Haswell and Broadwell.

I have addressed the below review comment provided by Imre on old series (https://patchwork.freedesktop.org/series/57035/)

1. Made this test future proof to enable for all Gen9+ platform.
2. Added a pc8_needs_screen_off flag to distinguish between HSW/BDW and Gen9+ Platform.
3. Since Gen9 onwards PC8+ residency doesn't require display to be turned off, this patch series tests PC8 residency with all screens on.

Addressed review comment provided by Ram on revision 3 (patch commit log describes the changes).

Earlier pc8-residency sub-test were failing on most of Gen 9 platforms, so trying pc8-residency sub test after setting up powertop and pmc lte_ignore one by one (This is additional debug patch).

As earlier this patch series was not lucky to be tested on ICL, adding the affected test in fast-feedback.testlist.

Anshuman Gupta (4):
tests/i915/i915_pm_rpm: Enable PC8+ residency test for all Gen9+ tests/i915/i915_pm_rpm: modeset-pc8-residency-stress
DEBUG: invoke powertop and pmc ltr_ignore when pc8 tests fails.
DO_NOT_MERGE: adding i915_pm_rpm pc8 subtest to fast feedback list.

 tests/i915/i915_pm_rpm.c              | 236 ++++++++++++++++++++++++++++++++--
 tests/intel-ci/fast-feedback.testlist |   3 +
 2 files changed, 229 insertions(+), 10 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH v6 1/4 tests/i915/i915_pm_rpm: Enable PC8+ residency test for all Gen9+

Enabled has_pc8 global for ICL and Gen9+. Modified PC8+ residency sub-test with all screen enabled.

v2:Fixed the issue of skipped test on HSW.
Improved the code comment for MSR_PKG_CST_CONFIG_CONTROL mask and PC8 bits, it holds good for SKL/ICL and Goldmont microarchitecture. Code readabilty improvement.

v3:Removed the connected_screens global. [Ram]
Removed pc8_needs_screen_off from mode_set_data structure,
made it global, aligning to has_pc8 and has_runtime_pm globals. [Ram] Reuse connector lcoal variable in init_modeset_params_for_all_screen(). [Ram] Addressed Coding guide lines comments. [Ram]

v4:Improved the code comment for MSR_PKG_CST_CONFIG_CONTROL mask and PC8 bits. [Ram]
Introduced set_screens_mode_params() function to fix warning of line exceeding 80 char, fixed this warning at other places too. [Ram]
Using ms_data modset_data global structure. [Ram]
Introduced macros for timeout values, given to PC8+ residency check function. [Ram]

---
 tests/i915/i915_pm_rpm.c | 91 +++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 83 insertions(+), 8 deletions(-)
tests/i915/i915_pm_rpm.c +83 -8
index a2c9d0e..9315dbd 100644
@@ -52,7 +52,11 @@
 #include "igt_device.h"
 
 #define MSR_PKG_CST_CONFIG_CONTROL	0xE2
-/* HSW/BDW: */
+/*
+ * Below PKG CST limit mask and PC8 bits are meant for
+ * HSW,BDW SKL,ICL and Goldmont Microarch.
+ * Refer IA S/W developers manual vol3c part3 chapter:35
+ */
 #define  PKG_CST_LIMIT_MASK		0xF
 #define  PKG_CST_LIMIT_C8		0x6
 
@@ -64,6 +68,10 @@
 #define MAX_ENCODERS	32
 #define MAX_CRTCS	16
 
+#define TIME_OUT_SEC_5   5
+#define TIME_OUT_SEC_10 10
+#define TIME_OUT_SEC_30 30
+
 enum pc8_status {
 	PC8_ENABLED,
 	PC8_DISABLED
@@ -90,7 +98,7 @@ enum plane_type {
 
 int drm_fd, msr_fd, pc8_status_fd;
 int debugfs;
-bool has_runtime_pm, has_pc8;
+bool has_runtime_pm, has_pc8, pc8_needs_screen_off;
 struct mode_set_data ms_data;
 
 /* Stuff used when creating FBs and mode setting. */
@@ -121,9 +129,25 @@ struct modeset_params {
 struct modeset_params lpsp_mode_params;
 struct modeset_params non_lpsp_mode_params;
 struct modeset_params *default_mode_params;
+struct modeset_params *screens_mode_params[MAX_CONNECTORS];
 
 static int8_t *pm_data = NULL;
 
+static inline void set_screens_mode_param(drmModeConnectorPtr connector,
+					  struct modeset_params *params)
+{
+	drmModeModeInfoPtr mode = NULL;
+
+	mode = &connector->modes[0];
+	igt_create_pattern_fb(drm_fd, mode->hdisplay, mode->vdisplay,
+			      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE,
+			      &params->fb);
+	params->crtc_id = kmstest_find_crtc_for_connector(drm_fd, ms_data.res,
+							  connector, 0);
+	params->connector_id = connector->connector_id;
+	params->mode = mode;
+}
+
 static int modprobe(const char *driver)
 {
 	return igt_kmod_load(driver, NULL);
@@ -297,6 +321,28 @@ static bool init_modeset_params_for_type(struct mode_set_data *data,
 	return true;
 }
 
+static void init_modeset_params_for_all_screen(void)
+{
+	drmModeConnectorPtr connector = NULL;
+	int screen = 0;
+
+	if (!ms_data.res)
+		return;
+
+	for (int i = 0; i < ms_data.res->count_connectors; i++) {
+		connector = ms_data.connectors[i];
+
+		if (connector->connection == DRM_MODE_CONNECTED
+		    && connector->count_modes) {
+			screens_mode_params[screen] =
+				malloc(sizeof(struct modeset_params));
+			set_screens_mode_param(connector,
+					       screens_mode_params[screen]);
+			screen++;
+		}
+	}
+}
+
 static void init_modeset_cached_params(struct mode_set_data *data)
 {
 	bool lpsp, non_lpsp;
@@ -305,6 +351,7 @@ static void init_modeset_cached_params(struct mode_set_data *data)
 					    SCREEN_TYPE_LPSP);
 	non_lpsp = init_modeset_params_for_type(data, &non_lpsp_mode_params,
 						SCREEN_TYPE_NON_LPSP);
+	init_modeset_params_for_all_screen();
 
 	if (lpsp)
 		default_mode_params = &lpsp_mode_params;
@@ -353,6 +400,22 @@ static bool enable_one_screen_with_type(struct mode_set_data *data,
 	return set_mode_for_params(params);
 }
 
+static void enable_all_screens(void)
+{
+	struct modeset_params *params = NULL;
+
+	/* SKIP if there are no connected screens. */
+	igt_require(screens_mode_params[0]);
+
+	for (int i = 0; i < MAX_CONNECTORS ; i++) {
+		params = screens_mode_params[i];
+		if (params)
+			set_mode_for_params(params);
+		else
+			break;
+	}
+}
+
 static void enable_one_screen(struct mode_set_data *data)
 {
 	/* SKIP if there are no connected screens. */
@@ -685,8 +748,12 @@ static void setup_pc8(void)
 {
 	has_pc8 = false;
 
-	/* Only Haswell supports the PC8 feature. */
-	if (!IS_HASWELL(ms_data.devid) && !IS_BROADWELL(ms_data.devid))
+	if (IS_HASWELL(ms_data.devid) || IS_BROADWELL(ms_data.devid))
+		pc8_needs_screen_off = true;
+	else if (AT_LEAST_GEN(ms_data.devid, 9))
+		pc8_needs_screen_off = false;
+	/* Only Haswell supports the PC8 feature on lesser than GEN9. */
+	else
 		return;
 
 	/* Make sure our Kernel supports MSR and the module is loaded. */
@@ -803,14 +870,22 @@ static void pc8_residency_subtest(void)
 
 	/* Make sure PC8+ residencies move! */
 	disable_all_screens(&ms_data);
-	igt_assert_f(pc8_plus_residency_changed(30),
+	igt_assert_f(pc8_plus_residency_changed(TIME_OUT_SEC_30),
 		     "Machine is not reaching PC8+ states, please check its "
 		     "configuration.\n");
 
 	/* Make sure PC8+ residencies stop! */
-	enable_one_screen(&ms_data);
-	igt_assert_f(!pc8_plus_residency_changed(10),
-		     "PC8+ residency didn't stop with screen enabled.\n");
+	if (pc8_needs_screen_off) {
+		enable_one_screen(&ms_data);
+		igt_assert_f(!pc8_plus_residency_changed(TIME_OUT_SEC_10),
+			     "PC8+ residency didn't stop with "
+			     "screen enabled.\n");
+	} else {
+		enable_all_screens();
+		igt_assert_f(pc8_plus_residency_changed(TIME_OUT_SEC_10),
+			     "Machine is not reaching PC8+ states "
+			     "with all screen enabled.\n");
+	}
 }
 
 static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

Re: [igt-dev] [PATCH i-g-t v6 1/4] tests/i915/i915_pm_rpm: Enable PC8+ residency test for all Gen9+

Quoted 43 lines · Anshuman Gupta

Enabled has_pc8 global for ICL and Gen9+. Modified PC8+ residency sub-test with all screen enabled.

v2:Fixed the issue of skipped test on HSW.
Improved the code comment for MSR_PKG_CST_CONFIG_CONTROL mask and PC8 bits, it holds good for SKL/ICL and Goldmont microarchitecture. Code readabilty improvement.

v3:Removed the connected_screens global. [Ram]
Removed pc8_needs_screen_off from mode_set_data structure,
made it global, aligning to has_pc8 and has_runtime_pm globals. [Ram] Reuse connector lcoal variable in init_modeset_params_for_all_screen(). [Ram] Addressed Coding guide lines comments. [Ram]

v4:Improved the code comment for MSR_PKG_CST_CONFIG_CONTROL mask and PC8 bits. [Ram]
Introduced set_screens_mode_params() function to fix warning of line exceeding 80 char, fixed this warning at other places too. [Ram]
Using ms_data modset_data global structure. [Ram]
Introduced macros for timeout values, given to PC8+ residency check function. [Ram]

---
 tests/i915/i915_pm_rpm.c | 91 +++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 83 insertions(+), 8 deletions(-)
tests/i915/i915_pm_rpm.c +5 -1
index a2c9d0e..9315dbd 100644
@@ -52,7 +52,11 @@
 #include "igt_device.h"
 
 #define MSR_PKG_CST_CONFIG_CONTROL	0xE2
-/* HSW/BDW: */
+/*
+ * Below PKG CST limit mask and PC8 bits are meant for
+ * HSW,BDW SKL,ICL and Goldmont Microarch.
+ * Refer IA S/W developers manual vol3c part3 chapter:35
+ */
 #define  PKG_CST_LIMIT_MASK		0xF
 #define  PKG_CST_LIMIT_C8		0x6
 

tests/i915/i915_pm_rpm.c line 73

Quoted 6 lines
tests/i915/i915_pm_rpm.c +3 -0
@@ -64,6 +68,10 @@
 #define MAX_ENCODERS	32
 #define MAX_CRTCS	16
 
+#define TIME_OUT_SEC_5   5
+#define TIME_OUT_SEC_10 10
+#define TIME_OUT_SEC_30 30

Macros are supposed to represent the purpose of it. I would expect macro itself should answer the question of "timeout for what?"

Quoted 115 lines
tests/i915/i915_pm_rpm.c +63 -3
+
 enum pc8_status {
 	PC8_ENABLED,
 	PC8_DISABLED
@@ -90,7 +98,7 @@ enum plane_type {
 
 int drm_fd, msr_fd, pc8_status_fd;
 int debugfs;
-bool has_runtime_pm, has_pc8;
+bool has_runtime_pm, has_pc8, pc8_needs_screen_off;
 struct mode_set_data ms_data;
 
 /* Stuff used when creating FBs and mode setting. */
@@ -121,9 +129,25 @@ struct modeset_params {
 struct modeset_params lpsp_mode_params;
 struct modeset_params non_lpsp_mode_params;
 struct modeset_params *default_mode_params;
+struct modeset_params *screens_mode_params[MAX_CONNECTORS];
 
 static int8_t *pm_data = NULL;
 
+static inline void set_screens_mode_param(drmModeConnectorPtr connector,
+					  struct modeset_params *params)
+{
+	drmModeModeInfoPtr mode = NULL;
+
+	mode = &connector->modes[0];
+	igt_create_pattern_fb(drm_fd, mode->hdisplay, mode->vdisplay,
+			      DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE,
+			      &params->fb);
+	params->crtc_id = kmstest_find_crtc_for_connector(drm_fd, ms_data.res,
+							  connector, 0);
+	params->connector_id = connector->connector_id;
+	params->mode = mode;
+}
+
 static int modprobe(const char *driver)
 {
 	return igt_kmod_load(driver, NULL);
@@ -297,6 +321,28 @@ static bool init_modeset_params_for_type(struct mode_set_data *data,
 	return true;
 }
 
+static void init_modeset_params_for_all_screen(void)
+{
+	drmModeConnectorPtr connector = NULL;
+	int screen = 0;
+
+	if (!ms_data.res)
+		return;
+
+	for (int i = 0; i < ms_data.res->count_connectors; i++) {
+		connector = ms_data.connectors[i];
+
+		if (connector->connection == DRM_MODE_CONNECTED
+		    && connector->count_modes) {
+			screens_mode_params[screen] =
+				malloc(sizeof(struct modeset_params));
+			set_screens_mode_param(connector,
+					       screens_mode_params[screen]);
+			screen++;
+		}
+	}
+}
+
 static void init_modeset_cached_params(struct mode_set_data *data)
 {
 	bool lpsp, non_lpsp;
@@ -305,6 +351,7 @@ static void init_modeset_cached_params(struct mode_set_data *data)
 					    SCREEN_TYPE_LPSP);
 	non_lpsp = init_modeset_params_for_type(data, &non_lpsp_mode_params,
 						SCREEN_TYPE_NON_LPSP);
+	init_modeset_params_for_all_screen();
 
 	if (lpsp)
 		default_mode_params = &lpsp_mode_params;
@@ -353,6 +400,22 @@ static bool enable_one_screen_with_type(struct mode_set_data *data,
 	return set_mode_for_params(params);
 }
 
+static void enable_all_screens(void)
+{
+	struct modeset_params *params = NULL;
+
+	/* SKIP if there are no connected screens. */
+	igt_require(screens_mode_params[0]);
+
+	for (int i = 0; i < MAX_CONNECTORS ; i++) {
+		params = screens_mode_params[i];
+		if (params)
+			set_mode_for_params(params);
+		else
+			break;
+	}
+}
+
 static void enable_one_screen(struct mode_set_data *data)
 {
 	/* SKIP if there are no connected screens. */
@@ -685,8 +748,12 @@ static void setup_pc8(void)
 {
 	has_pc8 = false;
 
-	/* Only Haswell supports the PC8 feature. */
-	if (!IS_HASWELL(ms_data.devid) && !IS_BROADWELL(ms_data.devid))
+	if (IS_HASWELL(ms_data.devid) || IS_BROADWELL(ms_data.devid))
+		pc8_needs_screen_off = true;
+	else if (AT_LEAST_GEN(ms_data.devid, 9))
+		pc8_needs_screen_off = false;
+	/* Only Haswell supports the PC8 feature on lesser than GEN9. */
+	else
 		return;
 
 	/* Make sure our Kernel supports MSR and the module is loaded. */

tests/i915/i915_pm_rpm.c static void pc8_residency_subtest(void) · line 873

Quoted 5 lines
tests/i915/i915_pm_rpm.c +1 -1
@@ -803,14 +870,22 @@ static void pc8_residency_subtest(void)
 
 	/* Make sure PC8+ residencies move! */
 	disable_all_screens(&ms_data);
-	igt_assert_f(pc8_plus_residency_changed(30),
+	igt_assert_f(pc8_plus_residency_changed(TIME_OUT_SEC_30),

Drop this, as this is irrelevant for this patch. If this is needed do it as separate patch.

-Ram.

Quoted 24 lines
tests/i915/i915_pm_rpm.c +11 -3
 		     "Machine is not reaching PC8+ states, please check its "
 		     "configuration.\n");
 
 	/* Make sure PC8+ residencies stop! */
-	enable_one_screen(&ms_data);
-	igt_assert_f(!pc8_plus_residency_changed(10),
-		     "PC8+ residency didn't stop with screen enabled.\n");
+	if (pc8_needs_screen_off) {
+		enable_one_screen(&ms_data);
+		igt_assert_f(!pc8_plus_residency_changed(TIME_OUT_SEC_10),
+			     "PC8+ residency didn't stop with "
+			     "screen enabled.\n");
+	} else {
+		enable_all_screens();
+		igt_assert_f(pc8_plus_residency_changed(TIME_OUT_SEC_10),
+			     "Machine is not reaching PC8+ states "
+			     "with all screen enabled.\n");
+	}
 }
 
 static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
Signature · 1 line
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

PATCH v6 2/4 tests/i915/i915_pm_rpm: modeset-pc8-residency-stress

In reply to Anshuman Gupta

Introduced pc8_needs_screen_off flag in order to differentiate between HASWELL/BROADWELL and AT_LEAST_GEN9. GEN9 onwards PC8+ residency does't require display to be turned on.

v3:Removed pc8_needs_screen_off from mode_set_data structure,
made it global, aligning to has_pc8 and has_runtime_pm globals. [Ram] Made modeset_subtest() to tests PC8+ residency after enabling a screen, earlier it expects PC8+ residency to stop on HSW/BDW.

v4:Fixed conditional code for pc8_needs_screen_off. [Ram]
Used macros for timeout values, given to PC8+ residency check function. [Ram] Changed the screen on timeout to check pc8+ residency to 10 seconds.

---
 tests/i915/i915_pm_rpm.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
tests/i915/i915_pm_rpm.c +8 -2
index 9315dbd..bd13d21 100644
@@ -907,7 +907,7 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 		if (wait_flags & WAIT_STATUS)
 			igt_assert(wait_for_suspended());
 		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(pc8_plus_residency_changed(30));
+			igt_assert(pc8_plus_residency_changed(TIME_OUT_SEC_30));
 		if (wait_flags & WAIT_EXTRA)
 			sleep(5);
 
@@ -917,7 +917,13 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 		if (wait_flags & WAIT_STATUS)
 			igt_assert(wait_for_active());
 		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(!pc8_plus_residency_changed(5));
+			if (pc8_needs_screen_off)
+				igt_assert(!pc8_plus_residency_changed
+					   (TIME_OUT_SEC_5));
+			else
+				igt_assert(pc8_plus_residency_changed
+					   (TIME_OUT_SEC_10));
+
 		if (wait_flags & WAIT_EXTRA)
 			sleep(5);
 	}
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#4 lore raw

Re: [igt-dev] [PATCH i-g-t v6 2/4] tests/i915/i915_pm_rpm: modeset-pc8-residency-stress

Quoted 3 lines · Anshuman Gupta

Introduced pc8_needs_screen_off flag in order to differentiate between HASWELL/BROADWELL and AT_LEAST_GEN9. GEN9 onwards PC8+ residency does't require display to be turned on.

Why are we so fixated on pc8? Shouldn't we just check that we reach the max package c-state with displays off?

Quoted 50 lines

v3:Removed pc8_needs_screen_off from mode_set_data structure,
made it global, aligning to has_pc8 and has_runtime_pm globals. [Ram] Made modeset_subtest() to tests PC8+ residency after enabling a screen, earlier it expects PC8+ residency to stop on HSW/BDW.

v4:Fixed conditional code for pc8_needs_screen_off. [Ram]
Used macros for timeout values, given to PC8+ residency check function. [Ram] Changed the screen on timeout to check pc8+ residency to 10 seconds.

---
 tests/i915/i915_pm_rpm.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
tests/i915/i915_pm_rpm.c +8 -2
index 9315dbd..bd13d21 100644
@@ -907,7 +907,7 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 		if (wait_flags & WAIT_STATUS)
 			igt_assert(wait_for_suspended());
 		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(pc8_plus_residency_changed(30));
+			igt_assert(pc8_plus_residency_changed(TIME_OUT_SEC_30));
 		if (wait_flags & WAIT_EXTRA)
 			sleep(5);
 
@@ -917,7 +917,13 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 		if (wait_flags & WAIT_STATUS)
 			igt_assert(wait_for_active());
 		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(!pc8_plus_residency_changed(5));
+			if (pc8_needs_screen_off)
+				igt_assert(!pc8_plus_residency_changed
+					   (TIME_OUT_SEC_5));
+			else
+				igt_assert(pc8_plus_residency_changed
+					   (TIME_OUT_SEC_10));
+
 		if (wait_flags & WAIT_EXTRA)
 			sleep(5);
 	}
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#5 lore raw

Re: [igt-dev] [PATCH i-g-t v6 2/4] tests/i915/i915_pm_rpm: modeset-pc8-residency-stress

Quoted 7 lines · Ville Syrjälä
Quoted 3 lines · Anshuman Gupta

Introduced pc8_needs_screen_off flag in order to differentiate between HASWELL/BROADWELL and AT_LEAST_GEN9. GEN9 onwards PC8+ residency does't require display to be turned on.

Why are we so fixated on pc8? Shouldn't we just check that we reach the max package c-state with displays off?

pc8_plus_residency_changed() do check pc8 || pc9 || pc10. though subtest is not failing if max PC9 or PC10 is not reached.

As of now most of CI gen9 (with PCH) platforms are failing to reach pc8 itself with display off.

IMHO we should add this coverage of max package C state or even s0ix, once pc8 passed on these failing platforms, what is your opinion about it.

I have added a DEBUG patch with this series to setup powertop and to collect PMC sysfs entries logs in order get root cause of pc8 failures.

Thanks ,
Anshuman Gupta.

Quoted 47 lines
Quoted 47 lines

v3:Removed pc8_needs_screen_off from mode_set_data structure,
made it global, aligning to has_pc8 and has_runtime_pm globals. [Ram] Made modeset_subtest() to tests PC8+ residency after enabling a screen, earlier it expects PC8+ residency to stop on HSW/BDW.

v4:Fixed conditional code for pc8_needs_screen_off. [Ram]
Used macros for timeout values, given to PC8+ residency check function. [Ram] Changed the screen on timeout to check pc8+ residency to 10 seconds.

---
  tests/i915/i915_pm_rpm.c | 10 ++++++++--
  1 file changed, 8 insertions(+), 2 deletions(-)
tests/i915/i915_pm_rpm.c +8 -2
index 9315dbd..bd13d21 100644
@@ -907,7 +907,7 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
  		if (wait_flags & WAIT_STATUS)
  			igt_assert(wait_for_suspended());
  		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(pc8_plus_residency_changed(30));
+			igt_assert(pc8_plus_residency_changed(TIME_OUT_SEC_30));
  		if (wait_flags & WAIT_EXTRA)
  			sleep(5);
 
@@ -917,7 +917,13 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
  		if (wait_flags & WAIT_STATUS)
  			igt_assert(wait_for_active());
  		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(!pc8_plus_residency_changed(5));
+			if (pc8_needs_screen_off)
+				igt_assert(!pc8_plus_residency_changed
+					   (TIME_OUT_SEC_5));
+			else
+				igt_assert(pc8_plus_residency_changed
+					   (TIME_OUT_SEC_10));
+
  		if (wait_flags & WAIT_EXTRA)
  			sleep(5);
  	}
Signature · 1 line
2.7.4
Quoted 5 lines
Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#6 lore raw

Re: [igt-dev] [PATCH i-g-t v6 2/4] tests/i915/i915_pm_rpm: modeset-pc8-residency-stress

In reply to Anshuman Gupta
Quoted 23 lines · Anshuman Gupta

Introduced pc8_needs_screen_off flag in order to differentiate between HASWELL/BROADWELL and AT_LEAST_GEN9. GEN9 onwards PC8+ residency does't require display to be turned on.

v3:Removed pc8_needs_screen_off from mode_set_data structure,
made it global, aligning to has_pc8 and has_runtime_pm globals. [Ram] Made modeset_subtest() to tests PC8+ residency after enabling a screen, earlier it expects PC8+ residency to stop on HSW/BDW.

v4:Fixed conditional code for pc8_needs_screen_off. [Ram]
Used macros for timeout values, given to PC8+ residency check function. [Ram] Changed the screen on timeout to check pc8+ residency to 10 seconds.

---
 tests/i915/i915_pm_rpm.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
tests/i915/i915_pm_rpm.c +0 -0
index 9315dbd..bd13d21 100644

tests/i915/i915_pm_rpm.c static void modeset_subtest(enum screen_type type, int rounds, int wait_flags) · line 910

Quoted 5 lines
tests/i915/i915_pm_rpm.c +1 -1
@@ -907,7 +907,7 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 		if (wait_flags & WAIT_STATUS)
 			igt_assert(wait_for_suspended());
 		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(pc8_plus_residency_changed(30));
+			igt_assert(pc8_plus_residency_changed(TIME_OUT_SEC_30));

Same as previous patch, if this change is needed, this change should move into separate patch.

-Ram

Quoted 21 lines
tests/i915/i915_pm_rpm.c +7 -1
 		if (wait_flags & WAIT_EXTRA)
 			sleep(5);
 
@@ -917,7 +917,13 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 		if (wait_flags & WAIT_STATUS)
 			igt_assert(wait_for_active());
 		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(!pc8_plus_residency_changed(5));
+			if (pc8_needs_screen_off)
+				igt_assert(!pc8_plus_residency_changed
+					   (TIME_OUT_SEC_5));
+			else
+				igt_assert(pc8_plus_residency_changed
+					   (TIME_OUT_SEC_10));
+
 		if (wait_flags & WAIT_EXTRA)
 			sleep(5);
 	}
Signature · 1 line
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#7 lore raw

PATCH v6 3/4 DEBUG: invoke powertop and pmc ltr_ignore when pc8 tests fails.

In reply to Anshuman Gupta

When pc8_ residency test fails, try pc8 residency subtest after setting powertop --auto-tune and further try sub-test with pmc ltr_ignore attributes.

---
 tests/i915/i915_pm_rpm.c | 137 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 136 insertions(+), 1 deletion(-)
tests/i915/i915_pm_rpm.c +136 -1
index bd13d21..804e80f 100644
@@ -100,6 +100,37 @@ int drm_fd, msr_fd, pc8_status_fd;
 int debugfs;
 bool has_runtime_pm, has_pc8, pc8_needs_screen_off;
 struct mode_set_data ms_data;
+int pmc_debugfs, max_ltr;
+bool pmc_loaded;
+
+#define ICL_MAX_LTR 20
+#define CNL_MAX_LTR 19
+#define SKL_MAX_LTR 17
+#define SIZE_PCH_IP_ARR 21
+
+const char *pch_ip[SIZE_PCH_IP_ARR] = {
+	"SOUTHPORT_A",
+	"SOUTHPORT_B",
+	"SATA",
+	"GIGABIT_ETHERNET",
+	"XHCI",
+	"Reserved",
+	"ME",
+	"EVA",
+	"SOUTHPORT_C",
+	"HD_AUDIO",
+	"CNV",
+	"LPSS",
+	"SOUTHPORT_D",
+	"SOUTHPORT_E",
+	"CAMERA",
+	"ESPI",
+	"SCC",
+	"ISH",
+	"UFSX2",
+	"EMMC",
+	"WIGIG"
+};
 
 /* Stuff used when creating FBs and mode setting. */
 struct mode_set_data {
@@ -777,6 +808,69 @@ static void setup_pc8(void)
 	has_pc8 = true;
 }
 
+static void pmc_ignore_ltr(int ip)
+{
+	char tmp[10];
+	int len, fd;
+
+	if (!pmc_loaded)
+		return;
+
+	len = snprintf(tmp, sizeof(tmp), "%d", ip);
+	fd = openat(pmc_debugfs, "ltr_ignore", O_WRONLY);
+	if (fd >= 0) {
+		igt_assert_eq(write(fd, tmp, len), len);
+		close(fd);
+	}
+}
+
+static bool setup_powertop(void)
+{
+	FILE *fp;
+	char tmp[512];
+
+	fp = popen("powertop --auto-tune", "r");
+	if (fp == NULL) {
+		igt_info("Failed to run powertop\n");
+		perror("popen");
+		return false;
+	}
+
+	while (fgets(tmp, sizeof(tmp), fp) != NULL)
+		igt_info("%s\n", tmp);
+
+	pclose(fp);
+	return true;
+}
+
+static bool setup_pmc(void)
+{
+	const char *debugfs_root;
+	char path[200];
+
+	/* Make sure our intel_pmc_core module is loaded. */
+	pmc_loaded = modprobe("intel_pmc_core") == 0;
+
+	if (!pmc_loaded) {
+		igt_info("intel_pmc_core module not loaded\n");
+		return;
+	}
+
+	if (IS_ICELAKE(ms_data.devid))
+		max_ltr = ICL_MAX_LTR;
+	else if (IS_CANNONLAKE(ms_data.devid))
+		max_ltr = CNL_MAX_LTR;
+	else if (AT_LEAST_GEN(ms_data.devid, 9) && !IS_BROXTON(ms_data.devid) &&
+		 !IS_GEMINILAKE(ms_data.devid))
+		max_ltr = SKL_MAX_LTR;
+
+	debugfs_root = igt_debugfs_mount();
+	igt_assert(debugfs_root);
+	snprintf(path, sizeof(path), "%s/pmc_core", debugfs_root);
+	pmc_debugfs = open(path, O_RDONLY);
+	igt_require(pmc_debugfs != -1);
+}
+
 static bool dmc_loaded(void)
 {
 	char buf[15];
@@ -804,6 +898,14 @@ static void dump_file(int dir, const char *filename)
 	free(contents);
 }
 
+static void pmc_dump_file(int fd, const char *file)
+{
+	if (!pmc_loaded)
+		return;
+
+	dump_file(fd, file);
+}
+
 static bool setup_environment(void)
 {
 	if (has_runtime_pm)
@@ -821,6 +923,7 @@ static bool setup_environment(void)
 	pm_data = igt_pm_enable_sata_link_power_management();
 
 	has_runtime_pm = igt_setup_runtime_pm();
+	setup_pmc();
 	setup_pc8();
 
 	igt_info("Runtime PM support: %d\n", has_runtime_pm);
@@ -866,11 +969,43 @@ static void basic_subtest(void)
 
 static void pc8_residency_subtest(void)
 {
+	bool passed;
+	int i;
 	igt_require(has_pc8);
 
 	/* Make sure PC8+ residencies move! */
 	disable_all_screens(&ms_data);
-	igt_assert_f(pc8_plus_residency_changed(TIME_OUT_SEC_30),
+	passed = pc8_plus_residency_changed(TIME_OUT_SEC_30);
+
+	/* Try With powertop --auto-tune */
+	if (!passed) {
+		igt_info("pc8+ residencies before powertop --auto-tune\n");
+		pmc_dump_file(pmc_debugfs, "package_cstate_show");
+		igt_require(setup_powertop());
+		passed = pc8_plus_residency_changed(TIME_OUT_SEC_10);
+
+		if (!passed) {
+			igt_info("pc8+ residencies after powertop --auto-tune\n");
+			pmc_dump_file(pmc_debugfs, "package_cstate_show");
+		} else {
+			igt_info("pc8+ residencies subtest passed "
+				 "after running powertop --auto-tune\n");
+		}
+	}
+	/* Try after ignoreing ltr */
+	if (!passed) {
+		pmc_dump_file(pmc_debugfs, "ltr_show");
+		for (i = 0; i <= max_ltr; i++) {
+			pmc_ignore_ltr(i);
+			passed = pc8_plus_residency_changed(TIME_OUT_SEC_10);
+			if (passed) {
+				igt_info("pc8+ residencies subtest passed "
+					 "after ignoring %s ltr\n", pch_ip[i]);
+				break;
+			}
+		}
+	}
+	igt_assert_f(passed,
 		     "Machine is not reaching PC8+ states, please check its "
 		     "configuration.\n");
 
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#8 lore raw

PATCH v6 4/4 DO_NOT_MERGE: adding i915_pm_rpm pc8 subtest to fast feedback list.

In reply to Anshuman Gupta

Forcing CI to test below sub-test on ICL.
pc8-residency
modeset-pc8-residency-stress
gem-execbuf-stress-pc8

---
 tests/intel-ci/fast-feedback.testlist | 3 +++
 1 file changed, 3 insertions(+)
tests/intel-ci/fast-feedback.testlist +3 -0
index 40475b1..f54811c 100644
@@ -218,6 +218,9 @@ igt@kms_setmode@basic-clone-single-crtc
 igt@i915_pm_backlight@basic-brightness
 igt@i915_pm_rpm@basic-pci-d3-state
 igt@i915_pm_rpm@basic-rte
+igt@i915_pm_rpm@gem-execbuf-stress-pc8
+igt@i915_pm_rpm@modeset-pc8-residency-stress
+igt@i915_pm_rpm@pc8-residency
 igt@i915_pm_rps@basic-api
 igt@prime_busy@basic-after-default
 igt@prime_busy@basic-before-default
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#9 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for Enabling PC8+ residency for all GEN9+ platforms (rev6)

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: Enabling PC8+ residency for all GEN9+ platforms (rev6)
URL : https://patchwork.freedesktop.org/series/57640/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6007 -> IGTPW_2931
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2931 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2931, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/57640/revisions/6/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2931:

### IGT changes ###

#### Possible regressions ####

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- fi-kbl-8809g: NOTRUN -> [FAIL][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-kbl-8809g/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- fi-skl-6600u: NOTRUN -> [FAIL][2] +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-skl-6600u/igt@[email protected]
- fi-kbl-7567u: NOTRUN -> [FAIL][3] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-kbl-7567u/igt@[email protected]
- fi-kbl-8809g: NOTRUN -> [TIMEOUT][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-kbl-8809g/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_2931 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-hsw-4770r: [PASS][5] -> [SKIP][6] ([fdo#109271]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-hsw-4770r/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-hsw-4770r/igt@[email protected]
- fi-hsw-peppy: [PASS][7] -> [SKIP][8] ([fdo#109271]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-hsw-peppy/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-hsw-peppy/igt@[email protected]
- fi-bdw-5557u: [PASS][9] -> [SKIP][10] ([fdo#109271]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-bdw-5557u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-bdw-5557u/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-byt-clapper: [PASS][11] -> [SKIP][12] ([fdo#109271]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-byt-clapper/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-byt-clapper/igt@[email protected]
- fi-byt-j1900: [PASS][13] -> [SKIP][14] ([fdo#109271]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-byt-j1900/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-byt-j1900/igt@[email protected]
- fi-bxt-j4205: [PASS][15] -> [SKIP][16] ([fdo#109271]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-bxt-j4205/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-bxt-j4205/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271

Participating hosts (38 -> 27)
------------------------------

Missing (11): fi-ilk-m540 fi-bxt-dsi fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-whl-u fi-cfl-8109u fi-bsw-kefka fi-skl-lmem fi-byt-n2820

Build changes
-------------

* IGT: IGT_4968 -> IGTPW_2931

CI_DRM_6007: 846376257e91f6e49cf7d6b59b0a6cbb0ce7cd53 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2931: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/
IGT_4968: caed251990f35bfe45368f803980071a73e36315 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#10 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for Enabling PC8+ residency for all GEN9+ platforms (rev6)

Hi Martin ,

Could you please filter out the below dmesg-warning

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-kbl-8809g/igt@[email protected]

This causes CI to stop the BAT test, i have added pmc debug logs in order to get pc8+ subtest failures root cause. Can we complete the CI BAT test with this series.

Thanks ,
Anshuman Gupta.

Quoted 25 lines · Patchwork

====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2931 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2931, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL:https://patchwork.freedesktop.org/api/1.0/series/57640/revisions/6/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2931:

### IGT changes ###

#### Possible regressions ####

Quoted 7 lines

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- fi-kbl-8809g: NOTRUN -> [FAIL][1] +1 similar issue
[1]:https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-kbl-8809g/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- fi-skl-6600u: NOTRUN -> [FAIL][2] +2 similar issues
[2]:https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-skl-66

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#11 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for Enabling PC8+ residency for all GEN9+ platforms (rev6)

Quoted 9 lines · Anshuman

Hi Martin ,

Could you please filter out the below dmesg-warning

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-kbl-8809g/igt@[email protected]

This causes CI to stop the BAT test, i have added pmc debug logs in order to get pc8+ subtest failures root cause. Can we complete the CI BAT test with this series.

Done: https://patchwork.freedesktop.org/series/57640/#rev6

I created 3 bugs:

- https://bugs.freedesktop.org/show_bug.cgi?id=110547
- https://bugs.freedesktop.org/show_bug.cgi?id=110548
- https://bugs.freedesktop.org/show_bug.cgi?id=110549

Thanks a lot for doing this!

Martin

Quoted 38 lines

Thanks ,
Anshuman Gupta.

Quoted 32 lines · Patchwork

====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2931 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2931, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL:https://patchwork.freedesktop.org/api/1.0/series/57640/revisions/6/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2931:

### IGT changes ###

#### Possible regressions ####

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- fi-kbl-8809g: NOTRUN -> [FAIL][1] +1 similar issue
[1]:https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-kbl-8809g/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- fi-skl-6600u: NOTRUN -> [FAIL][2] +2 similar issues
[2]:https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-skl-66

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#12 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Enabling PC8+ residency for all GEN9+ platforms (rev6)

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: Enabling PC8+ residency for all GEN9+ platforms (rev6)
URL : https://patchwork.freedesktop.org/series/57640/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6007 -> IGTPW_2931
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/57640/revisions/6/mbox/

Known issues
------------

Here are the changes found in IGTPW_2931 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-hsw-4770r: [PASS][1] -> [SKIP][2] ([fdo#109271]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-hsw-4770r/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-hsw-4770r/igt@[email protected]
- fi-hsw-peppy: [PASS][3] -> [SKIP][4] ([fdo#109271]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-hsw-peppy/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-hsw-peppy/igt@[email protected]
- fi-bdw-5557u: [PASS][5] -> [SKIP][6] ([fdo#109271]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-bdw-5557u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-bdw-5557u/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-byt-clapper: [PASS][7] -> [SKIP][8] ([fdo#109271]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-byt-clapper/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-byt-clapper/igt@[email protected]
- fi-byt-j1900: [PASS][9] -> [SKIP][10] ([fdo#109271]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-byt-j1900/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-byt-j1900/igt@[email protected]
- fi-bxt-j4205: [PASS][11] -> [SKIP][12] ([fdo#109271]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/fi-bxt-j4205/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/fi-bxt-j4205/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271

Participating hosts (38 -> 27)
------------------------------

Missing (11): fi-ilk-m540 fi-bxt-dsi fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-whl-u fi-cfl-8109u fi-bsw-kefka fi-skl-lmem fi-byt-n2820

Build changes
-------------

* IGT: IGT_4968 -> IGTPW_2931

CI_DRM_6007: 846376257e91f6e49cf7d6b59b0a6cbb0ce7cd53 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2931: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/
IGT_4968: caed251990f35bfe45368f803980071a73e36315 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#13 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for Enabling PC8+ residency for all GEN9+ platforms (rev6)

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: Enabling PC8+ residency for all GEN9+ platforms (rev6)
URL : https://patchwork.freedesktop.org/series/57640/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6007_full -> IGTPW_2931_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2931_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2931_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/57640/revisions/6/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2931_full:

### IGT changes ###

#### Possible regressions ####

* igt@runner@aborted:
- shard-snb: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-snb1/igt@[email protected]
- shard-iclb: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb7/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: [SKIP][3] ([fdo#109506]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb2/igt@[email protected]

* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-iclb: [SKIP][5] ([fdo#109293]) -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb6/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- shard-iclb: [SKIP][7] ([fdo#109293]) -> [DMESG-FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb8/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_2931_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ringfill@basic-default-hang:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([fdo#107713])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb1/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#108686])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb7/igt@[email protected]
- shard-hsw: [PASS][13] -> [FAIL][14] ([fdo#108686])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-hsw5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-hsw2/igt@[email protected]

* igt@i915_pm_rpm@fences-dpms:
- shard-apl: [PASS][15] -> [SKIP][16] ([fdo#109271]) +33 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-apl5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-apl1/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress:
- shard-glk: [PASS][17] -> [SKIP][18] ([fdo#109271]) +32 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-glk5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-glk2/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-hsw: [PASS][19] -> [SKIP][20] ([fdo#109271]) +32 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-hsw1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-hsw2/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([fdo#108566]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-apl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-apl3/igt@[email protected]

* igt@kms_cursor_crc@cursor-128x42-random:
- shard-apl: [PASS][23] -> [FAIL][24] ([fdo#103232])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-apl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-apl3/igt@[email protected]
- shard-kbl: [PASS][25] -> [FAIL][26] ([fdo#103232])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-kbl6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-kbl4/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109349])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-onoff:
- shard-glk: [PASS][29] -> [FAIL][30] ([fdo#103167])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-glk9/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-glk5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +6 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb7/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb6/igt@kms_psr@psr2_no_drrs.html

* igt@tools_test@tools_test:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109352])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb8/igt@tools_test@tools_test.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb1/igt@tools_test@tools_test.html

#### Possible fixes ####

* igt@i915_pm_rps@min-max-config-idle:
- shard-apl: [INCOMPLETE][39] ([fdo#103927]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-apl6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-apl2/igt@[email protected]

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-snb: [SKIP][41] ([fdo#109271] / [fdo#109278]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-snb6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-snb5/igt@[email protected]

* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-kbl: [FAIL][43] ([fdo#109350]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-kbl3/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-kbl4/igt@[email protected]
- shard-apl: [FAIL][45] ([fdo#109350]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-apl6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-apl2/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][47] ([fdo#105767]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-hsw6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-hsw5/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][49] ([fdo#102887] / [fdo#105363]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-glk1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-glk6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render:
- shard-iclb: [FAIL][51] ([fdo#103167]) -> [PASS][52] +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render.html

* igt@kms_plane_cursor@pipe-b-overlay-size-256:
- shard-snb: [SKIP][53] ([fdo#109271]) -> [PASS][54] +5 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-snb6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-snb4/igt@[email protected]

* igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
- shard-glk: [SKIP][55] ([fdo#109271] / [fdo#109278]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-glk2/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-glk9/igt@[email protected]

* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][57] ([fdo#108341]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb1/igt@kms_psr@no_drrs.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb7/igt@kms_psr@no_drrs.html

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-iclb1/igt@kms_psr@psr2_cursor_plane_onoff.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

* igt@kms_setmode@basic:
- shard-kbl: [FAIL][61] ([fdo#99912]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-kbl7/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-kbl3/igt@[email protected]

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][63] ([fdo#108566]) -> [PASS][64] +6 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-apl3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-apl6/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-kbl: [SKIP][65] ([fdo#109271]) -> [FAIL][66] ([fdo#110548]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-kbl3/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-kbl3/igt@[email protected]

* igt@i915_pm_rpm@pc8-residency:
- shard-kbl: [SKIP][67] ([fdo#109271]) -> [FAIL][68] ([fdo#110547])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6007/shard-kbl3/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/shard-kbl5/igt@[email protected]

[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110547]: https://bugs.freedesktop.org/show_bug.cgi?id=110547
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (10 -> 6)
------------------------------

Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005

Build changes
-------------

* IGT: IGT_4968 -> IGTPW_2931
* Piglit: piglit_4509 -> None

CI_DRM_6007: 846376257e91f6e49cf7d6b59b0a6cbb0ce7cd53 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2931: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/
IGT_4968: caed251990f35bfe45368f803980071a73e36315 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2931/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev