thermal/drivers/cpu_cooling: Fixup the header and copyright
PATCH RESEND 1/3 thermal/drivers/cpu_cooling: Fixup the header and copyright
The copyright format does not conform to the format requested by
Linaro: https://wiki.linaro.org/Copyright
Fix it.
Viresh Kumar <[email protected]>
--- drivers/thermal/cpu_cooling.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/thermal/cpu_cooling.c +4 -2
@@ -2,9 +2,11 @@* linux/drivers/thermal/cpu_cooling.c * * Copyright (C) 2012 Samsung Electronics Co., Ltd(http://www.samsung.com) -* Copyright (C) 2012 Amit Daniel <[email protected]> * -* Copyright (C) 2014 Viresh Kumar <[email protected]> +* Copyright (C) 2012-2018 Linaro Limited. +* +* Authors: Amit Daniel <[email protected]> +* Viresh Kumar <[email protected]> * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * This program is free software; you can redistribute it and/or modify
Signature · 1 line
2.17.1
PATCH RESEND 2/3 thermal/drivers/cpu_cooling: Add Software Package Data Exchange (SPDX)
For license auditing purpose, let's add the SPDX tag.
--- drivers/thermal/cpu_cooling.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)
drivers/thermal/cpu_cooling.c +1 -15
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * linux/drivers/thermal/cpu_cooling.c *
@@ -8,21 +9,6 @@* Authors: Amit Daniel <[email protected]> * Viresh Kumar <[email protected]> * -* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; version 2 of the License. -* -* This program is distributed in the hope that it will be useful, but -* WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -* General Public License for more details. -* -* You should have received a copy of the GNU General Public License along -* with this program; if not, write to the Free Software Foundation, Inc., -* 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA. -* -* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ #include <linux/module.h> #include <linux/thermal.h>
Signature · 1 line
2.17.1
PATCH RESEND 3/3 thermal/drivers/cpu_cooling: Remove pointless field
In reply to Daniel LezcanoThe structure cpufreq_cooling_device provides a backpointer to the thermal device but this one is used for a trace and to unregister. For the trace, we don't really need this field and the unregister function as the same pointer passed as parameter. Remove it.
--- drivers/thermal/cpu_cooling.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/thermal/cpu_cooling.c +2 -5
@@ -87,7 +87,6 @@ struct cpufreq_cooling_device {unsigned int clipped_freq;unsigned int max_level;struct freq_table *freq_table;/* In descending order */ -struct thermal_cooling_device *cdev;struct cpufreq_policy *policy;struct list_head node;struct time_in_idle *idle_time;
@@ -195,8 +194,7 @@ static int update_freq_table(struct cpufreq_cooling_device *cpufreq_cdev, dev =get_cpu_device (cpu);if (unlikely (!dev)) { -dev_warn (&cpufreq_cdev->cdev->device, -"No cpu device for cpu %d\n" , cpu); +pr_warn ("No cpu device for cpu %d\n" , cpu);return -ENODEV ; }
@@ -679,7 +677,6 @@ __cpufreq_cooling_register(struct device_node *np, goto remove_ida; cpufreq_cdev->clipped_freq = cpufreq_cdev->freq_table[0 ].frequency; - cpufreq_cdev->cdev = cdev;mutex_lock (&cooling_list_lock);/* Register the notifier for first cpufreq cooling device */
@@ -797,7 +794,7 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev)cpufreq_unregister_notifier (&thermal_cpufreq_notifier_block,CPUFREQ_POLICY_NOTIFIER ); -thermal_cooling_device_unregister (cpufreq_cdev->cdev); +thermal_cooling_device_unregister (cdev);ida_simple_remove (&cpufreq_ida, cpufreq_cdev->id);kfree (cpufreq_cdev->idle_time);kfree (cpufreq_cdev->freq_table);
Signature · 1 line
2.17.1
Quoted 7 lines · Daniel Lezcano
The copyright format does not conform to the format requested by
Linaro: https://wiki.linaro.org/CopyrightFix it.
Signed-off-by Daniel Lezcano <[email protected]>Viresh Kumar <[email protected]>
What exactly have I done here ? :)
Quoted 24 lines
--- drivers/thermal/cpu_cooling.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/thermal/cpu_cooling.c +4
-2@@ -2,9 +2,11 @@* linux/drivers/thermal/cpu_cooling.c * * Copyright (C) 2012 Samsung Electronics Co., Ltd(http://www.samsung.com) -* Copyright (C) 2012 Amit Daniel <[email protected]> * -* Copyright (C) 2014 Viresh Kumar <[email protected]> +* Copyright (C) 2012-2018 Linaro Limited. +* +* Authors: Amit Daniel <[email protected]> +* Viresh Kumar <[email protected]> * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * This program is free software; you can redistribute it and/or modify Signature · 1 line
2.17.1
Signature · 1 line
viresh
Quoted 10 lines · Viresh Kumar
Quoted 7 lines · Daniel Lezcano
The copyright format does not conform to the format requested by
Linaro: https://wiki.linaro.org/CopyrightFix it.
Signed-off-by Daniel Lezcano <[email protected]>Viresh Kumar <[email protected]>
What exactly have I done here ? :)
Argh!
Thanks for spotting it.
Quoted 25 lines
Quoted 24 lines
--- drivers/thermal/cpu_cooling.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/thermal/cpu_cooling.c +4
-2@@ -2,9 +2,11 @@* linux/drivers/thermal/cpu_cooling.c * * Copyright (C) 2012 Samsung Electronics Co., Ltd(http://www.samsung.com) -* Copyright (C) 2012 Amit Daniel <[email protected]> * -* Copyright (C) 2014 Viresh Kumar <[email protected]> +* Copyright (C) 2012-2018 Linaro Limited. +* +* Authors: Amit Daniel <[email protected]> +* Viresh Kumar <[email protected]> * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * This program is free software; you can redistribute it and/or modify Signature · 1 line
2.17.1
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
PATCH RESEND 1/1 thermal/drivers/cpu_cooling: Fixup the header and copyright
In reply to Viresh KumarThe copyright format does not conform to the format requested by
Linaro: https://wiki.linaro.org/Copyright
Fix it.
--- drivers/thermal/cpu_cooling.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/thermal/cpu_cooling.c +4 -2
@@ -2,9 +2,11 @@* linux/drivers/thermal/cpu_cooling.c * * Copyright (C) 2012 Samsung Electronics Co., Ltd(http://www.samsung.com) -* Copyright (C) 2012 Amit Daniel <[email protected]> * -* Copyright (C) 2014 Viresh Kumar <[email protected]> +* Copyright (C) 2012-2018 Linaro Limited. +* +* Authors: Amit Daniel <[email protected]> +* Viresh Kumar <[email protected]> * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * This program is free software; you can redistribute it and/or modify
Signature · 1 line
2.17.1
Eduardo Valentin
AppliedQuoted 7 lines · Daniel Lezcano
The copyright format does not conform to the format requested by
Linaro: https://wiki.linaro.org/CopyrightFix it.
Signed-off-by Daniel Lezcano <[email protected]>Viresh Kumar <[email protected]>
Based on the series and other patches of it, I am assuming this is an Acked-by..
Applied as Acked-by.
Quoted 22 lines
--- drivers/thermal/cpu_cooling.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/thermal/cpu_cooling.c +4
-2@@ -2,9 +2,11 @@* linux/drivers/thermal/cpu_cooling.c * * Copyright (C) 2012 Samsung Electronics Co., Ltd(http://www.samsung.com) -* Copyright (C) 2012 Amit Daniel <[email protected]> * -* Copyright (C) 2014 Viresh Kumar <[email protected]> +* Copyright (C) 2012-2018 Linaro Limited. +* +* Authors: Amit Daniel <[email protected]> +* Viresh Kumar <[email protected]> * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * This program is free software; you can redistribute it and/or modify