Skip to contentSkip to conversation

lib/audio: Fix compiler error with missing permsisions to O_CREAT.

PATCH In review Maarten Lankhorst 3 participants 4 messages Apr 29, 2019 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/audio: Fix compiler error with missing permsisions to O_CREAT.

In file included from /usr/include/fcntl.h:290:0,

                 from ../../lib/igt_audio.c:30:
In function ‘open’,
    inlined from ‘audio_create_wav_file_s32_le’ at igt_audio.c:450:5:
/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to
	‘__open_missing_mode’ declared with attribute error: open with
	O_CREAT or O_TMPFILE in second argument needs 3 arguments
    __open_missing_mode ();
    ^~~~~~~~~~~~~~~~~~~~~~
---
 lib/igt_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_audio.c +1 -1
index 5b0860e6cc76..fd8cf07c0de3 100644
@@ -447,7 +447,7 @@ int audio_create_wav_file_s32_le(const char *qualifier, uint32_t sample_rate,
 		*path = strdup(_path);
 
 	igt_debug("Dumping %s audio to %s\n", qualifier, _path);
-	fd = open(_path, O_WRONLY | O_CREAT | O_TRUNC);
+	fd = open(_path, O_WRONLY | O_CREAT | O_TRUNC, 0644);
 	if (fd < 0) {
 		igt_warn("open failed: %s\n", strerror(errno));
 		return -1;
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw
Quoted 10 lines · Maarten Lankhorst

In file included from /usr/include/fcntl.h:290:0,

                 from ../../lib/igt_audio.c:30:
In function ‘open’,
    inlined from ‘audio_create_wav_file_s32_le’ at igt_audio.c:450:5:
/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:4: error: call to
	‘__open_missing_mode’ declared with attribute error: open with
	O_CREAT or O_TMPFILE in second argument needs 3 arguments
    __open_missing_mode ();
    ^~~~~~~~~~~~~~~~~~~~~~
Quoted 3 lines

Duplicate of https://lists.freedesktop.org/archives/igt-dev/2019-April/012642.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/audio: Fix compiler error with missing permsisions to O_CREAT.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: lib/audio: Fix compiler error with missing permsisions to O_CREAT.
URL : https://patchwork.freedesktop.org/series/60038/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6011 -> IGTPW_2932
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/60038/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2932:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- {fi-cml-u2}: NOTRUN -> [SKIP][1] +36 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/fi-cml-u2/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_2932 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][2] -> [INCOMPLETE][3] ([fdo#107718])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/fi-blb-e6850/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/fi-blb-e6850/igt@[email protected]

* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [PASS][4] -> [INCOMPLETE][5] ([fdo#107713] / [fdo#108569])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/fi-icl-y/igt@i915_selftest@live_hangcheck.html

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: [PASS][6] -> [FAIL][7] ([fdo#103191])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/fi-byt-clapper/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/fi-byt-clapper/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [INCOMPLETE][8] ([fdo#107807]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/fi-skl-lmem/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/fi-skl-lmem/igt@[email protected]

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [DMESG-FAIL][10] ([fdo#110235 ]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

* igt@i915_selftest@live_evict:
- fi-bsw-kefka: [DMESG-WARN][12] ([fdo#107709]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/fi-bsw-kefka/igt@i915_selftest@live_evict.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/fi-bsw-kefka/igt@i915_selftest@live_evict.html

* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: [FAIL][14] ([fdo#103191]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/fi-byt-clapper/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/fi-byt-clapper/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235

Participating hosts (50 -> 45)
------------------------------

Additional (2): fi-cml-u2 fi-cml-u
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-dsi fi-bdw-samus

Build changes
-------------

* IGT: IGT_4968 -> IGTPW_2932

CI_DRM_6011: 5d3d1107f2736678581c71c7cf3d94e6424f4e6c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2932: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/
IGT_4968: caed251990f35bfe45368f803980071a73e36315 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for lib/audio: Fix compiler error with missing permsisions to O_CREAT.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: lib/audio: Fix compiler error with missing permsisions to O_CREAT.
URL : https://patchwork.freedesktop.org/series/60038/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6011_full -> IGTPW_2932_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2932_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2932_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/60038/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2932_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_legacy@nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-glk9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-glk2/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_2932_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: [PASS][3] -> [FAIL][4] ([fdo#108686])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-iclb8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-iclb5/igt@[email protected]
- shard-hsw: [PASS][5] -> [FAIL][6] ([fdo#108686])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-hsw5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-hsw7/igt@[email protected]

* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: [PASS][7] -> [FAIL][8] ([fdo#103232])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-apl2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-apl1/igt@[email protected]
- shard-kbl: [PASS][9] -> [FAIL][10] ([fdo#103232])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-kbl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-kbl1/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][11] -> [FAIL][12] ([fdo#104873])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-glk6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-glk5/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109349])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-iclb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-iclb1/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][15] -> [FAIL][16] ([fdo#105363])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-glk5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-glk9/igt@[email protected]

* igt@kms_flip@flip-vs-modeset-interruptible:
- shard-hsw: [PASS][17] -> [DMESG-WARN][18] ([fdo#102614])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-hsw8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-hsw5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103167]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-iclb2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-iclb2/igt@[email protected]

* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: [PASS][21] -> [SKIP][22] ([fdo#109271])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-glk9/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-glk7/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-iclb7/igt@kms_psr@psr2_no_drrs.html

* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: [PASS][25] -> [DMESG-FAIL][26] ([fdo#105763])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-kbl1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-kbl3/igt@[email protected]

* igt@kms_setmode@basic:
- shard-kbl: [PASS][27] -> [FAIL][28] ([fdo#99912])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-kbl3/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-kbl2/igt@[email protected]

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-apl2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-apl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_mmap_gtt@basic-small-copy-xy:
- shard-apl: [INCOMPLETE][31] ([fdo#103927]) -> [PASS][32] +4 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-apl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-apl8/igt@[email protected]

* igt@gem_workarounds@suspend-resume:
- shard-apl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-apl7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-apl3/igt@[email protected]

* igt@kms_busy@extended-modeset-hang-oldfb-render-c:
- shard-iclb: [INCOMPLETE][35] ([fdo#107713]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-iclb1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-iclb3/igt@[email protected]

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-snb: [SKIP][37] ([fdo#109271] / [fdo#109278]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-snb2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-snb4/igt@[email protected]

* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: [FAIL][39] ([fdo#109350]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-apl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-apl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: [FAIL][41] ([fdo#103167]) -> [PASS][42] +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-iclb2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-iclb: [FAIL][43] ([fdo#103167] / [fdo#110378]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-iclb2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-iclb5/igt@[email protected]

* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-glk: [SKIP][45] ([fdo#109271]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-glk5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-glk9/igt@[email protected]

* igt@kms_plane_cursor@pipe-b-overlay-size-256:
- shard-snb: [SKIP][47] ([fdo#109271]) -> [PASS][48] +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-snb2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-snb7/igt@[email protected]

* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][49] ([fdo#109441]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-iclb4/igt@kms_psr@psr2_dpms.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-iclb2/igt@kms_psr@psr2_dpms.html

* igt@kms_setmode@basic:
- shard-apl: [FAIL][51] ([fdo#99912]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-apl8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-apl4/igt@[email protected]

#### Warnings ####

* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd2:
- shard-apl: [INCOMPLETE][53] ([fdo#103927]) -> [SKIP][54] ([fdo#109271])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6011/shard-apl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/shard-apl3/igt@[email protected]

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (10 -> 6)
------------------------------

Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005

Build changes
-------------

* IGT: IGT_4968 -> IGTPW_2932
* Piglit: piglit_4509 -> None

CI_DRM_6011: 5d3d1107f2736678581c71c7cf3d94e6424f4e6c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2932: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/
IGT_4968: caed251990f35bfe45368f803980071a73e36315 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2932/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev