Skip to contentSkip to conversation

stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

PATCH New Petr Mladek 1 participant 1 message Apr 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. The only current user klp_check_stack() writes its own warning when -ENOSYS is returned.

---
 kernel/stacktrace.c | 1 -
 1 file changed, 1 deletion(-)
kernel/stacktrace.c +0 -1
index f8edee9c792d..83ac0ac5ffd9 100644
@@ -74,6 +74,5 @@ __weak int
 save_stack_trace_tsk_reliable(struct task_struct *tsk,
 			      struct stack_trace *trace)
 {
-	WARN_ONCE(1, KERN_INFO "save_stack_tsk_reliable() not implemented yet.\n");
 	return -ENOSYS;
 }
Signature · 1 line
2.16.4