soc: add aspeed folder and misc drivers
Subsystems (2)
PATCH 1/1 soc: add aspeed folder and misc drivers
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs.
---
drivers/misc/Kconfig | 16 ----------------
drivers/misc/Makefile | 2 --
drivers/soc/Kconfig | 1 +
drivers/soc/Makefile | 1 +
drivers/soc/aspeed/Kconfig | 19 +++++++++++++++++++
drivers/soc/aspeed/Makefile | 2 ++
.../{misc => soc/aspeed}/aspeed-lpc-ctrl.c | 0
.../{misc => soc/aspeed}/aspeed-lpc-snoop.c | 0
8 files changed, 23 insertions(+), 18 deletions(-)
create mode 100644 drivers/soc/aspeed/Kconfig
create mode 100644 drivers/soc/aspeed/Makefile
rename drivers/{misc => soc/aspeed}/aspeed-lpc-ctrl.c (100%)
rename drivers/{misc => soc/aspeed}/aspeed-lpc-snoop.c (100%)drivers/misc/Kconfig +0 -16
@@ -496,22 +496,6 @@ config VEXPRESS_SYSCFG bus. System Configuration interface is one of the possible means of generating transactions on this bus. -config ASPEED_LPC_CTRL - depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON - tristate "Aspeed ast2400/2500 HOST LPC to BMC bridge control" - ---help--- - Control Aspeed ast2400/2500 HOST LPC to BMC mappings through - ioctl()s, the driver also provides a read/write interface to a BMC ram - region where the host LPC read/write region can be buffered. - -config ASPEED_LPC_SNOOP - tristate "Aspeed ast2500 HOST LPC snoop support" - depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON - help - Provides a driver to control the LPC snoop interface which - allows the BMC to listen on and save the data written by - the host to an arbitrary LPC I/O port. - config PCI_ENDPOINT_TEST depends on PCI select CRC32
drivers/misc/Makefile +0 -2
@@ -54,8 +54,6 @@ obj-$(CONFIG_GENWQE) += genwqe/ obj-$(CONFIG_ECHO) += echo/ obj-$(CONFIG_VEXPRESS_SYSCFG) += vexpress-syscfg.o obj-$(CONFIG_CXL_BASE) += cxl/ -obj-$(CONFIG_ASPEED_LPC_CTRL) += aspeed-lpc-ctrl.o -obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o obj-$(CONFIG_PCI_ENDPOINT_TEST) += pci_endpoint_test.o obj-$(CONFIG_OCXL) += ocxl/ obj-y += cardreader/
drivers/soc/Kconfig +1 -0
@@ -2,6 +2,7 @@ menu "SOC (System On Chip) specific Drivers" source "drivers/soc/actions/Kconfig" source "drivers/soc/amlogic/Kconfig" +source "drivers/soc/aspeed/Kconfig" source "drivers/soc/atmel/Kconfig" source "drivers/soc/bcm/Kconfig" source "drivers/soc/fsl/Kconfig"
drivers/soc/Makefile +1 -0
@@ -4,6 +4,7 @@ # obj-$(CONFIG_ARCH_ACTIONS) += actions/ +obj-y += aspeed/ obj-$(CONFIG_ARCH_AT91) += atmel/ obj-y += bcm/ obj-$(CONFIG_ARCH_DOVE) += dove/
drivers/soc/aspeed/Kconfig new file +19 -0
@@ -0,0 +1,19 @@ +menu "Aspeed SoC drivers" + +config ASPEED_LPC_CTRL + depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON + tristate "Aspeed ast2400/2500 HOST LPC to BMC bridge control" + ---help--- + Control Aspeed ast2400/2500 HOST LPC to BMC mappings through + ioctl()s, the driver also provides a read/write interface to a BMC ram + region where the host LPC read/write region can be buffered. + +config ASPEED_LPC_SNOOP + tristate "Aspeed ast2500 HOST LPC snoop support" + depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON + help + Provides a driver to control the LPC snoop interface which + allows the BMC to listen on and save the data written by + the host to an arbitrary LPC I/O port. + +
drivers/soc/aspeed/Makefile new file +2 -0
@@ -0,0 +1,2 @@ +obj-$(CONFIG_ASPEED_LPC_CTRL) += aspeed-lpc-ctrl.o +obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o
drivers/soc/aspeed/aspeed-lpc-ctrl.c renamed from drivers/misc/aspeed-lpc-ctrl.c +0 -0
drivers/soc/aspeed/aspeed-lpc-snoop.c renamed from drivers/misc/aspeed-lpc-snoop.c +0 -0
Signature · 1 line
2.21.0.593.g511ec345e18-goog
Quoted 6 lines · Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs.
Signed-off-by Patrick Venture <[email protected]>
Looks ok, but please resend to arm at kernel.org or soc at kernel.org so we can track the submission and make sure it gets applied if you want this to go through the arm-soc tree.
If Greg wants to pick it up, that's fine too.
Either way,
Quoted 123 lines
--- drivers/misc/Kconfig | 16 ---------------- drivers/misc/Makefile | 2 -- drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/aspeed/Kconfig | 19 +++++++++++++++++++ drivers/soc/aspeed/Makefile | 2 ++ .../{misc => soc/aspeed}/aspeed-lpc-ctrl.c | 0 .../{misc => soc/aspeed}/aspeed-lpc-snoop.c | 0 8 files changed, 23 insertions(+), 18 deletions(-) create mode 100644 drivers/soc/aspeed/Kconfig create mode 100644 drivers/soc/aspeed/Makefile rename drivers/{misc => soc/aspeed}/aspeed-lpc-ctrl.c (100%) rename drivers/{misc => soc/aspeed}/aspeed-lpc-snoop.c (100%)drivers/misc/Kconfig +0
-16@@ -496,22 +496,6 @@ config VEXPRESS_SYSCFG bus. System Configuration interface is one of the possible means of generating transactions on this bus. -config ASPEED_LPC_CTRL - depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON - tristate "Aspeed ast2400/2500 HOST LPC to BMC bridge control" - ---help--- - Control Aspeed ast2400/2500 HOST LPC to BMC mappings through - ioctl()s, the driver also provides a read/write interface to a BMC ram - region where the host LPC read/write region can be buffered. - -config ASPEED_LPC_SNOOP - tristate "Aspeed ast2500 HOST LPC snoop support" - depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON - help - Provides a driver to control the LPC snoop interface which - allows the BMC to listen on and save the data written by - the host to an arbitrary LPC I/O port. - config PCI_ENDPOINT_TEST depends on PCI select CRC32drivers/misc/Makefile +0
-2@@ -54,8 +54,6 @@ obj-$(CONFIG_GENWQE) += genwqe/ obj-$(CONFIG_ECHO) += echo/ obj-$(CONFIG_VEXPRESS_SYSCFG) += vexpress-syscfg.o obj-$(CONFIG_CXL_BASE) += cxl/ -obj-$(CONFIG_ASPEED_LPC_CTRL) += aspeed-lpc-ctrl.o -obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o obj-$(CONFIG_PCI_ENDPOINT_TEST) += pci_endpoint_test.o obj-$(CONFIG_OCXL) += ocxl/ obj-y += cardreader/drivers/soc/Kconfig +1
-0@@ -2,6 +2,7 @@ menu "SOC (System On Chip) specific Drivers" source "drivers/soc/actions/Kconfig" source "drivers/soc/amlogic/Kconfig" +source "drivers/soc/aspeed/Kconfig" source "drivers/soc/atmel/Kconfig" source "drivers/soc/bcm/Kconfig" source "drivers/soc/fsl/Kconfig"drivers/soc/Makefile +1
-0@@ -4,6 +4,7 @@ # obj-$(CONFIG_ARCH_ACTIONS) += actions/ +obj-y += aspeed/ obj-$(CONFIG_ARCH_AT91) += atmel/ obj-y += bcm/ obj-$(CONFIG_ARCH_DOVE) += dove/drivers/soc/aspeed/Kconfig new file +19
-0@@ -0,0 +1,19 @@ +menu "Aspeed SoC drivers" + +config ASPEED_LPC_CTRL + depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON + tristate "Aspeed ast2400/2500 HOST LPC to BMC bridge control" + ---help--- + Control Aspeed ast2400/2500 HOST LPC to BMC mappings through + ioctl()s, the driver also provides a read/write interface to a BMC ram + region where the host LPC read/write region can be buffered. + +config ASPEED_LPC_SNOOP + tristate "Aspeed ast2500 HOST LPC snoop support" + depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON + help + Provides a driver to control the LPC snoop interface which + allows the BMC to listen on and save the data written by + the host to an arbitrary LPC I/O port. + +drivers/soc/aspeed/Makefile new file +2
-0@@ -0,0 +1,2 @@ +obj-$(CONFIG_ASPEED_LPC_CTRL) += aspeed-lpc-ctrl.o +obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.odrivers/soc/aspeed/aspeed-lpc-ctrl.c renamed from drivers/misc/aspeed-lpc-ctrl.c +0
-0drivers/soc/aspeed/aspeed-lpc-snoop.c renamed from drivers/misc/aspeed-lpc-snoop.c +0
-1--2.21.0.593.g511ec345e18-goog
Quoted 7 lines · Arnd Bergmann
Quoted 5 lines · Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs.
Quoted 5 lines
Quoted 1 line
Signed-off-by Patrick Venture <[email protected]>Looks ok, but please resend to arm at kernel.org or soc at kernel.org so we can track the submission and make sure it gets applied if you want this to go through the arm-soc tree.
Thanks, I didn't see those come up in the get_maintainers output.
I had a longer question related to this patch progression -- if I am moving the aspeed gpio driver to the soc folder, the soc tree may have the soc/aspeed folder in their next, but the gpio tree wouldn't necessarily. I know the branches sync up when things are merged at the top, but I wasn't sure if there was another mechanism for this?
Quoted 130 lines
If Greg wants to pick it up, that's fine too.
Either way,
Acked-by Arnd Bergmann <[email protected]>Quoted 123 lines
--- drivers/misc/Kconfig | 16 ---------------- drivers/misc/Makefile | 2 -- drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/aspeed/Kconfig | 19 +++++++++++++++++++ drivers/soc/aspeed/Makefile | 2 ++ .../{misc => soc/aspeed}/aspeed-lpc-ctrl.c | 0 .../{misc => soc/aspeed}/aspeed-lpc-snoop.c | 0 8 files changed, 23 insertions(+), 18 deletions(-) create mode 100644 drivers/soc/aspeed/Kconfig create mode 100644 drivers/soc/aspeed/Makefile rename drivers/{misc => soc/aspeed}/aspeed-lpc-ctrl.c (100%) rename drivers/{misc => soc/aspeed}/aspeed-lpc-snoop.c (100%)drivers/misc/Kconfig +0
-16@@ -496,22 +496,6 @@ config VEXPRESS_SYSCFG bus. System Configuration interface is one of the possible means of generating transactions on this bus. -config ASPEED_LPC_CTRL - depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON - tristate "Aspeed ast2400/2500 HOST LPC to BMC bridge control" - ---help--- - Control Aspeed ast2400/2500 HOST LPC to BMC mappings through - ioctl()s, the driver also provides a read/write interface to a BMC ram - region where the host LPC read/write region can be buffered. - -config ASPEED_LPC_SNOOP - tristate "Aspeed ast2500 HOST LPC snoop support" - depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON - help - Provides a driver to control the LPC snoop interface which - allows the BMC to listen on and save the data written by - the host to an arbitrary LPC I/O port. - config PCI_ENDPOINT_TEST depends on PCI select CRC32drivers/misc/Makefile +0
-2@@ -54,8 +54,6 @@ obj-$(CONFIG_GENWQE) += genwqe/ obj-$(CONFIG_ECHO) += echo/ obj-$(CONFIG_VEXPRESS_SYSCFG) += vexpress-syscfg.o obj-$(CONFIG_CXL_BASE) += cxl/ -obj-$(CONFIG_ASPEED_LPC_CTRL) += aspeed-lpc-ctrl.o -obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o obj-$(CONFIG_PCI_ENDPOINT_TEST) += pci_endpoint_test.o obj-$(CONFIG_OCXL) += ocxl/ obj-y += cardreader/drivers/soc/Kconfig +1
-0@@ -2,6 +2,7 @@ menu "SOC (System On Chip) specific Drivers" source "drivers/soc/actions/Kconfig" source "drivers/soc/amlogic/Kconfig" +source "drivers/soc/aspeed/Kconfig" source "drivers/soc/atmel/Kconfig" source "drivers/soc/bcm/Kconfig" source "drivers/soc/fsl/Kconfig"drivers/soc/Makefile +1
-0@@ -4,6 +4,7 @@ # obj-$(CONFIG_ARCH_ACTIONS) += actions/ +obj-y += aspeed/ obj-$(CONFIG_ARCH_AT91) += atmel/ obj-y += bcm/ obj-$(CONFIG_ARCH_DOVE) += dove/drivers/soc/aspeed/Kconfig new file +19
-0@@ -0,0 +1,19 @@ +menu "Aspeed SoC drivers" + +config ASPEED_LPC_CTRL + depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON + tristate "Aspeed ast2400/2500 HOST LPC to BMC bridge control" + ---help--- + Control Aspeed ast2400/2500 HOST LPC to BMC mappings through + ioctl()s, the driver also provides a read/write interface to a BMC ram + region where the host LPC read/write region can be buffered. + +config ASPEED_LPC_SNOOP + tristate "Aspeed ast2500 HOST LPC snoop support" + depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON + help + Provides a driver to control the LPC snoop interface which + allows the BMC to listen on and save the data written by + the host to an arbitrary LPC I/O port. + +drivers/soc/aspeed/Makefile new file +2
-0@@ -0,0 +1,2 @@ +obj-$(CONFIG_ASPEED_LPC_CTRL) += aspeed-lpc-ctrl.o +obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.odrivers/soc/aspeed/aspeed-lpc-ctrl.c renamed from drivers/misc/aspeed-lpc-ctrl.c +0
-0drivers/soc/aspeed/aspeed-lpc-snoop.c renamed from drivers/misc/aspeed-lpc-snoop.c +0
-1--2.21.0.593.g511ec345e18-goog
Arnd Bergmann
maintainerQuoted 15 lines · Patrick Venture
Quoted 7 lines · Arnd Bergmann
Quoted 5 lines · Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs.
Quoted 5 lines
Quoted 1 line
Signed-off-by Patrick Venture <[email protected]>Looks ok, but please resend to arm at kernel.org or soc at kernel.org so we can track the submission and make sure it gets applied if you want this to go through the arm-soc tree.
Quoted 7 lines
Thanks, I didn't see those come up in the
get_maintainersoutput.I had a longer question related to this patch progression -- if I am moving the aspeed gpio driver to the soc folder, the soc tree may have the soc/aspeed folder in their next, but the gpio tree wouldn't necessarily. I know the branches sync up when things are merged at the top, but I wasn't sure if there was another mechanism for this?
We can generally deal with merge conflicts like this, or you can ask the respective maintainers about it and let us figure something out.
In this particular case, why would you move the gpio driver into the soc folder? If there is a proper subsystem for a driver, it should not be in drivers/misc or drivers/soc.
Arnd
Quoted 19 lines · Arnd Bergmann
Quoted 17 lines · Patrick Venture
Quoted 7 lines · Arnd Bergmann
Quoted 5 lines · Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs.
Quoted 5 lines
Quoted 1 line
Signed-off-by Patrick Venture <[email protected]>Looks ok, but please resend to arm at kernel.org or soc at kernel.org so we can track the submission and make sure it gets applied if you want this to go through the arm-soc tree.
Thanks, I didn't see those come up in the
get_maintainersoutput.
Quoted 8 lines
Quoted 5 lines
I had a longer question related to this patch progression -- if I am moving the aspeed gpio driver to the soc folder, the soc tree may have the soc/aspeed folder in their next, but the gpio tree wouldn't necessarily. I know the branches sync up when things are merged at the top, but I wasn't sure if there was another mechanism for this?
We can generally deal with merge conflicts like this, or you can ask the respective maintainers about it and let us figure something out.
Thanks for explaining that.
Quoted 4 lines
In this particular case, why would you move the gpio driver into the soc folder? If there is a proper subsystem for a driver, it should not be in
drivers/miscordrivers/soc.
Ok, that makes sense. I was trying to get a sense of what belonged in soc versus the subsystem folders. My thinking from the limited reading was the purpose of a SoC folder was to contain the drivers that were only associated with a system-on-a-chip and not a part you could buy and place on any board. A tmp421 sensor is just a generic part, versus the pwm controller, which is only for the specific SoCs.
That said, there are quite a few misc drivers associated with the Aspeed parts -- and there are two under review now, so there's a strong motivation to move those at least into the soc/aspeed folder. Thanks for these clarifying remarks.
Quoted 2 lines
Arnd
Quoted 43 lines · Patrick Venture
Quoted 19 lines · Arnd Bergmann
Quoted 17 lines · Patrick Venture
Quoted 7 lines · Arnd Bergmann
Quoted 5 lines · Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs.
Quoted 5 lines
Quoted 1 line
Signed-off-by Patrick Venture <[email protected]>Looks ok, but please resend to arm at kernel.org or soc at kernel.org so we can track the submission and make sure it gets applied if you want this to go through the arm-soc tree.
Thanks, I didn't see those come up in the
get_maintainersoutput.Quoted 8 lines
Quoted 5 lines
I had a longer question related to this patch progression -- if I am moving the aspeed gpio driver to the soc folder, the soc tree may have the soc/aspeed folder in their next, but the gpio tree wouldn't necessarily. I know the branches sync up when things are merged at the top, but I wasn't sure if there was another mechanism for this?
We can generally deal with merge conflicts like this, or you can ask the respective maintainers about it and let us figure something out.
Thanks for explaining that.
Quoted 4 lines
In this particular case, why would you move the gpio driver into the soc folder? If there is a proper subsystem for a driver, it should not be in
drivers/miscordrivers/soc.Ok, that makes sense. I was trying to get a sense of what belonged in soc versus the subsystem folders. My thinking from the limited reading was the purpose of a SoC folder was to contain the drivers that were only associated with a system-on-a-chip and not a part you could buy and place on any board. A tmp421 sensor is just a generic part, versus the pwm controller, which is only for the specific SoCs.
Quoted 4 lines
That said, there are quite a few misc drivers associated with the Aspeed parts -- and there are two under review now, so there's a strong motivation to move those at least into the soc/aspeed folder. Thanks for these clarifying remarks.
drivers/soc is more about platform-level glue and SoC configuration, etc. Specific IP blocks and drivers normally don't go into there, unless it's a shared resource that a lot of drivers need access to.
So, for most of the small drivers around the SoC, other directories than drivers/soc are still the best answer.
-Olof
Olof Johansson
AppliedQuoted 12 lines · Arnd Bergmann
Quoted 6 lines · Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs.
Signed-off-by Patrick Venture <[email protected]>Looks ok, but please resend to arm at kernel.org or soc at kernel.org so we can track the submission and make sure it gets applied if you want this to go through the arm-soc tree.
Quoted 5 lines
If Greg wants to pick it up, that's fine too.
Either way,
Acked-by Arnd Bergmann <[email protected]>
Applied to the SoC tree now.
-Olof