netdevsim: fix fall-through annotation
Subsystems (3)
PATCH 1/1 netdevsim: fix fall-through annotation
Replace "pass through" with a proper "fall through" annotation in order to fix the following warning:
drivers/net/netdevsim/bus.c: In function ‘new_device_store’:drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
port_count = 1;
~~~~~~~~~~~^~~drivers/net/netdevsim/bus.c:172:2: note: here
case 2:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This fix is part of the ongoing efforts to enable
-Wimplicit-fallthrough
--- drivers/net/netdevsim/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/netdevsim/bus.c +1 -1
@@ -168,7 +168,7 @@ new_device_store(struct bus_type *bus, const char *buf, size_t count)switch (err) {case 1 : port_count =1 ; -/* pass through */ +/* fall through */ case 2 :if (id >INT_MAX ) {pr_err ("Value of \"id\" is too big.\n" );
Signature · 1 line
2.21.0
Quoted 11 lines · Gustavo A. R. Silva
Replace "pass through" with a proper "fall through" annotation in order to fix the following warning:
drivers/net/netdevsim/bus.c: In function ‘new_device_store’:drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]port_count = 1; ~~~~~~~~~~~^~~
drivers/net/netdevsim/bus.c:172:2: note: here
case 2:
^~~~
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This fix is part of the ongoing efforts to enable
-Wimplicit-fallthroughSigned-off-by Gustavo A. R. Silva <[email protected]>
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 29 Apr 2019 12:38:07 -0500
Quoted 11 lines
Replace "pass through" with a proper "fall through" annotation in order to fix the following warning:
drivers/net/netdevsim/bus.c: In function ‘new_device_store’:drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]port_count = 1; ~~~~~~~~~~~^~~
drivers/net/netdevsim/bus.c:172:2: note: here
case 2:
^~~~
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This fix is part of the ongoing efforts to enable
-Wimplicit-fallthroughSigned-off-by Gustavo A. R. Silva <[email protected]>
Applied.