Skip to contentSkip to conversation

sched/cpufreq: Fix kobject memleak

PATCH RESEND In review Tobin C. Harding 3 participants 3 messages Apr 30, 2019

Subsystems (2)
Scheduler CPU frequency scaling framework
lore
Share & tools
lore

Tobin C. Harding

author
#0 lore raw

PATCH RESEND 1/1 sched/cpufreq: Fix kobject memleak

Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak.

Add call to kobject_put() in error path of kobject_init_and_add().

Signed-off-by Tobin C. Harding <[email protected]>

---

Resend with SOB tag.

 kernel/sched/cpufreq_schedutil.c | 1 +
 1 file changed, 1 insertion(+)
kernel/sched/cpufreq_schedutil.c +1 -0
index 5c41ea367422..3638d2377e3c 100644
@@ -771,6 +771,7 @@ static int sugov_init(struct cpufreq_policy *policy)
 	return 0;
 
 fail:
+	kobject_put(&tunables->attr_set.kobj);
 	policy->governor_data = NULL;
 	sugov_tunables_free(tunables);
Signature · 1 line
2.21.0
#1 lore raw
Quoted 9 lines · Tobin C. Harding

Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak.

Add call to kobject_put() in error path of kobject_init_and_add().

Signed-off-by Tobin C. Harding <[email protected]>

---

Resend with SOB tag.

Please ignore my previous mail :-)

Thanks,

Ingo

#2 lore raw
Quoted 6 lines · Ingo Molnar
Quoted 3 lines · Tobin C. Harding

Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak.

Quoted 8 lines
Quoted 6 lines

Add call to kobject_put() in error path of kobject_init_and_add().

Signed-off-by Tobin C. Harding <[email protected]>

---

Resend with SOB tag.

Please ignore my previous mail :-)

Cheers Ingo, caught myself not checkpatching :(

thanks,
Tobin.