staging: vc04_services: bcm2835-camera: Modify return statement.
Subsystems (3)
PATCH 1/1 staging: vc04_services: bcm2835-camera: Modify return statement.
Modify return statement and remove the respective assignment.
Issue found by coccinelle.
--- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +1 -2
@@ -1507,10 +1507,9 @@ static int set_camera_parameters(struct vchiq_mmal_instance *instance, .use_stc_timestamp = MMAL_PARAM_TIMESTAMP_MODE_RAW_STC }; - ret =vchiq_mmal_port_parameter_set (instance, &camera->control, +return vchiq_mmal_port_parameter_set (instance, &camera->control,MMAL_PARAMETER_CAMERA_CONFIG , &cam_config,sizeof (cam_config)); -return ret; }#define MAX_SUPPORTED_ENCODINGS 20
Signature · 1 line
2.17.1
Hi Vatsala,
Am 29.04.2019 um 09:36 schrieb Vatsala Narang:
Quoted 4 lines
Modify return statement and remove the respective assignment.
Issue found by coccinelle.
i didn't check other occurences of the same issue since your last patch (27.04.2019).
Could you please verify this is the last one of this type in bcm2835-camera?
Otherwise please send a patch to fixed them all.
Thanks Stefan
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Greg KH
maintainerQuoted 8 lines · Vatsala Narang
Modify return statement and remove the respective assignment.
Issue found by coccinelle.
Signed-off-by Vatsala Narang <[email protected]>--- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
You sent two different patches that did different things with the same exact subject: line :(
Please make them more unique.
thanks,
greg k-h