Skip to contentSkip to conversation

firmware_loader: Fix a typo ("syfs" -> "sysfs")

PATCH In review Jonathan Neuschäfer 2 participants 2 messages Apr 30, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware_loader: Fix a typo ("syfs" -> "sysfs")

"sysfs" was misspelled in a comment and a log message.

---
 drivers/base/firmware_loader/fallback.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/base/firmware_loader/fallback.c +3 -3
index b5c865fe263b..f962488546b6 100644
@@ -674,8 +674,8 @@ static bool fw_run_sysfs_fallback(enum fw_opt opt_flags)
  *
  * This function is called if direct lookup for the firmware failed, it enables
  * a fallback mechanism through userspace by exposing a sysfs loading
- * interface. Userspace is in charge of loading the firmware through the syfs
- * loading interface. This syfs fallback mechanism may be disabled completely
+ * interface. Userspace is in charge of loading the firmware through the sysfs
+ * loading interface. This sysfs fallback mechanism may be disabled completely
  * on a system by setting the proc sysctl value ignore_sysfs_fallback to true.
  * If this false we check if the internal API caller set the @FW_OPT_NOFALLBACK
  * flag, if so it would also disable the fallback mechanism. A system may want
@@ -693,7 +693,7 @@ int firmware_fallback_sysfs(struct firmware *fw, const char *name,
 		return ret;
 
 	if (!(opt_flags & FW_OPT_NO_WARN))
-		dev_warn(device, "Falling back to syfs fallback for: %s\n",
+		dev_warn(device, "Falling back to sysfs fallback for: %s\n",
 				 name);
 	else
 		dev_dbg(device, "Falling back to sysfs fallback for: %s\n",

--
2.20.1

Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Jonathan Neuschäfer

"sysfs" was misspelled in a comment and a log message.

Cheers,
-Mukesh

Quoted 31 lines
---
  drivers/base/firmware_loader/fallback.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/base/firmware_loader/fallback.c +3 -4
index b5c865fe263b..f962488546b6 100644
@@ -674,8 +674,8 @@ static bool fw_run_sysfs_fallback(enum fw_opt opt_flags)
   *
   * This function is called if direct lookup for the firmware failed, it enables
   * a fallback mechanism through userspace by exposing a sysfs loading
- * interface. Userspace is in charge of loading the firmware through the syfs
- * loading interface. This syfs fallback mechanism may be disabled completely
+ * interface. Userspace is in charge of loading the firmware through the sysfs
+ * loading interface. This sysfs fallback mechanism may be disabled completely
   * on a system by setting the proc sysctl value ignore_sysfs_fallback to true.
   * If this false we check if the internal API caller set the @FW_OPT_NOFALLBACK
   * flag, if so it would also disable the fallback mechanism. A system may want
@@ -693,7 +693,7 @@ int firmware_fallback_sysfs(struct firmware *fw, const char *name,
  		return ret;
 
  	if (!(opt_flags & FW_OPT_NO_WARN))
-		dev_warn(device, "Falling back to syfs fallback for: %s\n",
+		dev_warn(device, "Falling back to sysfs fallback for: %s\n",
  				 name);
  	else
  		dev_dbg(device, "Falling back to sysfs fallback for: %s\n",
--

2.20.1