package/wpebackend-fdo: package needs wayland libegl
PATCH 1/1 package/wpebackend-fdo: package needs wayland libegl
Now wpebackend-fdo depends only on HAS_LIBEGL but if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending on backends(fb,x11,wl).
Add 'depend on BR2_PACKAGE_HAS_LIBEGL_WAYLAND' to Config.in to avoid building if there is not a wayland egl backend.
Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/
--- package/wpebackend-fdo/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/wpebackend-fdo/Config.in +2 -1
@@ -1,6 +1,6 @@ comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend" depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ - || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS + || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND config BR2_PACKAGE_WPEBACKEND_FDO bool "wpebackend-fdo"
@@ -10,6 +10,7 @@ config BR2_PACKAGE_WPEBACKEND_FDO depends on BR2_USE_WCHAR # libglib2 depends on BR2_USE_MMU # libglib2 depends on BR2_PACKAGE_HAS_LIBEGL + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBWPE select BR2_PACKAGE_WAYLAND
Signature · 1 line
2.17.1
PATCH 1/1 package/wpebackend-fdo: package needs wayland libegl
Hi Giulio,
Quoted 20 lines · Giulio Benetti
Now wpebackend-fdo depends only on
HAS_LIBEGLbut if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending onbackends(fb,x11,wl).Add 'depend on
BR2_PACKAGE_HAS_LIBEGL_WAYLAND' to Config.in to avoid building if there is not a wayland egl backend.Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/Signed-off-by Giulio Benetti <[email protected]>--- package/wpebackend-fdo/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/wpebackend-fdo/Config.in +0
-0
package/wpebackend-fdo/Config.in line 1
Quoted 1 line
package/wpebackend-fdo/Config.in +0
-0@@ -1,6 +1,6 @@ comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend"
Wayland should be mentioned here as well.
package/wpebackend-fdo/Config.in line 2
Quoted 1 line
package/wpebackend-fdo/Config.in +0
-0depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
^^^^^^^^^^^^^^^^^^^^^^^ This can be removed I guess
package/wpebackend-fdo/Config.in config BR2_PACKAGE_WPEBACKEND_FDO · line 12
Quoted 9 lines
package/wpebackend-fdo/Config.in +1
-1- || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS + || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND config BR2_PACKAGE_WPEBACKEND_FDO bool "wpebackend-fdo"@@ -10,6 +10,7 @@ config BR2_PACKAGE_WPEBACKEND_FDO depends on BR2_USE_WCHAR # libglib2 depends on BR2_USE_MMU # libglib2 depends on BR2_PACKAGE_HAS_LIBEGL
This as well.
Regards,
Arnout
Quoted 5 lines
package/wpebackend-fdo/Config.in +1
-0+ depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBWPE select BR2_PACKAGE_WAYLAND
PATCH 1/1 package/wpebackend-fdo: package needs wayland libegl
Hi Arnout,
Il 14/04/2019 12:18, Arnout Vandecappelle ha scritto:
Quoted 18 lines
Hi Giulio,
Quoted 15 lines · Giulio Benetti
Now wpebackend-fdo depends only on
HAS_LIBEGLbut if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending onbackends(fb,x11,wl).Add 'depend on
BR2_PACKAGE_HAS_LIBEGL_WAYLAND' to Config.in to avoid building if there is not a wayland egl backend.Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/Signed-off-by Giulio Benetti <[email protected]>--- package/wpebackend-fdo/Config.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 8 lines
package/wpebackend-fdo/Config.in line 1
Quoted 6 lines
package/wpebackend-fdo/Config.in +0
-0@@ -1,6 +1,6 @@ comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend"Wayland should be mentioned here as well.
Oh yes.
Quoted 2 lines
package/wpebackend-fdo/Config.in line 2
Quoted 1 line
package/wpebackend-fdo/Config.in +0
-0depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \^^^^^^^^^^^^^^^^^^^^^^^ This can be removed I guess
Right.
Quoted 11 lines
package/wpebackend-fdo/Config.in config BR2_PACKAGE_WPEBACKEND_FDO · line 12
Quoted 9 lines
package/wpebackend-fdo/Config.in +1
-1- || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS + || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND config BR2_PACKAGE_WPEBACKEND_FDO bool "wpebackend-fdo"@@ -10,6 +10,7 @@ config BR2_PACKAGE_WPEBACKEND_FDO depends on BR2_USE_WCHAR # libglib2 depends on BR2_USE_MMU # libglib2 depends on BR2_PACKAGE_HAS_LIBEGLThis as well.
Right.
Thanks for rievewing.
I'm going to send v2 patch.
Best regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v2 1/1 package/wpebackend-fdo: package needs wayland libegl
In reply to Arnout VandecappelleNow wpebackend-fdo depends only on HAS_LIBEGL but if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending on backends(fb,x11,wl).
Modify:
'depend on BR2_PACKAGE_HAS_LIBEGL'
to:
'depend on BR2_PACKAGE_HAS_LIBEGL_WAYLAND'
in Config.in to avoid building if there is not a wayland egl backend. Modify also comment in Config.in when package is not selectable mentioning the need to have an OpenEGL-capable Wayland backend.
Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/
--- package/wpebackend-fdo/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
package/wpebackend-fdo/Config.in +3 -3
@@ -1,5 +1,5 @@ -comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend" - depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ +comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable Wayland backend" + depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS config BR2_PACKAGE_WPEBACKEND_FDO
@@ -9,7 +9,7 @@ config BR2_PACKAGE_WPEBACKEND_FDO depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, libglib2 depends on BR2_USE_WCHAR # libglib2 depends on BR2_USE_MMU # libglib2 - depends on BR2_PACKAGE_HAS_LIBEGL + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBWPE select BR2_PACKAGE_WAYLAND
Signature · 1 line
2.17.1
PATCH v2 1/1 package/wpebackend-fdo: package needs wayland libegl
Hi all,
Il 14/04/2019 22:12, Giulio Benetti ha scritto:
Quoted 34 lines
Now wpebackend-fdo depends only on
HAS_LIBEGLbut if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending onbackends(fb,x11,wl).Modify:
'depend onBR2_PACKAGE_HAS_LIBEGL'
to:
'depend onBR2_PACKAGE_HAS_LIBEGL_WAYLAND'
in Config.in to avoid building if there is not a wayland egl backend. Modify also comment in Config.in when package is not selectable mentioning the need to have an OpenEGL-capable Wayland backend.Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/Signed-off-by Giulio Benetti <[email protected]>--- package/wpebackend-fdo/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)package/wpebackend-fdo/Config.in +2
-2@@ -1,5 +1,5 @@ -comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend" - depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ +comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable Wayland backend" + depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS config BR2_PACKAGE_WPEBACKEND_FDO
package/wpebackend-fdo/Config.in config BR2_PACKAGE_WPEBACKEND_FDO · line 15
Quoted 8 lines
package/wpebackend-fdo/Config.in +1
-1@@ -9,7 +9,7 @@ config BR2_PACKAGE_WPEBACKEND_FDO depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, libglib2 depends on BR2_USE_WCHAR # libglib2 depends on BR2_USE_MMU # libglib2 - depends on BR2_PACKAGE_HAS_LIBEGL + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBWPE select BR2_PACKAGE_WAYLAND
This is broken, sorry, need to resend.
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v3 1/1 package/wpebackend-fdo: package needs wayland libegl
In reply to Arnout VandecappelleNow wpebackend-fdo depends only on HAS_LIBEGL but if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending on backends(fb,x11,wl).
Modify:
'depend on BR2_PACKAGE_HAS_LIBEGL'
to:
'depend on BR2_PACKAGE_HAS_LIBEGL_WAYLAND'
in Config.in to avoid building if there is not a wayland egl backend. Modify also comment in Config.in when package is not selectable mentioning the need to have an OpenEGL-capable Wayland backend.
Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/
---
Changes:V1->V2:
* use BR2_PACKAGE_HAS_LIBEGL_WAYLAND only instead of using BR2_PACKAGE_HAS_LIBEGL too
* add Wayland to comment
V2->V3:
* add \ at the end of depends on
package/wpebackend-fdo/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
package/wpebackend-fdo/Config.in +3 -3
@@ -1,5 +1,5 @@ -comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend" - depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ +comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable Wayland backend" + depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS config BR2_PACKAGE_WPEBACKEND_FDO
@@ -9,7 +9,7 @@ config BR2_PACKAGE_WPEBACKEND_FDO depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, libglib2 depends on BR2_USE_WCHAR # libglib2 depends on BR2_USE_MMU # libglib2 - depends on BR2_PACKAGE_HAS_LIBEGL + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBWPE select BR2_PACKAGE_WAYLAND
Signature · 1 line
2.17.1
PATCH v3 1/1 package/wpebackend-fdo: package needs wayland libegl
Hi,
I finally got round to look at this; the changes make sense. I also did try a couple of builds with the patch applied (which went fine). Thanks!
Quoted 12 lines · Giulio Benetti
Now wpebackend-fdo depends only on
HAS_LIBEGLbut if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending onbackends(fb,x11,wl).Modify:
'depend onBR2_PACKAGE_HAS_LIBEGL'
to:
'depend onBR2_PACKAGE_HAS_LIBEGL_WAYLAND'
in Config.in to avoid building if there is not a wayland egl backend. Modify also comment in Config.in when package is not selectable mentioning the need to have an OpenEGL-capable Wayland backend.
Quoted 4 lines
Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/Signed-off-by Giulio Benetti <[email protected]>
Quoted 41 lines
---
Changes:V1->V2:
* useBR2_PACKAGE_HAS_LIBEGL_WAYLANDonly instead of usingBR2_PACKAGE_HAS_LIBEGLtoo
* add Wayland to comment
V2->V3:
* add\at the end ofdepends onpackage/wpebackend-fdo/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)package/wpebackend-fdo/Config.in +3
-3@@ -1,5 +1,5 @@ -comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend" - depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ +comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable Wayland backend" + depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS config BR2_PACKAGE_WPEBACKEND_FDO@@ -9,7 +9,7 @@ config BR2_PACKAGE_WPEBACKEND_FDO depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, libglib2 depends on BR2_USE_WCHAR # libglib2 depends on BR2_USE_MMU # libglib2 - depends on BR2_PACKAGE_HAS_LIBEGL + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBWPE select BR2_PACKAGE_WAYLANDSignature · 6 lines
2.17.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190430/b2994a62/attachment.asc>
PATCH v3 1/1 package/wpebackend-fdo: package needs wayland libegl
Il 30/04/2019 14:28, Adrian Perez de Castro ha scritto:
Quoted 4 lines
Hi,
I finally got round to look at this; the changes make sense. I also did try a couple of builds with the patch applied (which went fine). Thanks!
Thank you.
Best regards
Giulio
Quoted 62 lines · Giulio Benetti
Quoted 13 lines
Now wpebackend-fdo depends only on
HAS_LIBEGLbut if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending onbackends(fb,x11,wl).Modify:
'depend onBR2_PACKAGE_HAS_LIBEGL'
to:
'depend onBR2_PACKAGE_HAS_LIBEGL_WAYLAND'
in Config.in to avoid building if there is not a wayland egl backend. Modify also comment in Config.in when package is not selectable mentioning the need to have an OpenEGL-capable Wayland backend.Quoted 4 lines
Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/Signed-off-by Giulio Benetti <[email protected]>Reviewed-by Adrian Perez de Castro <[email protected]>Quoted 41 lines
---
Changes:V1->V2:
* useBR2_PACKAGE_HAS_LIBEGL_WAYLANDonly instead of usingBR2_PACKAGE_HAS_LIBEGLtoo
* add Wayland to comment
V2->V3:
* add\at the end ofdepends onpackage/wpebackend-fdo/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)package/wpebackend-fdo/Config.in +3
-3@@ -1,5 +1,5 @@ -comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend" - depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ +comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable Wayland backend" + depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \ || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS config BR2_PACKAGE_WPEBACKEND_FDO@@ -9,7 +9,7 @@ config BR2_PACKAGE_WPEBACKEND_FDO depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, libglib2 depends on BR2_USE_WCHAR # libglib2 depends on BR2_USE_MMU # libglib2 - depends on BR2_PACKAGE_HAS_LIBEGL + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBWPE select BR2_PACKAGE_WAYLANDSignature · 6 lines
2.17.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH v3 1/1 package/wpebackend-fdo: package needs wayland libegl
In reply to Giulio BenettiQuoted 25 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Giulio" == Giulio Benetti <[email protected]> writes:
Now wpebackend-fdo depends only on
HAS_LIBEGLbut if libegl is not of wayland type, build breaks due to different EGLNativeWindowType types depending onbackends(fb,x11,wl).Modify:
'depend onBR2_PACKAGE_HAS_LIBEGL'
to:
'depend onBR2_PACKAGE_HAS_LIBEGL_WAYLAND'
in Config.in to avoid building if there is not a wayland egl backend. Modify also comment in Config.in when package is not selectable mentioning the need to have an OpenEGL-capable Wayland backend.Fixes:
http://autobuild.buildroot.net/results/4f02b91f6ffffd194e09ed18c917b4f678b1a52d/Signed-off-by Giulio Benetti <[email protected]>---
Changes:
V1-> V2:
* useBR2_PACKAGE_HAS_LIBEGL_WAYLANDonly instead of usingBR2_PACKAGE_HAS_LIBEGLtoo
* add Wayland to comment
Quoted 2 lines
V2-> V3:
* add\at the end ofdepends on
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard