nvme-tcp: fix possible null deref on a timed out io queue connect
Sagi Grimberg
maintainerPATCH 1/1 nvme-tcp: fix possible null deref on a timed out io queue connect
If I/O queue connect times out, we might have freed the queue socket already, so check for that on the error path in nvme_tcp_start_queue.
Signed-off-by Sagi Grimberg <sagi at grimberg.me>
--- drivers/nvme/host/tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/nvme/host/tcp.c +2 -1
@@ -1431,7 +1431,8 @@ static int nvme_tcp_start_queue(struct nvme_ctrl *nctrl, int idx)if (!ret) {set_bit (NVME_TCP_Q_LIVE , &ctrl->queues[idx].flags); }else { -__nvme_tcp_stop_queue (&ctrl->queues[idx]); +if (test_bit (NVME_TCP_Q_ALLOCATED , &ctrl->queues[idx].flags)) +__nvme_tcp_stop_queue (&ctrl->queues[idx]);dev_err (nctrl->device,"failed to connect queue: %d ret=%d\n" , idx, ret); }
Signature · 1 line
2.17.1
Christoph Hellwig
AppliedPATCH 1/1 nvme-tcp: fix possible null deref on a timed out io queue connect
Thanks,
applied to nvme-5.2.