Skip to contentSkip to conversation

ASoC: tlv320aic3x: Add support for high power analog output

PATCH Superseded Saravanan Sekar 2 participants 2 messages Apr 30, 2019 – May 2, 2019

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: tlv320aic3x: Add support for high power analog output

Add support to output level control for the analog high power output drivers HPOUT and HPCOM.

---

Notes:
Changes in V2:
- Removed power control as it is handled by DAPM
- Added level control for left channel

 sound/soc/codecs/tlv320aic3x.c | 9 +++++++++
 1 file changed, 9 insertions(+)
sound/soc/codecs/tlv320aic3x.c +9 -0
index 516d17cb2182..90f53f9b5c2f 100644
@@ -324,6 +324,9 @@ static DECLARE_TLV_DB_SCALE(adc_tlv, 0, 50, 0);
  */
 static DECLARE_TLV_DB_SCALE(output_stage_tlv, -5900, 50, 1);
 
+/* HP/HPCOM volumes. From 0 to 9 dB in 1 dB steps */
+static DECLARE_TLV_DB_SCALE(hp_tlv, 0, 100, 0);
+
 static const struct snd_kcontrol_new aic3x_snd_controls[] = {
 	/* Output */
 	SOC_DOUBLE_R_TLV("PCM Playback Volume",
@@ -419,6 +422,12 @@ static const struct snd_kcontrol_new aic3x_snd_controls[] = {
 	/* Pop reduction */
 	SOC_ENUM("Output Driver Power-On time", aic3x_poweron_time_enum),
 	SOC_ENUM("Output Driver Ramp-up step", aic3x_rampup_step_enum),
+
+	/* Analog HPOUT, HPCOM output level controls */
+	SOC_DOUBLE_R_TLV("HP Playback Volume", HPLOUT_CTRL, HPROUT_CTRL,
+			4, 9, 0, hp_tlv);
+	SOC_DOUBLE_R_TLV("HPCOM Playback Volume", HPLCOM_CTRL, HPRCOM_CTRL,
+			4, 9, 0, hp_tlv);
 };
 
 /* For other than tlv320aic3104 */
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 4 lines · Saravanan Sekar

Add support to output level control for the analog high power output drivers HPOUT and HPCOM.

This doesn't build with current code:

CC sound/soc/codecs/tlv320aic3x.o
sound/soc/codecs/tlv320aic3x.c:428:20: error: expected ‘}’ before ‘;’ token

    4, 9, 0, hp_tlv);
                    ^
sound/soc/codecs/tlv320aic3x.c:330:61: note: to match this ‘{’
 static const struct snd_kcontrol_new aic3x_snd_controls[] = {
                                                             ^