kernel/module: Reschedule while waiting for modules to finish loading
PATCH v2 1/1 kernel/module: Reschedule while waiting for modules to finish loading
On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while loading the s390_trng.ko module.
Add a reschedule point to the loop that waits for modules to complete loading.
v2: cleanup Fixes line.
Reported-by Heiko Carstens <[email protected]>
Fixes commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
Signed-off-by Prarit Bhargava <[email protected]>
Cc Jessica Yu <[email protected]>
Cc Heiko Carstens <[email protected]>
--- kernel/module.c | 1 + 1 file changed, 1 insertion(+)
kernel/module.c +1 -0
@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod) finished_loading(mod->name));if (err) goto out_unlocked; +cond_resched (); goto again; } err = -EEXIST ;
Signature · 1 line
2.18.1
Quoted 6 lines · Prarit Bhargava
On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while loading the s390_trng.ko module.
Add a reschedule point to the loop that waits for modules to complete loading.
Sorry, sent in error.
P.
Quoted 24 lines
v2: cleanup Fixes line.
Reported-by Heiko Carstens <[email protected]>Fixes commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")Signed-off-by Prarit Bhargava <[email protected]>Cc Jessica Yu <[email protected]>Cc Heiko Carstens <[email protected]>--- kernel/module.c | 1 + 1 file changed, 1 insertion(+)kernel/module.c +1
-0@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod) finished_loading(mod->name));if (err) goto out_unlocked; +cond_resched (); goto again; } err = -EEXIST ;