Skip to contentSkip to conversation

Patch "x86/fpu: Don't export __kernel_fpu_{begin,end}()" has been added to the 4.19-stable tree

DISCUSSION Andy Lutomirski 2 participants 2 messages May 2, 2019 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CALCETrVjhVXYA4B6zFzbH14wBXZcNMAeM8YxdRh3RLHxVVde_g@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 12 lines · Greg KH
Quoted 10 lines · Andy Lutomirski
Quoted 8 lines · On Mon, Apr 29, 2019 at 6:36 AM <[email protected]> wrote:

This is a note to let you know that I've just added the patch titled

    x86/fpu: Don't export __kernel_fpu_{begin,end}()

to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 7 lines
Quoted 3 lines

Why? ISTM the only possible effect is to break out-of-tree modules. I have no objection to breaking such modules if we need to, but, in this case, I don't see the benefit.

The "benefit" is that people keep complaining that newer kernels do not have this api for some reason and that it is a "regression", which completely does not understand how the kernel handles internal apis.

I suppose that's a reasonable point. But maybe we should actually give these modules a credible alternative first? I just send a patch.

#4 lore raw
Quoted 17 lines · Andy Lutomirski
Quoted 16 lines · Greg KH
Quoted 13 lines · Andy Lutomirski
Quoted 8 lines · On Mon, Apr 29, 2019 at 6:36 AM <[email protected]> wrote:

This is a note to let you know that I've just added the patch titled

    x86/fpu: Don't export __kernel_fpu_{begin,end}()

to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Why? ISTM the only possible effect is to break out-of-tree modules. I have no objection to breaking such modules if we need to, but, in this case, I don't see the benefit.

Quoted 6 lines
Quoted 3 lines

The "benefit" is that people keep complaining that newer kernels do not have this api for some reason and that it is a "regression", which completely does not understand how the kernel handles internal apis.

I suppose that's a reasonable point. But maybe we should actually give these modules a credible alternative first? I just send a patch.

That's your call, it's your code :)

thanks,

greg k-h