Skip to contentSkip to conversation

tools/Makefile: Fix build of QEMU, remove --source-path

PATCH In review Anthony PERARD 3 participants 3 messages May 2, 2019 – May 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/Makefile: Fix build of QEMU, remove --source-path

Following QEMU's commit 79d77bcd36 (configure: Remove --source-path option), Xen's build system fails to build qemu-xen. The --source-path option gives redundant information about the location of the sources so simply remove it. (configure already looks at its $0 to find the source-path.)

---
This patch would unblock the qemu-mainline branch in osstest.

---
 tools/Makefile | 1 -
 1 file changed, 1 deletion(-)
tools/Makefile +0 -1
index c903d6a63e..99cbc950dc 100644
@@ -246,7 +246,6 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
 		--prefix=$(LIBEXEC) \
 		--libdir=$(LIBEXEC_LIB) \
 		--includedir=$(LIBEXEC_INC) \
-		--source-path=$$source \
 		--extra-cflags="-DXC_WANT_COMPAT_EVTCHN_API=1 \
 		-DXC_WANT_COMPAT_GNTTAB_API=1 \
 		-DXC_WANT_COMPAT_MAP_FOREIGN_API=1 \
Signature · 7 lines
Anthony PERARD


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw

Adding Stefano for archaelogical reasons.

Anthony PERARD writes ("[PATCH] tools/Makefile: Fix build of QEMU, remove --source-path"):

Quoted 5 lines

Following QEMU's commit 79d77bcd36 (configure: Remove --source-path option), Xen's build system fails to build qemu-xen. The --source-path option gives redundant information about the location of the sources so simply remove it. (configure already looks at its $0 to find the source-path.)

For Xen staging:

I wanted to follow the principle of Chesterton's Fence [1], particularly to know how far back to backport this change, so I checked the git history. This option has been passed since the very first time xen.git built qemu upstream, in
e737b4333bb287b6134a89edff2bde2a7e048a9e
Clone and build upstream Qemu by default

Stefano, can you remember anything about this ? DYK how far back we should backport this change ?

Thanks,
Ian.

[1] https://en.wikipedia.org/wiki/Chesterton%27s_fence#Chesterton's_fence

Quoted 22 lines

---
This patch would unblock the qemu-mainline branch in osstest.

---
 tools/Makefile | 1 -
 1 file changed, 1 deletion(-)
tools/Makefile +0 -1
index c903d6a63e..99cbc950dc 100644
@@ -246,7 +246,6 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
 		--prefix=$(LIBEXEC) \
 		--libdir=$(LIBEXEC_LIB) \
 		--includedir=$(LIBEXEC_INC) \
-		--source-path=$$source \
 		--extra-cflags="-DXC_WANT_COMPAT_EVTCHN_API=1 \
 		-DXC_WANT_COMPAT_GNTTAB_API=1 \
 		-DXC_WANT_COMPAT_MAP_FOREIGN_API=1 \
Signature · 1 line
Anthony PERARD

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
Quoted 20 lines · Ian Jackson

Adding Stefano for archaelogical reasons.

Anthony PERARD writes ("[PATCH] tools/Makefile: Fix build of QEMU, remove --source-path"):

Quoted 5 lines

Following QEMU's commit 79d77bcd36 (configure: Remove --source-path option), Xen's build system fails to build qemu-xen. The --source-path option gives redundant information about the location of the sources so simply remove it. (configure already looks at its $0 to find the source-path.)

For Xen staging:

I wanted to follow the principle of Chesterton's Fence [1], particularly to know how far back to backport this change, so I checked the git history. This option has been passed since the very first time xen.git built qemu upstream, in
e737b4333bb287b6134a89edff2bde2a7e048a9e
Clone and build upstream Qemu by default

Quoted 2 lines

Stefano, can you remember anything about this ? DYK how far back we should backport this change ?

Unfortunately I don't remember. To stay on the safe side, I would test each backport before pushing it if I were you.

Quoted 9 lines

[1] https://en.wikipedia.org/wiki/Chesterton%27s_fence#Chesterton's_fence

Quoted 7 lines

---
This patch would unblock the qemu-mainline branch in osstest.

---
 tools/Makefile | 1 -
 1 file changed, 1 deletion(-)
Quoted 16 lines
Quoted 15 lines
tools/Makefile +0 -1
index c903d6a63e..99cbc950dc 100644
@@ -246,7 +246,6 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
 		--prefix=$(LIBEXEC) \
 		--libdir=$(LIBEXEC_LIB) \
 		--includedir=$(LIBEXEC_INC) \
-		--source-path=$$source \
 		--extra-cflags="-DXC_WANT_COMPAT_EVTCHN_API=1 \
 		-DXC_WANT_COMPAT_GNTTAB_API=1 \
 		-DXC_WANT_COMPAT_MAP_FOREIGN_API=1 \
Signature · 1 line
Anthony PERARD

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel