Skip to contentSkip to conversation

Staging: rtl8192u: ieee80211: Fix coding style warning

PATCH New Puranjay Mohan 2 participants 2 messages May 2, 2019 Staging

lore
Share & tools
lore

Puranjay Mohan

author
#0 lore raw

PATCH 1/1 Staging: rtl8192u: ieee80211: Fix coding style warning

Remove braces around a single if statement to fix following checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by Puranjay Mohan <puranjay12 at gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +2 -2
index 0e762e559675..c3433ade7144 100644
@@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
 	spin_unlock_irqrestore(&ieee->lock, flags);
 	if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
 		(ieee->state == IEEE80211_LINKED)) {
-		if (ieee->handle_beacon != NULL) {
+		if (ieee->handle_beacon != NULL) 
 			ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
-		}
+		
 	}
 
 out:
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 Staging: rtl8192u: ieee80211: Fix coding style warning

Quoted 14 lines · Puranjay Mohan

Remove braces around a single if statement to fix following checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by Puranjay Mohan <puranjay12 at gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +0 -0
index 0e762e559675..c3433ade7144 100644

drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c static inline void ieee80211_process_probe_response( · line 2582

Quoted 8 lines
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +2 -2
@@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
 	spin_unlock_irqrestore(&ieee->lock, flags);
 	if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
 		(ieee->state == IEEE80211_LINKED)) {
-		if (ieee->handle_beacon != NULL) {
+		if (ieee->handle_beacon != NULL) 
 			ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
-		}
+

Again you added trailing whitespace.

Git even complains when you try to apply this :(

greg k-h