clk: gcc-qcs404: Add PCIe resets
PATCH 1/1 clk: gcc-qcs404: Add PCIe resets
Enabling PCIe requires several of the PCIe related resets from GCC, so add them all.
---
Changes since v2:
- Rebased patch
drivers/clk/qcom/gcc-qcs404.c | 7 +++++++ include/dt-bindings/clock/qcom,gcc-qcs404.h | 7 +++++++ 2 files changed, 14 insertions(+)
drivers/clk/qcom/gcc-qcs404.c +7 -0
@@ -2766,6 +2766,13 @@ static const struct qcom_reset_map gcc_qcs404_resets[] = { [GCC_PCIE_0_PHY_BCR] = { 0x3e004 }, [GCC_PCIE_0_LINK_DOWN_BCR] = { 0x3e038 }, [GCC_PCIEPHY_0_PHY_BCR] = { 0x3e03c }, + [GCC_PCIE_0_AXI_MASTER_STICKY_ARES] = { 0x3e040, 6}, + [GCC_PCIE_0_AHB_ARES] = { 0x3e040, 5 }, + [GCC_PCIE_0_AXI_SLAVE_ARES] = { 0x3e040, 4 }, + [GCC_PCIE_0_AXI_MASTER_ARES] = { 0x3e040, 3 }, + [GCC_PCIE_0_CORE_STICKY_ARES] = { 0x3e040, 2 }, + [GCC_PCIE_0_SLEEP_ARES] = { 0x3e040, 1 }, + [GCC_PCIE_0_PIPE_ARES] = { 0x3e040, 0 }, [GCC_EMAC_BCR] = { 0x4e000 }, };
include/dt-bindings/clock/qcom,gcc-qcs404.h +7 -0
@@ -166,5 +166,12 @@#define GCC_PCIEPHY_0_PHY_BCR 12#define GCC_EMAC_BCR 13#define GCC_CDSP_RESTART 14 +#define GCC_PCIE_0_AXI_MASTER_STICKY_ARES 14 +#define GCC_PCIE_0_AHB_ARES 15 +#define GCC_PCIE_0_AXI_SLAVE_ARES 16 +#define GCC_PCIE_0_AXI_MASTER_ARES 17 +#define GCC_PCIE_0_CORE_STICKY_ARES 18 +#define GCC_PCIE_0_SLEEP_ARES 19 +#define GCC_PCIE_0_PIPE_ARES 20#endif
Signature · 1 line
2.18.0
include/dt-bindings/clock/qcom,gcc-qcs404.h line 169
Quoted 9 lines · Bjorn Andersson
include/dt-bindings/clock/qcom,gcc-qcs404.h +1
-0@@ -166,5 +166,12 @@#define GCC_PCIEPHY_0_PHY_BCR 12#define GCC_EMAC_BCR 13#define GCC_CDSP_RESTART 14 +#define GCC_PCIE_0_AXI_MASTER_STICKY_ARES 14
Seems weird that there would be two names for the same entry at index 14?
Quoted 13 lines · Marc Gonzalez
include/dt-bindings/clock/qcom,gcc-qcs404.h line 169
Quoted 9 lines · Bjorn Andersson
include/dt-bindings/clock/qcom,gcc-qcs404.h +1
-0@@ -166,5 +166,12 @@#define GCC_PCIEPHY_0_PHY_BCR 12#define GCC_EMAC_BCR 13#define GCC_CDSP_RESTART 14 +#define GCC_PCIE_0_AXI_MASTER_STICKY_ARES 14Seems weird that there would be two names for the same entry at index 14?
Changes since v2:
- Rebased patch
The proper tag in the subject should have been [PATCH v2].
This is most likely an issue caused by the rebase.
Kind regards,
Niklas
Stephen Boyd
maintainerQuoting Niklas Cassel (2019-05-02 04:20:24)
Quoted 15 lines · Marc Gonzalez
Quoted 13 lines · Bjorn Andersson
include/dt-bindings/clock/qcom,gcc-qcs404.h line 169
Quoted 10 lines
include/dt-bindings/clock/qcom,gcc-qcs404.h +1
-0@@ -166,5 +166,12 @@#define GCC_PCIEPHY_0_PHY_BCR 12#define GCC_EMAC_BCR 13#define GCC_CDSP_RESTART 14 +#define GCC_PCIE_0_AXI_MASTER_STICKY_ARES 14Seems weird that there would be two names for the same entry at index 14?
Quoted 7 lines
Changes since v2:
- Rebased patchThe proper tag in the subject should have been [PATCH v2].
This is most likely an issue caused by the rebase.
Please resend then.
Quoted 19 lines · Stephen Boyd
Quoting Niklas Cassel (2019-05-02 04:20:24)
Quoted 18 lines · Marc Gonzalez
Quoted 13 lines · Bjorn Andersson
include/dt-bindings/clock/qcom,gcc-qcs404.h line 169
Quoted 10 lines
include/dt-bindings/clock/qcom,gcc-qcs404.h +1
-0@@ -166,5 +166,12 @@#define GCC_PCIEPHY_0_PHY_BCR 12#define GCC_EMAC_BCR 13#define GCC_CDSP_RESTART 14 +#define GCC_PCIE_0_AXI_MASTER_STICKY_ARES 14Seems weird that there would be two names for the same entry at index 14?
Changes since v2:
- Rebased patch
Quoted 7 lines
Quoted 4 lines
The proper tag in the subject should have been [PATCH v2].
This is most likely an issue caused by the rebase.
Please resend then.
Yeah, I screwed up the rebase. v4 is coming.
Thanks Marc,
Bjorn