Provide in-kernel headers to make extending kernel easier
Subsystems (2)
PATCH RESEND v7 1/2 Provide in-kernel headers to make extending kernel easier
Introduce in-kernel headers which are made available as an archive through proc (/proc/kheaders.tar.xz file). This archive makes it possible to run eBPF and other tracing programs that need to extend the kernel for tracing purposes without any dependency on the file system having headers.
A github PR is sent for the corresponding BCC patch at:
https://github.com/iovisor/bcc/pull/2312
On Android and embedded systems, it is common to switch kernels but not have kernel headers available on the file system. Further once a different kernel is booted, any headers stored on the file system will no longer be useful. This is an issue even well known to distros. By storing the headers as a compressed archive within the kernel, we can avoid these issues that have been a hindrance for a long time.
The best way to use this feature is by building it in. Several users have a need for this, when they switch debug kernels, they do not want to update the filesystem or worry about it where to store the headers on it. However, the feature is also buildable as a module in case the user desires it not being part of the kernel image. This makes it possible to load and unload the headers from memory on demand. A tracing program can load the module, do its operations, and then unload the module to save kernel memory. The total memory needed is 3.3MB.
By having the archive available at a fixed location independent of filesystem dependencies and conventions, all debugging tools can directly refer to the fixed location for the archive, without concerning with where the headers on a typical filesystem which significantly simplifies tooling that needs kernel headers.
The code to read the headers is based on /proc/config.gz code and uses the same technique to embed the headers.
Other approaches were discussed such as having an in-memory mountable filesystem, but that has drawbacks such as requiring an in-kernel xz decompressor which we don't have today, and requiring usage of 42 MB of kernel memory to host the decompressed headers at anytime. Also this approach is simpler than such approaches.
---
(Just a resend with Masahiro's Reviewed-by tag added)
v6 -> v7:
- Minor nits from Masahiro Yamada are addressed.
v5 -> v6: (Masahiro Yamada suggestions mostly)
- Dropped support for module building.
- Rebuild archive if script changes.
- Move archive file list to script.
- Move build script to kernel directory.
v4 -> v5:
(v4 was Tested-by the following folks)
Tested-by: qais.yousef at arm.com
Tested-by: dietmar.eggemann at arm.com
Tested-by: linux at manojrajarao.com
(Thanks to Masahiro Yamada for several excellent suggestions)
- used incbin instead of bin2c (Masahiro did similar idea)
- added module.lds if ia64 otherwise ia64 may fail to build.
- added clean-files rule to Makefile
- removed strip-comments script and doing it inline
- added set -e to header generated to die on errorsr
- fixed a minor issue where find command was noisy.
- removed unneeded tar.xz rule from kernel/.gitignore
- added Tested-by tags from ARM folks.
Changes since v3:
- Blank tar was being generated because of a one line I forgot to push. It is updated now.
- Added module.lds since arm64 needs it to build modules.
Changes since v2:
(Thanks to Masahiro Yamada for several excellent suggestions)
- Added support for out of tree builds.
- Added incremental build support bringing down build time of incremental builds from 50 seconds to 5 seconds.
- Fixed various small nits / cleanups.
- clean ups to kheaders.c pointed by Alexey Dobriyan.
- Fixed MODULE_LICENSE in test module and kheaders.c
- Dropped Module.symvers from archive due to circular dependency.
Changes since v1:
- removed IKH_EXTRA variable, not needed (Masahiro Yamada)
- small fix ups to selftest
- added target to main Makefile etc
- added MODULE_LICENSE to test module
- made selftest more quiet
Changes since RFC:
Both changes bring size down to 3.8MB:
- use xz for compression
- strip comments except SPDX lines
- Call out the module name in Kconfig
- Also added selftests in second patch to ensure headers are always working.
init/Kconfig | 10 +++++ kernel/.gitignore | 1 + kernel/Makefile | 10 +++++ kernel/gen_ikh_data.sh | 89 ++++++++++++++++++++++++++++++++++++++++++ kernel/kheaders.c | 74 +++++++++++++++++++++++++++++++++++ 5 files changed, 184 insertions(+) create mode 100755 kernel/gen_ikh_data.sh create mode 100644 kernel/kheaders.c
init/Kconfig +10 -0
@@ -580,6 +580,16 @@ config IKCONFIG_PROC This option enables access to the kernel configuration file through /proc/config.gz. +config IKHEADERS_PROC + tristate "Enable kernel header artifacts through /proc/kheaders.tar.xz" + depends on PROC_FS + help + This option enables access to the kernel header and other artifacts that + are generated during the build process. These can be used to build eBPF + tracing programs, or similar programs. If you build the headers as a + module, a module called kheaders.ko is built which can be loaded on-demand + to get access to the headers. + config LOG_BUF_SHIFT int "Kernel log buffer size (16 => 64KB, 17 => 128KB)" range 12 25
kernel/.gitignore +1 -0
@@ -1,5 +1,6 @@ # # Generated files # +kheaders.md5 timeconst.h hz.bc
kernel/Makefile +10 -0
@@ -70,6 +70,7 @@ obj-$(CONFIG_UTS_NS) += utsname.o obj-$(CONFIG_USER_NS) += user_namespace.o obj-$(CONFIG_PID_NS) += pid_namespace.o obj-$(CONFIG_IKCONFIG) += configs.o +obj-$(CONFIG_IKHEADERS_PROC) += kheaders.o obj-$(CONFIG_SMP) += stop_machine.o obj-$(CONFIG_KPROBES_SANITY_TEST) += test_kprobes.o obj-$(CONFIG_AUDIT) += audit.o auditfilter.o
@@ -121,3 +122,12 @@ $(obj)/configs.o: $(obj)/config_data.gz targets += config_data.gz $(obj)/config_data.gz: $(KCONFIG_CONFIG) FORCE $(call if_changed,gzip) + +$(obj)/kheaders.o: $(obj)/kheaders_data.tar.xz + +quiet_cmd_genikh = CHK $(obj)/kheaders_data.tar.xz +cmd_genikh = $(srctree)/kernel/gen_ikh_data.sh $@ +$(obj)/kheaders_data.tar.xz: FORCE + $(call cmd,genikh) + +clean-files := kheaders_data.tar.xz kheaders.md5
kernel/gen_ikh_data.sh new file +89 -0
89 lines not on this page · raw message
kernel/kheaders.c new file +74 -0
74 lines not on this page · raw message
Signature · 1 line
2.21.0.593.g511ec345e18-goog
PATCH RESEND v7 2/2 init/config: Do not select BUILD_BIN2C for IKCONFIG
Since commit 13610aa908dc ("kernel/configs: use .incbin directive to embed config_data.gz"), IKCONFIG no longer uses BUILD_BIN2C so prevent it from being selected in Kconfig.
--- init/Kconfig | 1 - 1 file changed, 1 deletion(-)
init/Kconfig +0 -1
@@ -562,7 +562,6 @@ config BUILD_BIN2C config IKCONFIG tristate "Kernel .config support" - select BUILD_BIN2C ---help--- This option enables the complete Linux kernel ".config" file contents to be saved in the kernel. It provides documentation
Signature · 1 line
2.21.0.593.g511ec345e18-goog
Quoted 34 lines · Joel Fernandes (Google)
Introduce in-kernel headers which are made available as an archive through proc (
/proc/kheaders.tar.xzfile). This archive makes it possible to run eBPF and other tracing programs that need to extend the kernel for tracing purposes without any dependency on the file system having headers.A github PR is sent for the corresponding BCC patch at:
https://github.com/iovisor/bcc/pull/2312On Android and embedded systems, it is common to switch kernels but not have kernel headers available on the file system. Further once a different kernel is booted, any headers stored on the file system will no longer be useful. This is an issue even well known to distros. By storing the headers as a compressed archive within the kernel, we can avoid these issues that have been a hindrance for a long time.
The best way to use this feature is by building it in. Several users have a need for this, when they switch debug kernels, they do not want to update the filesystem or worry about it where to store the headers on it. However, the feature is also buildable as a module in case the user desires it not being part of the kernel image. This makes it possible to load and unload the headers from memory on demand. A tracing program can load the module, do its operations, and then unload the module to save kernel memory. The total memory needed is 3.3MB.
By having the archive available at a fixed location independent of filesystem dependencies and conventions, all debugging tools can directly refer to the fixed location for the archive, without concerning with where the headers on a typical filesystem which significantly simplifies tooling that needs kernel headers.
The code to read the headers is based on
/proc/config.gzcode and uses the same technique to embed the headers.
Quoted 8 lines
Other approaches were discussed such as having an in-memory mountable filesystem, but that has drawbacks such as requiring an in-kernel xz decompressor which we don't have today, and requiring usage of 42 MB of kernel memory to host the decompressed headers at anytime. Also this approach is simpler than such approaches.
Reviewed-by Masahiro Yamada <yamada.masahiro at socionext.com>Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>
Quoted 41 lines · Greg KH
Quoted 40 lines · Joel Fernandes (Google)
Introduce in-kernel headers which are made available as an archive through proc (
/proc/kheaders.tar.xzfile). This archive makes it possible to run eBPF and other tracing programs that need to extend the kernel for tracing purposes without any dependency on the file system having headers.A github PR is sent for the corresponding BCC patch at:
https://github.com/iovisor/bcc/pull/2312On Android and embedded systems, it is common to switch kernels but not have kernel headers available on the file system. Further once a different kernel is booted, any headers stored on the file system will no longer be useful. This is an issue even well known to distros. By storing the headers as a compressed archive within the kernel, we can avoid these issues that have been a hindrance for a long time.
The best way to use this feature is by building it in. Several users have a need for this, when they switch debug kernels, they do not want to update the filesystem or worry about it where to store the headers on it. However, the feature is also buildable as a module in case the user desires it not being part of the kernel image. This makes it possible to load and unload the headers from memory on demand. A tracing program can load the module, do its operations, and then unload the module to save kernel memory. The total memory needed is 3.3MB.
By having the archive available at a fixed location independent of filesystem dependencies and conventions, all debugging tools can directly refer to the fixed location for the archive, without concerning with where the headers on a typical filesystem which significantly simplifies tooling that needs kernel headers.
The code to read the headers is based on
/proc/config.gzcode and uses the same technique to embed the headers.Other approaches were discussed such as having an in-memory mountable filesystem, but that has drawbacks such as requiring an in-kernel xz decompressor which we don't have today, and requiring usage of 42 MB of kernel memory to host the decompressed headers at anytime. Also this approach is simpler than such approaches.
Quoted 4 lines
Quoted 2 lines
Reviewed-by Masahiro Yamada <yamada.masahiro at socionext.com>Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Reviewed-by Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Thanks for the Reviewed-by tag. I believe there are still 2 logistical things to merge this.
1. Location of the header archive:
Olof and Steve did not like it to be in /proc and instead /sys seemed a better choice they are Ok with. Me and Greg were Ok with it being in /sys/kernel/. Alexei, Greg and me are Ok with either proc or Sys.
2. Who is going to pull this patch: This seems a matter of where the header archive resides. If it is in /sys/kernel/ then I am assuming Greg will pull it. Masahiro has given his Reviewed-by tag, is he the one to pull it?
Let us agree on these open questions so I can respin the patch to be based on that and move this forward.
thanks!
- Joel
Quoted 45 lines · Joel Fernandes
Quoted 44 lines · Greg KH
Quoted 42 lines · Joel Fernandes (Google)
Introduce in-kernel headers which are made available as an archive through proc (
/proc/kheaders.tar.xzfile). This archive makes it possible to run eBPF and other tracing programs that need to extend the kernel for tracing purposes without any dependency on the file system having headers.A github PR is sent for the corresponding BCC patch at:
https://github.com/iovisor/bcc/pull/2312On Android and embedded systems, it is common to switch kernels but not have kernel headers available on the file system. Further once a different kernel is booted, any headers stored on the file system will no longer be useful. This is an issue even well known to distros. By storing the headers as a compressed archive within the kernel, we can avoid these issues that have been a hindrance for a long time.
The best way to use this feature is by building it in. Several users have a need for this, when they switch debug kernels, they do not want to update the filesystem or worry about it where to store the headers on it. However, the feature is also buildable as a module in case the user desires it not being part of the kernel image. This makes it possible to load and unload the headers from memory on demand. A tracing program can load the module, do its operations, and then unload the module to save kernel memory. The total memory needed is 3.3MB.
By having the archive available at a fixed location independent of filesystem dependencies and conventions, all debugging tools can directly refer to the fixed location for the archive, without concerning with where the headers on a typical filesystem which significantly simplifies tooling that needs kernel headers.
The code to read the headers is based on
/proc/config.gzcode and uses the same technique to embed the headers.Other approaches were discussed such as having an in-memory mountable filesystem, but that has drawbacks such as requiring an in-kernel xz decompressor which we don't have today, and requiring usage of 42 MB of kernel memory to host the decompressed headers at anytime. Also this approach is simpler than such approaches.
Reviewed-by Masahiro Yamada <yamada.masahiro at socionext.com>Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>
Quoted 8 lines
Quoted 1 line
Reviewed-by Greg Kroah-Hartman <gregkh at linuxfoundation.org>Thanks for the Reviewed-by tag. I believe there are still 2 logistical things to merge this.
1. Location of the header archive:
Olof and Steve did not like it to be in /proc and instead /sys seemed a better choice they are Ok with. Me and Greg were Ok with it being in/sys/kernel/. Alexei, Greg and me are Ok with either proc or Sys.
As you say, either is fine with me.
Quoted 3 lines
2. Who is going to pull this patch: This seems a matter of where the header archive resides. If it is in
/sys/kernel/then I am assuming Greg will pull it. Masahiro has given his Reviewed-by tag, is he the one to pull it?
I can take it, but it probably should just go through the kbuild tree, as that makes more sense to me.
thanks,
greg k-h
Quoted 56 lines · Greg KH
Quoted 45 lines · Joel Fernandes
Quoted 44 lines · Greg KH
Quoted 42 lines · Joel Fernandes (Google)
Introduce in-kernel headers which are made available as an archive through proc (
/proc/kheaders.tar.xzfile). This archive makes it possible to run eBPF and other tracing programs that need to extend the kernel for tracing purposes without any dependency on the file system having headers.A github PR is sent for the corresponding BCC patch at:
https://github.com/iovisor/bcc/pull/2312On Android and embedded systems, it is common to switch kernels but not have kernel headers available on the file system. Further once a different kernel is booted, any headers stored on the file system will no longer be useful. This is an issue even well known to distros. By storing the headers as a compressed archive within the kernel, we can avoid these issues that have been a hindrance for a long time.
The best way to use this feature is by building it in. Several users have a need for this, when they switch debug kernels, they do not want to update the filesystem or worry about it where to store the headers on it. However, the feature is also buildable as a module in case the user desires it not being part of the kernel image. This makes it possible to load and unload the headers from memory on demand. A tracing program can load the module, do its operations, and then unload the module to save kernel memory. The total memory needed is 3.3MB.
By having the archive available at a fixed location independent of filesystem dependencies and conventions, all debugging tools can directly refer to the fixed location for the archive, without concerning with where the headers on a typical filesystem which significantly simplifies tooling that needs kernel headers.
The code to read the headers is based on
/proc/config.gzcode and uses the same technique to embed the headers.Other approaches were discussed such as having an in-memory mountable filesystem, but that has drawbacks such as requiring an in-kernel xz decompressor which we don't have today, and requiring usage of 42 MB of kernel memory to host the decompressed headers at anytime. Also this approach is simpler than such approaches.
Reviewed-by Masahiro Yamada <yamada.masahiro at socionext.com>Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Quoted 8 lines
Quoted 1 line
Reviewed-by Greg Kroah-Hartman <gregkh at linuxfoundation.org>Thanks for the Reviewed-by tag. I believe there are still 2 logistical things to merge this.
1. Location of the header archive:
Olof and Steve did not like it to be in /proc and instead /sys seemed a better choice they are Ok with. Me and Greg were Ok with it being in/sys/kernel/. Alexei, Greg and me are Ok with either proc or Sys.
Quoted 8 lines
As you say, either is fine with me.
Quoted 3 lines
2. Who is going to pull this patch: This seems a matter of where the header archive resides. If it is in
/sys/kernel/then I am assuming Greg will pull it. Masahiro has given his Reviewed-by tag, is he the one to pull it?I can take it, but it probably should just go through the kbuild tree, as that makes more sense to me.
I do not want to take responsibility for this.
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 63 lines · Masahiro Yamada
Quoted 62 lines · Greg KH
Quoted 45 lines · Joel Fernandes
Quoted 44 lines · Greg KH
Quoted 42 lines · Joel Fernandes (Google)
Introduce in-kernel headers which are made available as an archive through proc (
/proc/kheaders.tar.xzfile). This archive makes it possible to run eBPF and other tracing programs that need to extend the kernel for tracing purposes without any dependency on the file system having headers.A github PR is sent for the corresponding BCC patch at:
https://github.com/iovisor/bcc/pull/2312On Android and embedded systems, it is common to switch kernels but not have kernel headers available on the file system. Further once a different kernel is booted, any headers stored on the file system will no longer be useful. This is an issue even well known to distros. By storing the headers as a compressed archive within the kernel, we can avoid these issues that have been a hindrance for a long time.
The best way to use this feature is by building it in. Several users have a need for this, when they switch debug kernels, they do not want to update the filesystem or worry about it where to store the headers on it. However, the feature is also buildable as a module in case the user desires it not being part of the kernel image. This makes it possible to load and unload the headers from memory on demand. A tracing program can load the module, do its operations, and then unload the module to save kernel memory. The total memory needed is 3.3MB.
By having the archive available at a fixed location independent of filesystem dependencies and conventions, all debugging tools can directly refer to the fixed location for the archive, without concerning with where the headers on a typical filesystem which significantly simplifies tooling that needs kernel headers.
The code to read the headers is based on
/proc/config.gzcode and uses the same technique to embed the headers.Other approaches were discussed such as having an in-memory mountable filesystem, but that has drawbacks such as requiring an in-kernel xz decompressor which we don't have today, and requiring usage of 42 MB of kernel memory to host the decompressed headers at anytime. Also this approach is simpler than such approaches.
Reviewed-by Masahiro Yamada <yamada.masahiro at socionext.com>Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Quoted 8 lines
Quoted 1 line
Reviewed-by Greg Kroah-Hartman <gregkh at linuxfoundation.org>Thanks for the Reviewed-by tag. I believe there are still 2 logistical things to merge this.
1. Location of the header archive:
Olof and Steve did not like it to be in /proc and instead /sys seemed a better choice they are Ok with. Me and Greg were Ok with it being in/sys/kernel/. Alexei, Greg and me are Ok with either proc or Sys.As you say, either is fine with me.
Quoted 3 lines
2. Who is going to pull this patch: This seems a matter of where the header archive resides. If it is in
/sys/kernel/then I am assuming Greg will pull it. Masahiro has given his Reviewed-by tag, is he the one to pull it?
Quoted 5 lines
Quoted 2 lines
I can take it, but it probably should just go through the kbuild tree, as that makes more sense to me.
I do not want to take responsibility for this.
Hah, ok, I'll be glad to queue this up in my tree. I'll take it now, and if people who really object to this being in /proc/ and want it in /sys/, we can add a follow-on patch before 5.2-final is out to move the file to that location.
thanks,
greg k-h
Quoted 68 lines · Greg KH
Quoted 67 lines · Masahiro Yamada
Quoted 64 lines · Greg KH
Quoted 45 lines · Joel Fernandes
Quoted 44 lines · Greg KH
Quoted 42 lines · Joel Fernandes (Google)
Introduce in-kernel headers which are made available as an archive through proc (
/proc/kheaders.tar.xzfile). This archive makes it possible to run eBPF and other tracing programs that need to extend the kernel for tracing purposes without any dependency on the file system having headers.A github PR is sent for the corresponding BCC patch at:
https://github.com/iovisor/bcc/pull/2312On Android and embedded systems, it is common to switch kernels but not have kernel headers available on the file system. Further once a different kernel is booted, any headers stored on the file system will no longer be useful. This is an issue even well known to distros. By storing the headers as a compressed archive within the kernel, we can avoid these issues that have been a hindrance for a long time.
The best way to use this feature is by building it in. Several users have a need for this, when they switch debug kernels, they do not want to update the filesystem or worry about it where to store the headers on it. However, the feature is also buildable as a module in case the user desires it not being part of the kernel image. This makes it possible to load and unload the headers from memory on demand. A tracing program can load the module, do its operations, and then unload the module to save kernel memory. The total memory needed is 3.3MB.
By having the archive available at a fixed location independent of filesystem dependencies and conventions, all debugging tools can directly refer to the fixed location for the archive, without concerning with where the headers on a typical filesystem which significantly simplifies tooling that needs kernel headers.
The code to read the headers is based on
/proc/config.gzcode and uses the same technique to embed the headers.Other approaches were discussed such as having an in-memory mountable filesystem, but that has drawbacks such as requiring an in-kernel xz decompressor which we don't have today, and requiring usage of 42 MB of kernel memory to host the decompressed headers at anytime. Also this approach is simpler than such approaches.
Reviewed-by Masahiro Yamada <yamada.masahiro at socionext.com>Signed-off-by Joel Fernandes (Google) <joel at joelfernandes.org>Quoted 8 lines
Quoted 1 line
Reviewed-by Greg Kroah-Hartman <gregkh at linuxfoundation.org>Thanks for the Reviewed-by tag. I believe there are still 2 logistical things to merge this.
1. Location of the header archive:
Olof and Steve did not like it to be in /proc and instead /sys seemed a better choice they are Ok with. Me and Greg were Ok with it being in/sys/kernel/. Alexei, Greg and me are Ok with either proc or Sys.As you say, either is fine with me.
Quoted 3 lines
2. Who is going to pull this patch: This seems a matter of where the header archive resides. If it is in
/sys/kernel/then I am assuming Greg will pull it. Masahiro has given his Reviewed-by tag, is he the one to pull it?I can take it, but it probably should just go through the kbuild tree, as that makes more sense to me.
Quoted 6 lines
Quoted 1 line
I do not want to take responsibility for this.
Hah, ok, I'll be glad to queue this up in my tree. I'll take it now, and if people who really object to this being in
/proc/and want it in/sys/, we can add a follow-on patch before 5.2-final is out to move the file to that location.
Sounds great to me. thanks!
- Joel
Quoted 10 lines
Quoted 10 lines
Quoted 8 lines
As you say, either is fine with me.
Quoted 3 lines
2. Who is going to pull this patch: This seems a matter of where the header archive resides. If it is in
/sys/kernel/then I am assuming Greg will pull it. Masahiro has given his Reviewed-by tag, is he the one to pull it?I can take it, but it probably should just go through the kbuild tree, as that makes more sense to me.
Quoted 6 lines
Quoted 1 line
I do not want to take responsibility for this.
Hah, ok, I'll be glad to queue this up in my tree. I'll take it now, and if people who really object to this being in
/proc/and want it in/sys/, we can add a follow-on patch before 5.2-final is out to move the file to that location.
People really object to having it in kernel in the first place.
Pavel
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: <http://lists.linaro.org/pipermail/linux-kselftest-mirror/attachments/20190503/464ba2a2/attachment.sig>
Quoted 10 lines · Pavel Machek
Quoted 10 lines
Quoted 10 lines
Quoted 8 lines
As you say, either is fine with me.
Quoted 3 lines
2. Who is going to pull this patch: This seems a matter of where the header archive resides. If it is in
/sys/kernel/then I am assuming Greg will pull it. Masahiro has given his Reviewed-by tag, is he the one to pull it?I can take it, but it probably should just go through the kbuild tree, as that makes more sense to me.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
I do not want to take responsibility for this.
Hah, ok, I'll be glad to queue this up in my tree. I'll take it now, and if people who really object to this being in
/proc/and want it in/sys/, we can add a follow-on patch before 5.2-final is out to move the file to that location.People really object to having it in kernel in the first place.
Then do not select that .config option, and all is good :)
Quoted 4 lines · On Mon, 29 Apr 2019 16:24:25 +0200 Greg KH <gregkh at linuxfoundation.org>…
Hah, ok, I'll be glad to queue this up in my tree. I'll take it now, and if people who really object to this being in
/proc/and want it in/sys/, we can add a follow-on patch before 5.2-final is out to move the file to that location.
I really don't think putting it in /proc now is a good idea. Let's put it in /sys now. If we don't do it now and it gets into a main release, then that will become the permanent location for it.
-- Steve
Quoted 11 lines · Steven Rostedt
Quoted 4 lines · On Mon, 29 Apr 2019 16:24:25 +0200 Greg KH <[email protected]> wrote:
Hah, ok, I'll be glad to queue this up in my tree. I'll take it now, and if people who really object to this being in
/proc/and want it in/sys/, we can add a follow-on patch before 5.2-final is out to move the file to that location.I really don't think putting it in /proc now is a good idea. Let's put it in /sys now. If we don't do it now and it gets into a main release, then that will become the permanent location for it.
I will send a patch to move it into /sys/kernel on top of this. Hope everyone else is also Ok with that as the location.
thanks,
- Joel