Skip to contentSkip to conversation

drm/amd/powerplay: remove spurious semicolon

PATCH In review Andrea Righi 2 participants 2 messages May 3, 2019 – May 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/powerplay: remove spurious semicolon

Remove unnecessary semicolons at the end of line.

---
 drivers/gpu/drm/amd/powerplay/amd_powerplay.c         | 8 ++++----
 drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +4 -4
index 3f73f7cd18b9..1052f5119087 100644
@@ -1304,7 +1304,7 @@ static int pp_notify_smu_enable_pwe(void *handle)
 
 	if (hwmgr->hwmgr_func->smus_notify_pwe == NULL) {
 		pr_info_ratelimited("%s was not implemented.\n", __func__);
-		return -EINVAL;;
+		return -EINVAL;
 	}
 
 	mutex_lock(&hwmgr->smu_lock);
@@ -1341,7 +1341,7 @@ static int pp_set_min_deep_sleep_dcefclk(void *handle, uint32_t clock)
 
 	if (hwmgr->hwmgr_func->set_min_deep_sleep_dcefclk == NULL) {
 		pr_debug("%s was not implemented.\n", __func__);
-		return -EINVAL;;
+		return -EINVAL;
 	}
 
 	mutex_lock(&hwmgr->smu_lock);
@@ -1360,7 +1360,7 @@ static int pp_set_hard_min_dcefclk_by_freq(void *handle, uint32_t clock)
 
 	if (hwmgr->hwmgr_func->set_hard_min_dcefclk_by_freq == NULL) {
 		pr_debug("%s was not implemented.\n", __func__);
-		return -EINVAL;;
+		return -EINVAL;
 	}
 
 	mutex_lock(&hwmgr->smu_lock);
@@ -1379,7 +1379,7 @@ static int pp_set_hard_min_fclk_by_freq(void *handle, uint32_t clock)
 
 	if (hwmgr->hwmgr_func->set_hard_min_fclk_by_freq == NULL) {
 		pr_debug("%s was not implemented.\n", __func__);
-		return -EINVAL;;
+		return -EINVAL;
 	}
 
 	mutex_lock(&hwmgr->smu_lock);
drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c +1 -1
index c1c51c115e57..70f7f47a2fcf 100644
@@ -76,7 +76,7 @@ int phm_set_power_state(struct pp_hwmgr *hwmgr,
 int phm_enable_dynamic_state_management(struct pp_hwmgr *hwmgr)
 {
 	struct amdgpu_device *adev = NULL;
-	int ret = -EINVAL;;
+	int ret = -EINVAL;
 	PHM_FUNC_CHECK(hwmgr);
 	adev = hwmgr->adev;
 
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 80 lines

-----Original Message-----
From: Andrea Righi <[email protected]>
Sent: 2019年5月4日 0:56
To: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Zhou, David(ChunMing) <[email protected]>
Cc: Rex Zhu <[email protected]>; Wu, Hersen <[email protected]>; Quan, Evan <[email protected]>; [email protected]; dri- [email protected]; [email protected]
Subject: [PATCH] drm/amd/powerplay: remove spurious semicolon

[CAUTION: External Email]

Remove unnecessary semicolons at the end of line.

---
 drivers/gpu/drm/amd/powerplay/amd_powerplay.c         | 8 ++++----
 drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1 -1
index 3f73f7cd18b9..1052f5119087 100644
@@ -1304,7 +1304,7 @@ static int pp_notify_smu_enable_pwe(void
 *handle)
 
        if (hwmgr->hwmgr_func->smus_notify_pwe == NULL) {
                pr_info_ratelimited("%s was not implemented.\n", __func__);
-               return -EINVAL;;
+               return -EINVAL;
        }
 
        mutex_lock(&hwmgr->smu_lock);
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1 -1
@@ -1341,7 +1341,7 @@ static int pp_set_min_deep_sleep_dcefclk(void
 *handle, uint32_t clock)
 
        if (hwmgr->hwmgr_func->set_min_deep_sleep_dcefclk == NULL) {
                pr_debug("%s was not implemented.\n", __func__);
-               return -EINVAL;;
+               return -EINVAL;
        }
 
        mutex_lock(&hwmgr->smu_lock);
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1 -1
@@ -1360,7 +1360,7 @@ static int pp_set_hard_min_dcefclk_by_freq(void
 *handle, uint32_t clock)
 
        if (hwmgr->hwmgr_func->set_hard_min_dcefclk_by_freq == NULL) {
                pr_debug("%s was not implemented.\n", __func__);
-               return -EINVAL;;
+               return -EINVAL;
        }
 
        mutex_lock(&hwmgr->smu_lock);
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1 -1
@@ -1379,7 +1379,7 @@ static int pp_set_hard_min_fclk_by_freq(void
 *handle, uint32_t clock)
 
        if (hwmgr->hwmgr_func->set_hard_min_fclk_by_freq == NULL) {
                pr_debug("%s was not implemented.\n", __func__);
-               return -EINVAL;;
+               return -EINVAL;
        }
 
        mutex_lock(&hwmgr->smu_lock);
drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c +1 -2
index c1c51c115e57..70f7f47a2fcf 100644
@@ -76,7 +76,7 @@ int phm_set_power_state(struct pp_hwmgr *hwmgr,
 int phm_enable_dynamic_state_management(struct pp_hwmgr *hwmgr)  {
        struct amdgpu_device *adev = NULL;
-       int ret = -EINVAL;;
+       int ret = -EINVAL;
        PHM_FUNC_CHECK(hwmgr);
        adev = hwmgr->adev;
 
--
Quoted 1 line

2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx