Skip to contentSkip to conversation

board: am335x: Drop duplicate pinmux configuration

PATCH New paul at betafive.co.uk 2 participants 2 messages Apr 25, 2019 – May 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: am335x: Drop duplicate pinmux configuration

From: Paul Barker <[email protected]>

In commit ad6054f1fe128f797b6eb2964afca6674b584785 where support for the Sancloud BeagleBone Enhanced (BBE) was added, new conditional configuration of either MII pin muxing or RGMII pin muxing is done depending on the board type. However, the old call to set up MII pin muxing was not removed.

This may result in misconfiguration of the pin muxing for the BBE or duplicate configuration for other boards and so we remove this obsolete call.

---
 board/ti/am335x/mux.c | 1 -
 1 file changed, 1 deletion(-)
board/ti/am335x/mux.c +0 -1
index 04f4b8e6934..37a599768b1 100644
@@ -399,7 +399,6 @@ void enable_board_pin_mux(void)
 			configure_module_pin_mux(mii1_pin_mux);
 		}
 		/* Beaglebone LT pinmux */
-		configure_module_pin_mux(mii1_pin_mux);
 		configure_module_pin_mux(mmc0_pin_mux);
 #if defined(CONFIG_NAND) && defined(CONFIG_EMMC_BOOT)
 		configure_module_pin_mux(nand_pin_mux);
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 board: am335x: Drop duplicate pinmux configuration

Quoted 8 lines · paul at betafive.co.uk

From: Paul Barker <[email protected]>

In commit ad6054f1fe128f797b6eb2964afca6674b584785 where support for the Sancloud BeagleBone Enhanced (BBE) was added, new conditional configuration of either MII pin muxing or RGMII pin muxing is done depending on the board type. However, the old call to set up MII pin muxing was not removed.

Quoted 5 lines

This may result in misconfiguration of the pin muxing for the BBE or duplicate configuration for other boards and so we remove this obsolete call.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190503/ed156fc1/attachment.sig>