firmware: ti_sci: Always request response from firmware
PATCH 1/1 firmware: ti_sci: Always request response from firmware
TI-SCI firmware will only respond to messages when the TI_SCI_FLAG_REQ_ACK_ON_PROCESSED flag is set. Most messages already do this, set this for the ones that do not.
Signed-off-by Andrew F. Davis <[email protected]>
Tested-by Alejandro Hernandez <[email protected]>
--- drivers/firmware/ti_sci.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/firmware/ti_sci.c +6 -5
@@ -257,7 +257,8 @@ static int ti_sci_cmd_get_revision(struct ti_sci_handle *handle) info =handle_to_ti_sci_info (handle); - xfer =ti_sci_setup_one_xfer (info,TI_SCI_MSG_VERSION ,0x0 , + xfer =ti_sci_setup_one_xfer (info,TI_SCI_MSG_VERSION , +TI_SCI_FLAG_REQ_ACK_ON_PROCESSED , (u32 *)&hdr,sizeof (struct ti_sci_msg_hdr ),sizeof (*rev_info));if (IS_ERR (xfer)) {
@@ -499,8 +500,8 @@ static int ti_sci_get_device_state(const struct ti_sci_handle *handle, info =handle_to_ti_sci_info (handle); -/* Response is expected, so need of any flags */ - xfer =ti_sci_setup_one_xfer (info,TI_SCI_MSG_GET_DEVICE_STATE ,0 , + xfer =ti_sci_setup_one_xfer (info,TI_SCI_MSG_GET_DEVICE_STATE , +TI_SCI_FLAG_REQ_ACK_ON_PROCESSED , (u32 *)&req,sizeof (req),sizeof (*resp));if (IS_ERR (xfer)) { ret =PTR_ERR (xfer);
@@ -2574,8 +2575,8 @@ static int ti_sci_cmd_change_fwl_owner(const struct ti_sci_handle *handle, info =handle_to_ti_sci_info (handle); - xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_FWL_GET , -TISCI_MSG_FWL_CHANGE_OWNER , + xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_FWL_CHANGE_OWNER , +TI_SCI_FLAG_REQ_ACK_ON_PROCESSED , (u32 *)&req,sizeof (req),sizeof (*resp));if (IS_ERR (xfer)) { ret =PTR_ERR (xfer);
Signature · 1 line
2.21.0
Nishanth Menon
maintainerPATCH 1/1 firmware: ti_sci: Always request response from firmware
Quoted 9 lines · Andrew F. Davis
TI-SCI firmware will only respond to messages when the
TI_SCI_FLAG_REQ_ACK_ON_PROCESSEDflag is set. Most messages already do this, set this for the ones that do not.Signed-off-by Andrew F. Davis <[email protected]>Tested-by Alejandro Hernandez <[email protected]>--- drivers/firmware/ti_sci.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
Acked-by Nishanth Menon <[email protected]>
Signature · 2 lines
Regards, Nishanth Menon
PATCH 1/1 firmware: ti_sci: Always request response from firmware
In reply to Andrew F. DavisQuoted 7 lines · Andrew F. Davis
TI-SCI firmware will only respond to messages when the
TI_SCI_FLAG_REQ_ACK_ON_PROCESSEDflag is set. Most messages already do this, set this for the ones that do not.Signed-off-by Andrew F. Davis <[email protected]>Tested-by Alejandro Hernandez <[email protected]>Acked-by Nishanth Menon <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190503/47dfd9ad/attachment-0001.sig>