Skip to contentSkip to conversation

ARM: dts: logicpd-som-lv: Fix MMC1 card detect

PATCH New Adam Ford 2 participants 2 messages Apr 30, 2019 – May 3, 2019 Arm (32-bit)

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 ARM: dts: logicpd-som-lv: Fix MMC1 card detect

The card detect pin was incorrectly using IRQ_TYPE_LEVEL_LOW instead of GPIO_ACTIVE_LOW when reading the state of the CD pin.

Without this patch, MMC1 won't be detected.

This is the same patch submitted to linux-omap, but I was hoping to get it applied to U-Boot without having to wait for the linux adoption and then backporting.

Fixes 5448ff33f281 ("ARM: DTS: Resync Logic PD SOM-LV 37xx

devkit with Linux 4.18-RC4")

arch/arm/dts/logicpd-som-lv-baseboard.dtsi +2 -2
index 4990ed90dc..3524766515 100644
@@ -152,8 +152,8 @@
 	interrupts-extended = <&intc 83 &omap3_pmx_core 0x11a>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc1_pins>;
-	wp-gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>;		/* gpio_126 */
-	cd-gpios = <&gpio4 14 IRQ_TYPE_LEVEL_LOW>;		/* gpio_110 */
+	wp-gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>;	/* gpio_126 */
+	cd-gpios = <&gpio4 14 GPIO_ACTIVE_LOW>;		/* gpio_110 */
 	vmmc-supply = <&vmmc1>;
 	bus-width = <4>;
 	cap-power-off-card;
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 ARM: dts: logicpd-som-lv: Fix MMC1 card detect

arch/arm/dts/logicpd-som-lv-baseboard.dtsi

Quoted 16 lines · Adam Ford

The card detect pin was incorrectly using IRQ_TYPE_LEVEL_LOW instead of GPIO_ACTIVE_LOW when reading the state of the CD pin.

Without this patch, MMC1 won't be detected.

This is the same patch submitted to linux-omap, but I was hoping to get it applied to U-Boot without having to wait for the linux adoption and then backporting.

Fixes 5448ff33f281 ("ARM: DTS: Resync Logic PD SOM-LV 37xx

devkit with Linux 4.18-RC4")

arch/arm/dts/logicpd-som-lv-baseboard.dtsi +0 -0
index 4990ed90dc..3524766515 100644

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190503/cd15243c/attachment.sig>