Skip to contentSkip to conversation

staging: rtl8723bs: core: Move logical operator to previous line.

PATCH In review Vatsala Narang 2 participants 2 messages May 5, 2019 – May 13, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 6/6 staging: rtl8723bs: core: Move logical operator to previous line.

Move logical operator to previous line to get rid of checkpatch warning.

---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +3 -3
index 0b5bd047a552..b5e355de1199 100644
@@ -5656,9 +5656,9 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
 	);
 	#endif
 
-	if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta))
-		&& sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta)
-		&& sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
+	if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta)) &&
+	    sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta) &&
+	     sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
 	) {
 		ret = false;
 	} else {
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 12 lines · Vatsala Narang

Move logical operator to previous line to get rid of checkpatch warning.

---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -0
index 0b5bd047a552..b5e355de1199 100644

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta) · line 5661

Quoted 9 lines
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +3 -3
@@ -5656,9 +5656,9 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
 	);
 	#endif
 
-	if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta))
-		&& sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta)
-		&& sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
+	if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta)) &&
+	    sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta) &&
+	     sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)

Odd, you should align these two lines, right?

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta) · line 5662

Quoted 1 line
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -0
 	) {

This should go on the previous line.

thanks,

greg k-h