iio: dac: ds4422/ds4424 fix chip verification
PATCH 2/2 iio: dac: ds4422/ds4424 fix chip verification
The ds4424_get_value function takes channel number as it's 3rd argument and translates it internally into I2C address using DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an already translated I2C address as its last argument.
Signed-off-by Ruslan Babayev <[email protected]>
--- drivers/iio/dac/ds4424.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/dac/ds4424.c +1 -1
@@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev) {int ret, val; - ret =ds4424_get_value (indio_dev, &val,DS4424_DAC_ADDR (0 )); + ret =ds4424_get_value (indio_dev, &val,0 );if (ret <0 )dev_err (&indio_dev->dev,"%s failed. ret: %d\n" , __func__, ret);
Signature · 1 line
2.17.1
Quoted 7 lines · On Sun, 5 May 2019 12:24:37 -0700 Ruslan Babayev <[email protected]> wrote:
The
ds4424_get_valuefunction takes channel number as it's 3rd argument and translates it internally into I2C address usingDS4424_DAC_ADDRmacro. The callerds4424_verify_chipwas passing an already translated I2C address as its last argument.Signed-off-by Ruslan Babayev <[email protected]>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
Quoted 17 lines
--- drivers/iio/dac/ds4424.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/dac/ds4424.c +1
-1@@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev) {int ret, val; - ret =ds4424_get_value (indio_dev, &val,DS4424_DAC_ADDR (0 )); + ret =ds4424_get_value (indio_dev, &val,0 );if (ret <0 )dev_err (&indio_dev->dev,"%s failed. ret: %d\n" , __func__, ret);