Skip to contentSkip to conversation

hw/display/cirrus_vga: Remove unused include

PATCH In review Philippe Mathieu-Daudé 3 participants 3 messages May 5, 2019 – May 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/display/cirrus_vga: Remove unused include

Commit ce3cf70edaaf split the ISA device out of the PCI one, but forgot to remove the "hw/loader.h" header inclusion (the ISA device calls rom_add_vga()). Remove the now unused include.

---
 hw/display/cirrus_vga.c | 1 -
 1 file changed, 1 deletion(-)
hw/display/cirrus_vga.c +0 -1
index a0e71469f4d..f67df3c1f6f 100644
@@ -33,7 +33,6 @@
 #include "hw/hw.h"
 #include "hw/pci/pci.h"
 #include "ui/pixel_ops.h"
-#include "hw/loader.h"
 #include "cirrus_vga_internal.h"
 
 /*
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Philippe Mathieu-Daudé

Commit ce3cf70edaaf split the ISA device out of the PCI one, but forgot to remove the "hw/loader.h" header inclusion (the ISA device calls rom_add_vga()). Remove the now unused include.

---
 hw/display/cirrus_vga.c | 1 -
 1 file changed, 1 deletion(-)
hw/display/cirrus_vga.c +0 -0
index a0e71469f4d..f67df3c1f6f 100644

hw/display/cirrus_vga.c line 36

Quoted 5 lines
hw/display/cirrus_vga.c +0 -1
@@ -33,7 +33,6 @@
 #include "hw/hw.h"
 #include "hw/pci/pci.h"
 #include "ui/pixel_ops.h"
-#include "hw/loader.h"
 #include "cirrus_vga_internal.h"
#2 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 3 lines · Philippe Mathieu-Daudé

Commit ce3cf70edaaf split the ISA device out of the PCI one, but forgot to remove the "hw/loader.h" header inclusion (the ISA device calls rom_add_vga()). Remove the now unused include.

Added to vga queue.

thanks,
Gerd