Skip to contentSkip to conversation

Use SPL_FIT_IMAGE_TINY to reduce the size the SPL for the am335x_evm

PATCH New Jean-Jacques Hiblot 3 participants 7 messages Apr 26, 2019 – May 6, 2019

lore
Share & tools
lore
#0 lore raw

cover Use SPL_FIT_IMAGE_TINY to reduce the size the SPL for the am335x_evm

Patch #1 handles a corner case: SPL_FIT_IMAGE and SPL_OS_BOOT at the same time
Patch #2 enables SPL_FIT_IMAGE_TINY for the am335x_evm platform

Jean-Jacques Hiblot (2):
spl: fit: Always enable tracking of os-type if SPL_OS_BOOT is enabled
configs: am335x_evm: enable SPL_FIT_IMAGE_TINY

 common/spl/spl_fit.c         | 2 +-
 configs/am335x_evm_defconfig | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 spl: fit: Always enable tracking of os-type if SPL_OS_BOOT is enabled

FIT_IMAGE_TINY is used to reduce the size of the SPL by removing os-type tracking and recording the loadables into the loaded FDT. When this option is enabled, it is assumed that the next stage firmware is u-boot. However this does not play well with the SPL_OS_BOOT option that enables loading different type of next stage firmware, like the OS itself.

When SPL_OS_BOOT is used, do not disable os-tracking. The added footprint is about 300 Bytes.

---

 common/spl/spl_fit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl_fit.c +1 -1
index c9bfe0cc8a..87ecf0bb9e 100644
@@ -333,7 +333,7 @@ static int spl_fit_record_loadable(const void *fit, int images, int index,
 
 static int spl_fit_image_get_os(const void *fit, int noffset, uint8_t *os)
 {
-#if CONFIG_IS_ENABLED(FIT_IMAGE_TINY)
+#if CONFIG_IS_ENABLED(FIT_IMAGE_TINY) && !defined(CONFIG_SPL_OS_BOOT)
 	return -ENOTSUPP;
 #else
 	return fit_image_get_os(fit, noffset, os);
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/2 spl: fit: Always enable tracking of os-type if SPL_OS_BOOT is enabled

Quoted 10 lines · Jean-Jacques Hiblot

FIT_IMAGE_TINY is used to reduce the size of the SPL by removing os-type tracking and recording the loadables into the loaded FDT. When this option is enabled, it is assumed that the next stage firmware is u-boot. However this does not play well with the SPL_OS_BOOT option that enables loading different type of next stage firmware, like the OS itself.

When SPL_OS_BOOT is used, do not disable os-tracking. The added footprint is about 300 Bytes.

Thanks and regards,
Lokesh

#3 lore raw

PATCH 1/2 spl: fit: Always enable tracking of os-type if SPL_OS_BOOT is enabled

In reply to Jean-Jacques Hiblot
Quoted 11 lines · Jean-Jacques Hiblot

FIT_IMAGE_TINY is used to reduce the size of the SPL by removing os-type tracking and recording the loadables into the loaded FDT. When this option is enabled, it is assumed that the next stage firmware is u-boot. However this does not play well with the SPL_OS_BOOT option that enables loading different type of next stage firmware, like the OS itself.

When SPL_OS_BOOT is used, do not disable os-tracking. The added footprint is about 300 Bytes.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190506/815f7943/attachment.sig>
#4 lore raw

PATCH 2/2 configs: am335x_evm: enable SPL_FIT_IMAGE_TINY

In reply to Jean-Jacques Hiblot

The size of the SPL for the am335x_evm is constrained. There is no need to have advanced SPL FIT features, so keep the SPL FIT support tiny.

---

 configs/am335x_evm_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/am335x_evm_defconfig +1 -0
index 105ff01d14..81fee7bcb0 100644
@@ -11,6 +11,7 @@ CONFIG_LOGLEVEL=3
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
 CONFIG_ARCH_MISC_INIT=y
+CONFIG_SPL_FIT_IMAGE_TINY=y
 CONFIG_SPL_ETH_SUPPORT=y
 # CONFIG_SPL_FS_EXT4 is not set
 CONFIG_SPL_MTD_SUPPORT=y
Signature · 1 line
2.17.1
#5 lore raw

PATCH 2/2 configs: am335x_evm: enable SPL_FIT_IMAGE_TINY

Quoted 4 lines · Jean-Jacques Hiblot

The size of the SPL for the am335x_evm is constrained. There is no need to have advanced SPL FIT features, so keep the SPL FIT support tiny.

Thanks and regards,
Lokesh

Quoted 19 lines

---

 configs/am335x_evm_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/am335x_evm_defconfig +1 -0
index 105ff01d14..81fee7bcb0 100644
@@ -11,6 +11,7 @@ CONFIG_LOGLEVEL=3
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
 CONFIG_ARCH_MISC_INIT=y
+CONFIG_SPL_FIT_IMAGE_TINY=y
 CONFIG_SPL_ETH_SUPPORT=y
 # CONFIG_SPL_FS_EXT4 is not set
 CONFIG_SPL_MTD_SUPPORT=y
#6 lore raw

PATCH 2/2 configs: am335x_evm: enable SPL_FIT_IMAGE_TINY

In reply to Jean-Jacques Hiblot
Quoted 5 lines · Jean-Jacques Hiblot

The size of the SPL for the am335x_evm is constrained. There is no need to have advanced SPL FIT features, so keep the SPL FIT support tiny.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190506/69b5a486/attachment.sig>