samples: bpf: fix style in bpf_load
Subsystems (3)
PATCH 1/1 samples: bpf: fix style in bpf_load
This commit fixes style problem in samples/bpf/bpf_load.c
Styles that have been changed are:
- Magic string use of 'DEBUGFS'
- Useless zero initialization of a global variable
- Minor style fix with whitespace
Signed-off-by Daniel T. Lee <[email protected]>
--- samples/bpf/bpf_load.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
samples/bpf/bpf_load.c +7 -4
@@ -40,7 +40,7 @@ int prog_cnt;int prog_array_fd =-1 ;struct bpf_map_data map_data[MAX_MAPS ]; -int map_data_count =0 ; +int map_data_count;static int populate_prog_array (const char *event,int prog_fd) {
@@ -57,6 +57,7 @@ static int populate_prog_array(const char *event, int prog_fd)static int write_kprobe_events (const char *val) {int fd, ret, flags; +char buf[256 ];if (val ==NULL )return -1 ;
@@ -65,7 +66,9 @@ static int write_kprobe_events(const char *val)else flags =O_WRONLY |O_APPEND ; - fd =open ("/sys/kernel/debug/tracing/kprobe_events" , flags); +strcpy (buf,DEBUGFS ); +strcat (buf,"kprobe_events" ); + fd =open (buf, flags); ret =write (fd, val,strlen (val));close (fd);
@@ -490,8 +493,8 @@ static int load_elf_maps_section(struct bpf_map_data *maps, int maps_shndx,/* Verify no newer features were requested */ if (validate_zero) { - addr = (unsigned char *) def + map_sz_copy; - end = (unsigned char *) def + map_sz_elf; + addr = (unsigned char *) def + map_sz_copy; + end = (unsigned char *) def + map_sz_elf;for (; addr < end; addr++) {if (*addr !=0 ) {free (sym);
Signature · 1 line
2.17.1
Quoted 9 lines · Daniel T. Lee
This commit fixes style problem in
samples/bpf/bpf_load.cStyles that have been changed are:
- Magic string use of 'DEBUGFS'
- Useless zero initialization of a global variable
- Minor style fix with whitespaceSigned-off-by Daniel T. Lee <[email protected]>
bpf-next is closed. Pls resubmit in about 2 weeks
or watch for 'bpf-next is open' email.