lib/igt_edid: fix detailed pixel timing analog/digital

PATCH New Simon Ser 2 participants 3 messages May 6, 2019 Library code

Share & tools

Simon Ser

author

2019-05-06 14:30 UTC #0 lore raw

PATCH v3 1/1 lib/igt_edid: fix detailed pixel timing analog/digital

The generated EDIDs were wrongly indicating that they support analog sync. Fixup the detailed timings flags to advertise digital sync instead.

Currently the Linux kernel seems to ignore this completely. However I'd prefer to fix this anyway to make sure we don't run into issues if an EDID consumer actually cares about it.

The header definitions for EDID_PT_* values has been re-organized to make it clearer in which situations the flags are relevant.

Changes from v1 to v2:
- Fix misleading commit message
- Revert the "misc" → "features" rename
- Re-organize EDID_PT_* definitions to make them clearer

Changes from v2 to v3:
- Include review changelog in commit message
- Fix "Fixes:" tag to conform to the kernel style
- Re-order EDID_PT_* definitions to sort by descending bitshift

Signed-off-by Simon Ser <[email protected]>

Reviewed-by Ville Syrjälä <[email protected]>

Fixes a2fd0489c87a ("lib/igt_edid: new library for generating EDIDs")

---
 lib/igt_edid.c |  2 +-
 lib/igt_edid.h | 16 +++++++++++-----
 2 files changed, 12 insertions(+), 6 deletions(-)

lib/igt_edid.c +1 -1

index 52e66ab289a7..9d604b13c4d6 100644
@@ -110,7 +110,7 @@ void detailed_timing_set_mode(struct detailed_timing *dt, drmModeModeInfo *mode,
 	pt->width_height_mm_hi = (width_mm & 0xF00) >> 4
 				 | (height_mm & 0xF00) >> 8;
 
-	pt->misc = 0;
+	pt->misc = EDID_PT_SYNC_DIGITAL_SEPARATE;
 	if (mode->flags & DRM_MODE_FLAG_PHSYNC)
 		pt->misc |= EDID_PT_HSYNC_POSITIVE;
 	if (mode->flags & DRM_MODE_FLAG_PVSYNC)

lib/igt_edid.h +11 -5

index bbcb939a2dbe..36eec7e9dedb 100644
@@ -52,11 +52,17 @@ struct std_timing {
 
 #define DETAILED_TIMINGS_LEN 4
 
-#define EDID_PT_HSYNC_POSITIVE (1 << 1)
+#define EDID_PT_INTERLACED (1 << 7)
+#define EDID_PT_STEREO (1 << 5)
+
+/* Sync type */
+#define EDID_PT_SYNC_ANALOG (0b00 << 3)
+#define EDID_PT_SYNC_DIGITAL_COMPOSITE (0b10 << 3)
+#define EDID_PT_SYNC_DIGITAL_SEPARATE (0b11 << 3)
+
+/* Applies to EDID_PT_SYNC_DIGITAL_SEPARATE only */
 #define EDID_PT_VSYNC_POSITIVE (1 << 2)
-#define EDID_PT_SEPARATE_SYNC  (3 << 3)
-#define EDID_PT_STEREO         (1 << 5)
-#define EDID_PT_INTERLACED     (1 << 7)
+#define EDID_PT_HSYNC_POSITIVE (1 << 1)
 
 struct detailed_pixel_timing {
 	uint8_t hactive_lo;

@@ -74,7 +80,7 @@ struct detailed_pixel_timing {
 	uint8_t width_height_mm_hi;
 	uint8_t hborder;
 	uint8_t vborder;
-	uint8_t misc;
+	uint8_t misc; /* EDID_PT_* */
 } __attribute__((packed));
 
 struct detailed_data_string {

--
2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-05-06 15:05 UTC #1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_edid: fix detailed pixel timing analog/digital (rev3)

== Series Details ==

Series: lib/igt_edid: fix detailed pixel timing analog/digital (rev3)
URL : https://patchwork.freedesktop.org/series/59938/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6050 -> IGTPW_2944
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59938/revisions/3/mbox/

Known issues
------------

Here are the changes found in IGTPW_2944 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108569])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/fi-icl-y/igt@i915_selftest@live_hangcheck.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#110390]: https://bugs.freedesktop.org/show_bug.cgi?id=110390

Participating hosts (54 -> 44)
------------------------------

Missing (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 fi-pnv-d510 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* IGT: IGT_4972 -> IGTPW_2944

CI_DRM_6050: 79f967620fe91fad840b71a0df86bbb45f9f70a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2944: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/
IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2019-05-06 17:39 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_edid: fix detailed pixel timing analog/digital (rev3)

In reply to Simon Ser

== Series Details ==

Series: lib/igt_edid: fix detailed pixel timing analog/digital (rev3)
URL : https://patchwork.freedesktop.org/series/59938/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6050_full -> IGTPW_2944_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59938/revisions/3/mbox/

Known issues
------------

Here are the changes found in IGTPW_2944_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-kbl: [PASS][1] -> [FAIL][2] ([fdo#103232])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-kbl6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-kbl4/igt@[email protected]
- shard-apl: [PASS][3] -> [FAIL][4] ([fdo#103232])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-apl8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-apl4/igt@[email protected]

* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: [PASS][5] -> [INCOMPLETE][6] ([fdo#103665])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-kbl5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-kbl1/igt@[email protected]

* igt@kms_flip@bo-too-big-interruptible:
- shard-hsw: [PASS][7] -> [INCOMPLETE][8] ([fdo#103540]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-hsw7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-hsw2/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-apl: [PASS][9] -> [INCOMPLETE][10] ([fdo#103927])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-apl8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-apl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-iclb3/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-iclb2/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103166])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-iclb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-iclb7/igt@[email protected]

* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: [PASS][15] -> [SKIP][16] ([fdo#109271] / [fdo#109278])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-glk9/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-glk5/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: [PASS][19] -> [FAIL][20] ([fdo#109016])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-kbl2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-kbl4/igt@[email protected]

* igt@kms_vblank@pipe-b-query-idle:
- shard-snb: [PASS][21] -> [SKIP][22] ([fdo#109271])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-snb4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-snb2/igt@[email protected]

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([fdo#108566]) +6 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-apl5/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-apl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][25] ([fdo#108566]) -> [PASS][26] +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-apl4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-apl2/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][27] ([fdo#109661]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-snb1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-snb5/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [DMESG-WARN][29] ([fdo#108686]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-glk2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-glk6/igt@[email protected]
- shard-kbl: [DMESG-WARN][31] ([fdo#108686]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-kbl5/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-kbl1/igt@[email protected]

* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-glk: [INCOMPLETE][33] ([fdo#103359] / [k.org#198133]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-glk8/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-glk7/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][35] ([fdo#103540]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-hsw7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-hsw6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: [FAIL][37] ([fdo#103167]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-glk2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-glk2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: [SKIP][41] ([fdo#109271]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-glk6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-glk9/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][43] ([fdo#109642]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-iclb6/igt@kms_psr2_su@page_flip.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-iclb2/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-iclb5/igt@kms_psr@psr2_primary_page_flip.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_setmode@basic:
- shard-kbl: [FAIL][47] ([fdo#99912]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-kbl4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-kbl1/igt@[email protected]

* igt@tools_test@tools_test:
- shard-iclb: [SKIP][49] ([fdo#109352]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-iclb2/igt@tools_test@tools_test.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-iclb1/igt@tools_test@tools_test.html

#### Warnings ####

* igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing:
- shard-snb: [SKIP][51] ([fdo#109271] / [fdo#109278]) -> [SKIP][52] ([fdo#109271])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6050/shard-snb5/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2944/shard-snb2/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing.html

Participating hosts (10 -> 6)
------------------------------

Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005

Build changes
-------------

* IGT: IGT_4972 -> IGTPW_2944
* Piglit: piglit_4509 -> None

== Logs ==