net: ll_temac: Improve error message on error IRQ
PATCH 1/1 net: ll_temac: Improve error message on error IRQ
The channel status register value can be very helpful when debugging SDMA problems.
Signed-off-by Esben Haabendal <[email protected]>
--- drivers/net/ethernet/xilinx/ll_temac_main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/net/ethernet/xilinx/ll_temac_main.c +8 -2
@@ -886,8 +886,10 @@ static irqreturn_t ll_temac_tx_irq(int irq, void *_ndev)if (status & (IRQ_COAL |IRQ_DLY ))temac_start_xmit_done (lp->ndev); -if (status &0x080 ) -dev_err (&ndev->dev,"DMA error 0x%x\n" , status); +if (status & (IRQ_ERR |IRQ_DMAERR )) +dev_err_ratelimited (&ndev->dev, +"TX error 0x%x TX_CHNL_STS=0x%08x\n" , + status, lp->dma_in (lp,TX_CHNL_STS ));return IRQ_HANDLED ; }
@@ -904,6 +906,10 @@ static irqreturn_t ll_temac_rx_irq(int irq, void *_ndev)if (status & (IRQ_COAL |IRQ_DLY ))ll_temac_recv (lp->ndev); +if (status & (IRQ_ERR |IRQ_DMAERR )) +dev_err_ratelimited (&ndev->dev, +"RX error 0x%x RX_CHNL_STS=0x%08x\n" , + status, lp->dma_in (lp,RX_CHNL_STS ));return IRQ_HANDLED ; }
Signature · 1 line
2.4.11
From: Esben Haabendal <[email protected]>
Date: Tue, 7 May 2019 08:42:57 +0200
Quoted 4 lines
The channel status register value can be very helpful when debugging SDMA problems.
Signed-off-by Esben Haabendal <[email protected]>
Applied.