Skip to contentSkip to conversation

hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device

PATCH In review Philippe Mathieu-Daudé 1 participant 2 messages May 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device

The Q35 machine uses the ICH9 chipset which is composed of various sub-devices. There is currently no generic Kconfig selector that selects all the required devices. Meanwhile, force the Q35 machine to select the 'ich9-ahci' device.

This fixes:

  $ ./configure --without-default-devices && \
    ./i386-softmmu/qemu-system-i386 -nodefaults -M q35
  qemu-system-i386: Unknown device 'ich9-ahci' for bus 'PCIE'
  Aborted (core dumped)
---
 hw/i386/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/Kconfig +1 -1
index a6aed7c1313..98178882169 100644
@@ -80,7 +80,7 @@ config Q35
     select PC_ACPI
     select PCI_EXPRESS_Q35
     select LPC_ICH9
-    select AHCI
+    select AHCI_ICH9
     select DIMM
     select SMBIOS
     select VMPORT
Signature · 1 line
2.20.1
#1 lore raw
Quoted 7 lines · Philippe Mathieu-Daudé

The Q35 machine uses the ICH9 chipset which is composed of various sub-devices. There is currently no generic Kconfig selector that selects all the required devices. Meanwhile, force the Q35 machine to select the 'ich9-ahci' device.

This fixes:

Quoted 8 lines
  $ ./configure --without-default-devices && \
    ./i386-softmmu/qemu-system-i386 -nodefaults -M q35
  qemu-system-i386: Unknown device 'ich9-ahci' for bus 'PCIE'
  Aborted (core dumped)

---

I forgot:

Based-on: <[email protected]> "hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device"

Quoted 17 lines
 hw/i386/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/Kconfig +1 -1
index a6aed7c1313..98178882169 100644
@@ -80,7 +80,7 @@ config Q35
     select PC_ACPI
     select PCI_EXPRESS_Q35
     select LPC_ICH9
-    select AHCI
+    select AHCI_ICH9
     select DIMM
     select SMBIOS
     select VMPORT