Skip to contentSkip to conversation

livepatch: Remove stale kobj_added entries from kernel-doc descriptions

PATCH Applied Miroslav Benes 4 participants 4 messages May 7, 2019 – May 9, 2019 Live patching

lore
Share & tools
lore

Miroslav Benes

author maintainer
#0 lore raw

PATCH 1/1 livepatch: Remove stale kobj_added entries from kernel-doc descriptions

Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling") removed kobj_added members of klp_func, klp_object and klp_patch structures. kernel-doc descriptions were omitted by accident. Remove them.

---
 include/linux/livepatch.h | 3 ---
 1 file changed, 3 deletions(-)
include/linux/livepatch.h +0 -3
index a14bab1a0a3e..955d46f37b72 100644
@@ -47,7 +47,6 @@
  * @stack_node:	list node for klp_ops func_stack list
  * @old_size:	size of the old function
  * @new_size:	size of the new function
- * @kobj_added: @kobj has been added and needs freeing
  * @nop:        temporary patch to use the original code again; dyn. allocated
  * @patched:	the func has been added to the klp_ops list
  * @transition:	the func is currently being applied or reverted
@@ -125,7 +124,6 @@ struct klp_callbacks {
  * @node:	list node for klp_patch obj_list
  * @mod:	kernel module associated with the patched object
  *		(NULL for vmlinux)
- * @kobj_added: @kobj has been added and needs freeing
  * @dynamic:    temporary object for nop functions; dynamically allocated
  * @patched:	the object's funcs have been added to the klp_ops list
  */
@@ -152,7 +150,6 @@ struct klp_object {
  * @list:	list node for global list of actively used patches
  * @kobj:	kobject for sysfs resources
  * @obj_list:	dynamic list of the object entries
- * @kobj_added: @kobj has been added and needs freeing
  * @enabled:	the patch is enabled (but operation may be incomplete)
  * @forced:	was involved in a forced transition
  * @free_work:	patch cleanup from workqueue-context
Signature · 1 line
2.21.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 33 lines · Miroslav Benes

Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling") removed kobj_added members of klp_func, klp_object and klp_patch structures. kernel-doc descriptions were omitted by accident. Remove them.

---
  include/linux/livepatch.h | 3 ---
  1 file changed, 3 deletions(-)
include/linux/livepatch.h +0 -2
index a14bab1a0a3e..955d46f37b72 100644
@@ -47,7 +47,6 @@
   * @stack_node:	list node for klp_ops func_stack list
   * @old_size:	size of the old function
   * @new_size:	size of the new function
- * @kobj_added: @kobj has been added and needs freeing
   * @nop:        temporary patch to use the original code again; dyn. allocated
   * @patched:	the func has been added to the klp_ops list
   * @transition:	the func is currently being applied or reverted
@@ -125,7 +124,6 @@ struct klp_callbacks {
   * @node:	list node for klp_patch obj_list
   * @mod:	kernel module associated with the patched object
   *		(NULL for vmlinux)
- * @kobj_added: @kobj has been added and needs freeing
   * @dynamic:    temporary object for nop functions; dynamically allocated
   * @patched:	the object's funcs have been added to the klp_ops list
   */

include/linux/livepatch.h struct klp_object { · line 155

Quoted 7 lines
include/linux/livepatch.h +0 -1
@@ -152,7 +150,6 @@ struct klp_object {
   * @list:	list node for global list of actively used patches
   * @kobj:	kobject for sysfs resources
   * @obj_list:	dynamic list of the object entries
- * @kobj_added: @kobj has been added and needs freeing
   * @enabled:	the patch is enabled (but operation may be incomplete)
   * @forced:	was involved in a forced transition
   * @free_work:	patch cleanup from workqueue-context

D'oh, missed that in the review. Good eye, Kamalesh.

-- Joe

Reviewed-by on v1 1/1
#2 lore raw
In reply to Miroslav Benes
Quoted 7 lines · Miroslav Benes

Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling") removed kobj_added members of klp_func, klp_object and klp_patch structures. kernel-doc descriptions were omitted by accident. Remove them.

Signature · 1 line
Kamalesh
Applied
#3 lore raw
In reply to Miroslav Benes
Quoted 4 lines · Miroslav Benes

Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling") removed kobj_added members of klp_func, klp_object and klp_patch structures. kernel-doc descriptions were omitted by accident. Remove them.

Applied to for-5.2/fixes. Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs