Skip to contentSkip to conversation

wireless: Skip directory when generating certificates

PATCH New Maxim Mikityanskiy 1 participant 1 message May 7, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wireless: Skip directory when generating certificates

Commit 715a12334764 ("wireless: don't write C files on failures") drops the test -f $$f check. The list of targets contains the CONFIG_CFG80211_EXTRA_REGDB_KEYDIR directory itself, and this check used to filter it out. After the check was removed, the extra keydir option no longer works, failing with the following message:

od: 'standard input': read error: Is a directory

This commit restores the check to make extra keydir work again.

Fixes 715a12334764 ("wireless: don't write C files on failures")
---
 net/wireless/Makefile | 1 +
 1 file changed, 1 insertion(+)
net/wireless/Makefile +1 -0
index 72a224ce8..2eee93985 100644
@@ -39,6 +39,7 @@ $(obj)/extra-certs.c: $(CONFIG_CFG80211_EXTRA_REGDB_KEYDIR:"%"=%) \
 	@(set -e; \
 	  allf=""; \
 	  for f in $^ ; do \
+	      test -f $$f || continue;\
 	      # similar to hexdump -v -e '1/1 "0x%.2x," "\n"' \
 	      thisf=$$(od -An -v -tx1 < $$f | \
 	                   sed -e 's/ /\n/g' | \
Signature · 1 line
2.21.0