Skip to contentSkip to conversation

rockchip: rk3399: orangepi: Add SPL_TEXT_BASE

PATCH In review Jagan Teki 2 participants 2 messages May 7, 2019 – May 8, 2019 1 message not in the archive Arm Rockchip

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 rockchip: rk3399: orangepi: Add SPL_TEXT_BASE

CONFIG_SPL_TEXT_BASE was available in configs/rk3399_common.h when the OrangePI rk3399 board supported during first version patch.

But, later below change which move this config into Kconfig and same has been merged in mainline tree.
"configs: move CONFIG_SPL_TEXT_BASE to Kconfig" (sha1: f89d6133eef2e068f9c33853b6584d7fcbfa9d2e)

Unfortunately, the maintainer applied the initial version patch, instead of looking for next version changes.

Fix it by adding SPL_TEXT_BASE in orangepi-rk3399 defconfig.

---
 configs/orangepi-rk3399_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/orangepi-rk3399_defconfig +1 -0
index cdccf221b5..ba13976cc6 100644
@@ -17,6 +17,7 @@ CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py"
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-orangepi.dtb"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_SPL_TEXT_BASE=0xff8c2000
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
 CONFIG_SPL_ATF=y
Signature · 6 lines
2.18.0.321.gffc6fa0e3

_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot

A message that is not in the archive (sent off-list or not yet received): 20190507182440.4501-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 9 lines · Jagan Teki

CONFIG_SPL_TEXT_BASE was available in configs/rk3399_common.h when the OrangePI rk3399 board supported during first version patch.

But, later below change which move this config into Kconfig and same has been merged in mainline tree.
"configs: move CONFIG_SPL_TEXT_BASE to Kconfig" (sha1: f89d6133eef2e068f9c33853b6584d7fcbfa9d2e)

Quoted 6 lines

Unfortunately, the maintainer applied the initial version patch, instead of looking for next version changes.

Fix it by adding SPL_TEXT_BASE in orangepi-rk3399 defconfig.

Thanks,
- Kever

Quoted 16 lines
---
 configs/orangepi-rk3399_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/orangepi-rk3399_defconfig +1 -0
index cdccf221b5..ba13976cc6 100644
@@ -17,6 +17,7 @@ CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py"
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-orangepi.dtb"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_SPL_TEXT_BASE=0xff8c2000
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
 CONFIG_SPL_ATF=y