Input: libps2 - mark expected switch fall-through
Subsystems (2)
PATCH 1/1 Input: libps2 - mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/input/serio/libps2.c: In function ‘ps2_handle_ack’:drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (ps2dev->flags & PS2_FLAG_NAK) {
^drivers/input/serio/libps2.c:417:2: note: here
case 0x00:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/input/serio/libps2.c | 1 + 1 file changed, 1 insertion(+)
drivers/input/serio/libps2.c +1 -0
@@ -409,6 +409,7 @@ bool ps2_handle_ack(struct ps2dev *ps2dev, u8 data) ps2dev->nak =PS2_RET_ERR ;break ; } +/* Fall through */ /* * Workaround for mice which don't ACK the Get ID command.
Signature · 1 line
2.21.0
Quoted 13 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/input/serio/libps2.c: In function ‘ps2_handle_ack’:drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (ps2dev->flags & PS2_FLAG_NAK) { ^
drivers/input/serio/libps2.c:417:2: note: here
case0x00:
^~~~
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thank you.
Quoted 19 lines
--- drivers/input/serio/libps2.c | 1 + 1 file changed, 1 insertion(+)drivers/input/serio/libps2.c +1
-0@@ -409,6 +409,7 @@ bool ps2_handle_ack(struct ps2dev *ps2dev, u8 data) ps2dev->nak =PS2_RET_ERR ;break ; } +/* Fall through */ /* * Workaround for mice which don't ACK the Get ID command. Signature · 1 line
2.21.0
Signature · 1 line
Dmitry
Quoted 14 lines · Dmitry Torokhov
Quoted 13 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/input/serio/libps2.c: In function ‘ps2_handle_ack’:drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (ps2dev->flags & PS2_FLAG_NAK) { ^
drivers/input/serio/libps2.c:417:2: note: here
case0x00:
^~~~
Quoted 9 lines
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied, thank you.
Awesome. :)
Thanks, Dmitry.
--
Gustavo