Skip to contentSkip to conversation

Remove the obsolete glade3 recipe

PATCH NAK Adrian Bunk 2 participants 3 messages May 7, 2019 – May 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove the obsolete glade3 recipe

After the libbonoboui removal there shouldn't be any reason left for this ancient version instead of the glade recipe in meta-oe that currently builds version 3.22.1.

---
 ...NTF-on-functions-with-format-strings.patch | 62 -------------------
 ...-doc-utils.make-sysrooted-pkg-config.patch | 51 ---------------
 .../glade/glade3/0002-fix-gcc-6-build.patch   | 39 ------------
 .../recipes-devtools/glade/glade3_3.8.5.bb    | 23 -------
 4 files changed, 175 deletions(-)
 delete mode 100644 meta-gnome/recipes-devtools/glade/glade3/0001-Add-G_GNUC_PRINTF-on-functions-with-format-strings.patch
 delete mode 100644 meta-gnome/recipes-devtools/glade/glade3/0001-gnome-doc-utils.make-sysrooted-pkg-config.patch
 delete mode 100644 meta-gnome/recipes-devtools/glade/glade3/0002-fix-gcc-6-build.patch
 delete mode 100644 meta-gnome/recipes-devtools/glade/glade3_3.8.5.bb
meta-gnome/recipes-devtools/glade/glade3/0001-Add-G_GNUC_PRINTF-on-functions-with-format-strings.patch deleted +0 -62
deleted file mode 100644
index 03cb762ce..000000000
@@ -1,62 +0,0 @@
-From fcf29abe59607b5791f9de18ddb86b9ae3c9b7cc Mon Sep 17 00:00:00 2001
-From: Khem Raj <[email protected]>
-Date: Sat, 26 Aug 2017 23:50:05 -0700
-Subject: [PATCH] Add G_GNUC_PRINTF on functions with format strings
-
-This allows compilation with clang without errors, even when
--Wformat-nonliteral is active (as long as there are no real cases of
-non literal formatting).
-
-Signed-off-by: Khem Raj <[email protected]>
----
- gladeui/glade-command.c | 4 ++--
- gladeui/glade-utils.c   | 4 ++--
- 2 files changed, 4 insertions(+), 4 deletions(-)
-
-diff --git a/gladeui/glade-command.c b/gladeui/glade-command.c
-index 9819766..4ac40ee 100644
---- a/gladeui/glade-command.c
-+++ b/gladeui/glade-command.c
-@@ -266,7 +266,7 @@ glade_command_collapse (GladeCommand  *command,
-  *
-  * Marks the begining of a group.
-  */
--void
-+G_GNUC_PRINTF(1, 2) void
- glade_command_push_group (const gchar *fmt, ...)
- {
- 	va_list         args;
-@@ -655,7 +655,7 @@ glade_command_set_properties_list (GladeProject *project, GList *props)
- 
- 	multiple = g_list_length (me->sdata) > 1;
- 	if (multiple)
--		glade_command_push_group (cmd->description);
-+		glade_command_push_group ("%s", cmd->description);
- 
- 
- 	glade_command_check_group (GLADE_COMMAND (me));
-diff --git a/gladeui/glade-utils.c b/gladeui/glade-utils.c
-index ae52501..c51ae59 100644
---- a/gladeui/glade-utils.c
-+++ b/gladeui/glade-utils.c
-@@ -197,7 +197,7 @@ glade_utils_get_pspec_from_funcname (const gchar *funcname)
-  *          selected "OK", True if the @type was GLADE_UI_YES_OR_NO and
-  *          the user selected "YES"; False otherwise.
-  */
--gint
-+G_GNUC_PRINTF(4, 5) gint
- glade_util_ui_message (GtkWidget           *parent, 
- 		       GladeUIMessageType   type,
- 		       GtkWidget           *widget,
-@@ -320,7 +320,7 @@ remove_message_timeout (FlashInfo * fi)
-  *
-  * Flash a temporary message on the statusbar.
-  */
--void
-+G_GNUC_PRINTF(3, 4) void
- glade_util_flash_message (GtkWidget *statusbar, guint context_id, gchar *format, ...)
- {
- 	va_list args;
--- 
-2.14.1
-
meta-gnome/recipes-devtools/glade/glade3/0001-gnome-doc-utils.make-sysrooted-pkg-config.patch deleted +0 -51

51 lines not on this page · raw message

meta-gnome/recipes-devtools/glade/glade3/0002-fix-gcc-6-build.patch deleted +0 -39
deleted file mode 100644
index f735ff819..000000000
@@ -1,39 +0,0 @@
-From 5aa3d2abb905fa8594f6c6572a87809da54c9342 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Andreas=20M=C3=BCller?= <[email protected]>
-Date: Mon, 5 Sep 2016 11:25:27 +0200
-Subject: [PATCH] fix gcc-6 build
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Upstream-Status: Pending
-
-Signed-off-by: Andreas Müller <[email protected]>
----
- gladeui/glade-editor-property.c | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/gladeui/glade-editor-property.c b/gladeui/glade-editor-property.c
-index a0c1039..5e9ac38 100644
---- a/gladeui/glade-editor-property.c
-+++ b/gladeui/glade-editor-property.c
-@@ -2703,6 +2703,8 @@ glade_eprop_object_view (gboolean             radio)
- }
- 
- 
-+#pragma GCC diagnostic push
-+#pragma GCC diagnostic ignored "-Wformat-nonliteral"
- static gchar *
- glade_eprop_object_dialog_title (GladeEditorProperty *eprop)
- {
-@@ -2731,6 +2733,7 @@ glade_eprop_object_dialog_title (GladeEditorProperty *eprop)
- 	return g_strdup_printf (format, g_type_name 
- 				(eprop->klass->pspec->value_type));
- }
-+#pragma GCC diagnostic pop
- 
- 
- gboolean
--- 
-2.5.5
-
meta-gnome/recipes-devtools/glade/glade3_3.8.5.bb deleted +0 -23
deleted file mode 100644
index c3da3e9b9..000000000
@@ -1,23 +0,0 @@
-SUMMARY = "Glade - A User Interface Designer"
-HOMEPAGE = "http://www.gnu.org/software/gnash"
-LICENSE = "GPLv2 & LGPLv2"
-LIC_FILES_CHKSUM = "file://COPYING;md5=aabe87591cb8ae0f3c68be6977bb5522 \
-                    file://COPYING.GPL;md5=9ac2e7cff1ddaf48b6eab6028f23ef88 \
-                    file://COPYING.LGPL;md5=252890d9eee26aab7b432e8b8a616475"
-DEPENDS = "gtk+ gnome-doc-utils gnome-common libxml2 intltool-native"
-
-inherit distro_features_check autotools pkgconfig pythonnative gtk-icon-cache
-
-REQUIRED_DISTRO_FEATURES = "x11"
-
-SRC_URI = "http://ftp.gnome.org/pub/GNOME/sources/glade3/3.8/glade3-${PV}.tar.xz \
-           file://0001-gnome-doc-utils.make-sysrooted-pkg-config.patch \
-           file://0002-fix-gcc-6-build.patch \
-           file://0001-Add-G_GNUC_PRINTF-on-functions-with-format-strings.patch \
-           "
-SRC_URI[md5sum] = "4e4b4f5ee34a03e017e4cef97d796c1f"
-SRC_URI[sha256sum] = "58a5f6e4df4028230ddecc74c564808b7ec4471b1925058e29304f778b6b2735"
-
-EXTRA_OECONF += "--disable-scrollkeeper"
-
-FILES_${PN} += "${datadir}/icons"
Signature · 1 line
2.17.1
#1 lore raw

Hi Adrian

Quoted 4 lines · Adrian Bunk

After the libbonoboui removal there shouldn't be any reason left for this ancient version instead of the glade recipe in meta-oe that currently builds version 3.22.1.

NAK - libxfce4ui PACKAGECONFIG gladeui builds components necessary to open glade files shipped by GTK2 xfce4-panel-plugins. I need that at least until I have ported xfce4-closebutton to GTK3.

So there are use cases.

Cheers

Andreas

#2 lore raw
Quoted 8 lines · Andreas Müller

Hi Adrian

Quoted 4 lines · Adrian Bunk

After the libbonoboui removal there shouldn't be any reason left for this ancient version instead of the glade recipe in meta-oe that currently builds version 3.22.1.

Quoted 8 lines

NAK - libxfce4ui PACKAGECONFIG gladeui builds components necessary to open glade files shipped by GTK2 xfce4-panel-plugins. I need that at least until I have ported xfce4-closebutton to GTK3.

So there are use cases.

Cheers

FYI: I prepared patches to:

* move glade3 -> meta-xfce
* upgrade glade3 -> 3.8.6 (released August 2017). I remember to have tried that but failed because they introduced online-help which needs all the yelp stuff or massive patching. Now I have patches in the queue to support yelp but this series is not yet done [1]

[1] https://github.com/schnitzeltony/meta-openembedded/tree/work-2019-05

Andreas